Merge lp:~doanac/ubuntu-ci-services-itself/webui-status into lp:ubuntu-ci-services-itself

[Andy Doan]

display health of all our ci web services via the webui

display status of all our ci web services via the webui

[Andy Doan (doanac)]

webui: add status display for ci services

Provide a simplified view of the status of each service known
to the webui.

[Chris Johnston (cjohnston)]

I wonder if the link to "Status" should be "Component status" or something
similar. I think status may be too vague.

[Andy Doan (doanac)]

On 03/01/2014 07:30 AM, Chris Johnston wrote:
> I wonder if the link to "Status" should be "Component status" or something
> similar. I think status may be too vague.

I was worried about the same thing. I don't like "component status"
because it feels too big be putting in a menu. Maybe someone with a
better vocabulary than me can come up with a good word for this?

[Evan (ev)]

Health?
Service status?
System status?

Some resources for competitive analysis:
http://status.boundary.com/
http://www.google.co.uk/appsstatus#hl=en&v=status
http://status.aws.amazon.com/
http://honestnetworks.com/wp-content/uploads/2010/04/pingdom-uptime.jpg

[Andy Doan (doanac)]

I'm going to try "System Status" in my setup today and see how it looks. If that's terrible, i'll try Health.

[Andy Doan (doanac)]

This should be ready now. I've changed the wording to "Engine Health"

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:302
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~doanac/ubuntu-ci-services-itself/webui-status/+merge/208917/+edit-commit-message

http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/268/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/268/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:302
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~doanac/ubuntu-ci-services-itself/webui-status/+merge/208917/+edit-commit-message

http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/270/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/270/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:302
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/274/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/274/rebuild

review: Approve (continuous-integration)

[Vincent Ladeuil (vila)]

Shame I can't test it easily even manually :-/

'Engine Health' sounds good.

review: Approve

[Evan (ev)]

Was http://yuilibrary.com/yui/docs/datatable/ not a good fit here?

review: Needs Information

[Andy Doan (doanac)]

On 03/04/2014 04:59 AM, Evan Dandrea wrote:
> Was http://yuilibrary.com/yui/docs/datatable/ not a good fit here?

We don't have a consistent set of values coming back. So I was basically
just dumping the dictionary that comes back. I'm sure someone with
DataTables knowledge (which josepht has) could help me here.

As an example we'll get data back like this:

  = ppa-django/0
  {
   'launchpad_configured': true,
   'total ppas': 4,
   'available ppas': 1
  }

= bsb-restish/0
{
   'rabbit_configured': true,
}

I think this brings up 2 orthogonal decisions:

1) display strategy: should we use something more professional like
DataTables. And if so, should we do it in this MP? I'd say, use
DataTables, but convert in a follow-on MP. No strong opininion

2) data strategy: Maybe we should try and get these "json status
providers" to send status back in a more understood format that the
webui could provide more intelligent display on. I think "yes" for this,
and its probably not that hard. We could change the format to something
like:

  = ppa-django/0
  [
   {
     'label': 'launchpad_configured',
     'value': true,
     'status': 'PASS'
   },
   {
     'label': 'total ppas',
     'value': 4,
     'status': 'WARNING'
   },
   {
     'label': 'available ppas',
     'value': 0,
     'status': 'ERROR'
   }
  ]

is this worth shooting for in phase0?

[Joe Talbott (joetalbott)]

On Tue, Mar 04, 2014 at 03:36:26PM -0000, Andy Doan wrote:
> On 03/04/2014 04:59 AM, Evan Dandrea wrote:
> > Was http://yuilibrary.com/yui/docs/datatable/ not a good fit here?
>
> We don't have a consistent set of values coming back. So I was basically
> just dumping the dictionary that comes back. I'm sure someone with
> DataTables knowledge (which josepht has) could help me here.
>
> As an example we'll get data back like this:
>
> = ppa-django/0
> {
> 'launchpad_configured': true,
> 'total ppas': 4,
> 'available ppas': 1
> }
>
> = bsb-restish/0
> {
> 'rabbit_configured': true,
> }
>
> I think this brings up 2 orthogonal decisions:
>
> 1) display strategy: should we use something more professional like
> DataTables. And if so, should we do it in this MP? I'd say, use
> DataTables, but convert in a follow-on MP. No strong opininion

I'd recommend a follow-on MP because I always end up with big messy
commits when I try to use data-tables.
>
> 2) data strategy: Maybe we should try and get these "json status
> providers" to send status back in a more understood format that the
> webui could provide more intelligent display on. I think "yes" for this,
> and its probably not that hard. We could change the format to something
> like:

I think "yes" too, but that adds coupling between each component and the
webui. Or at worst requires all components to adhere to a "standard"
status format.

[Andy Doan (doanac)]

okay. i think the concensus is merge this and fix better later. I'll start on that now.

review: Approve

[Evan (ev)]

+1

[Chris Johnston (cjohnston)]

More than one proposal found for merge of https://code.launchpad.net/~doanac/ubuntu-ci-services-itself/json-jsonp-status into https://code.launchpad.net/~canonical-ci-engineering/ubuntu-ci-services-itself/trunk, which is not Superseded.

Unmerged revisions

=== modified file 'webui/index.html'
--- webui/index.html	2014-02-17 10:13:29 +0000
+++ webui/index.html	2014-03-03 17:32:11 +0000
@@ -20,6 +20,7 @@
         </div>
         <ul>
           <li><a href="/" class="first ">Ticket List</a></li>
+          <li><a href="/status.html">Engine Health</a></li>
         </ul>
       </nav>
     </header><!-- /#header -->

=== added file 'webui/status.html'
--- webui/status.html	1970-01-01 00:00:00 +0000
+++ webui/status.html	2014-03-03 17:32:11 +0000
@@ -0,0 +1,33 @@
+<html>
+  <head>
+    <link href='https://fonts.googleapis.com/css?family=Ubuntu:400,300,300italic,400italic,700,700italic|Ubuntu+Mono' rel='stylesheet' type='text/css' />
+    <script type="text/javascript" src="http://yui.yahooapis.com/3.14.0/build/yui/yui.js"></script>
+    <script type="text/javascript" src="webui.js"></script>
+    <script type="text/javascript" src="webui_status.js"></script>
+    <link rel="stylesheet" type="text/css" media="screen" href="ubuntu-styles.css" />
+    <link rel="stylesheet" href="webui.css">
+    <title>Ubuntu CI Engine - Service Status</title>
+  </head>
+  <body>
+    <header class="banner global" role="banner">
+      <nav role="navigation" class="nav-primary nav-right">
+        <div class="logo">
+          <a class="logo-ubuntu" href="/">
+            <img width="118" height="27" src="logo-ubuntu-orange.png" alt="Ubuntu logo for print" />
+            <span>CI Engine</span>
+          </a>
+        </div>
+        <ul>
+          <li><a href="/" class="first ">Ticket List</a></li>
+          <li><a href="/status.html">Engine Health</a></li>
+        </ul>
+      </nav>
+    </header><!-- /#header -->
+
+    <div class='container_15 clearfix'>
+    <div class="wrapper">
+    <div id="main-content" class="inner-wrapper">
+    <div id="container"></div>
+    </div></div></div>
+  </body>
+</html>

=== modified file 'webui/ticket.html'
--- webui/ticket.html	2014-02-17 10:13:29 +0000
+++ webui/ticket.html	2014-03-03 17:32:11 +0000
@@ -19,10 +19,11 @@
         </div>
         <ul>
           <li><a href="/" class="first ">Ticket List</a></li>
+          <li><a href="/status.html">Engine Health</a></li>
         </ul>
       </nav>
     </header><!-- /#header -->
-    
+
     <div class='container_15 clearfix'>
     <div class="wrapper">
     <div id="main-content" class="inner-wrapper">

=== added file 'webui/webui_status.js'
--- webui/webui_status.js	1970-01-01 00:00:00 +0000
+++ webui/webui_status.js	2014-03-03 17:32:11 +0000
@@ -0,0 +1,49 @@
+YUI().use('io', 'json-parse', 'jsonp', 'node', 'webui', function(Y) {
+
+  Y.one("div#main-content").setHTML("<h3>CI Engine Health</h3>");
+  table = Y.Node.create("<table>");
+  Y.one("div#main-content").append(table)
+
+  Y.io("/status_urls.json", {
+        on: {
+          success: function(tx, r) {
+            console.log("success");
+            try {
+              data = Y.JSON.parse(r.responseText);
+              for(key in data) {
+                 row = Y.Node.create("<tr>");
+                 row.append(Y.Node.create("<td>"+data[key].unit+"</td>"));
+                 sts = Y.Node.create("<td><a href='"+data[key].url+ "'>loading...</a></td>");
+                 row.append(sts);
+                 table.append(row);
+                 url = data[key].url + "?format=jsonp&callback={callback}";
+                 Y.jsonp(url, {
+                   args: [sts, url],
+                   on: {
+                     success: function(resp, sts, url) {
+                       txt = "<pre>";
+                       for (key in resp) {
+                         txt += key + ": " + resp[key] + "\n";
+                       }
+                       txt += "</pre>";
+                       sts.setHTML(txt);
+                     },
+                     failure: function(e, sts, url) {
+                       console.log('failed to load: ' + data[key].unit);
+                       sts.setHTML("<a href='" + url + "'>failed to load</a>");
+                     }
+                   }
+                 });
+              }
+            }
+            catch (e) {
+              Y.one("div#main-content").setHTML(e);
+              return;
+            }
+          },
+          failure: function(tx, r, e) {
+            console.log("failure: ", tx, r, e);
+          }
+        }
+      });
+});