Code review comment for lp:~doanac/phablet-tools/unlock_screen

Revision history for this message
Andy Doan (doanac) wrote :

On 10/15/2013 11:53 PM, Christopher Lee wrote:

> The intention being that you consume these functions (namely unlock_unity and restart_unity_with_testability) in the unlock script (both here and any other script that does something similar i.e. Utah (and I think there is another CI one?).
> This means that lines 117 - 181 aren't copied about in n-many scripts.
>
> I'm not 100% certain this fits exactly Saviqs vision (i.e. done within the test app), I'll touch base with him in his morning and clarify then.
>
> Let me know if you have any questions or suggestions.

Sounds like there are three ways we could consume this code:

1) call these two functions from phablet-tools
2) modify all our autopilot tests to call this (or a common base class
if possible).

I'm guessing we don't have time to accomplish 2 before we release. So do
we want to try 1 or just keep pushing for 2?

-andy

« Back to merge proposal