Merge lp:~doanac/phablet-tools/unlock_screen into lp:phablet-tools
Status: | Rejected |
---|---|
Rejected by: | Sergio Schvezov |
Proposed branch: | lp:~doanac/phablet-tools/unlock_screen |
Merge into: | lp:phablet-tools |
Diff against target: |
189 lines (+118/-5) 3 files modified
phablet-test-run (+23/-5) setup.py (+3/-0) target/unlock_screen.py (+92/-0) |
To merge this branch: | bzr merge lp:~doanac/phablet-tools/unlock_screen |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michał Sawicz | Disapprove | ||
PS Jenkins bot | continuous-integration | Approve | |
Sergio Schvezov | Needs Fixing | ||
Review via email: mp+191268@code.launchpad.net |
Commit message
add option to phablet-test-run for unlocking the screen
This allows a user to pass "-u" to phablet-test-run. The
unlock_screen.py utility will be copied to the target and
then run right before executing the autopilot testsuite.
Description of the change
We've disputed where to put this in the past, but as we near the end of the release, we need a way to run tests with the screen unlocked. I've copied the unlock_screen.py script that the CI team inherited into the branch. Its mostly un-modified, but I did fix some pep8 complaints.
This adds a new "-u" option to phablet-test-run to unlock the screen.
Unmerged revisions
- 211. By Andy Doan
-
make phablet-test-run default to unlocking the screen
also clean up the usage text so it displays properly on 80 columns
- 210. By Andy Doan
-
review comments from sergio for unlock_screen.py
- 209. By Andy Doan
-
add option to phablet-test-run for unlocking the screen
This allows a user to pass "-u" to phablet-test-run. The
unlock_screen.py utility will be copied to the target and
then run right before executing the autopilot testsuite. - 208. By Andy Doan
-
add unlock_screen.py utility for target device
do we really need to rm this way?
108 + os.system('rm -f /tmp/mir_socket')
Can't we have unity use the env setup? This shouldn't be a problem once the autopilot tests for unity8 are fixed anyways, so I'm ok with it for now, but doing it with os.system instead of open? upstart/ unity8. override" upstart/ unity8. override' )
101 + override_file = "~/.config/
102 +
103 + os.system(
104 + 'echo "exec unity8 -testability" > ~/.config/
Can't we make unlocking the default action?
21 + -u Unlock the greeter before running the testsuite