Code review comment for lp:~doanac/phablet-tools/unlock_screen

> do we really need to rm this way?
> 108 + os.system('rm -f /tmp/mir_socket')

was just copy/pasting the original. i'll fix that.

>
> Can't we have unity use the env setup? This shouldn't be a problem once the
> autopilot tests for unity8 are fixed anyways, so I'm ok with it for now, but
> doing it with os.system instead of open?
> 101 + override_file = "~/.config/upstart/unity8.override"
> 102 +
> 103 + os.system(
> 104 + 'echo "exec unity8 -testability" >
> ~/.config/upstart/unity8.override')

yeah, that's terrible. I'll fix.

> Can't we make unlocking the default action?
> 21 + -u Unlock the greeter before running the testsuite

I started with that approach. Given how close we are to the end, I thought this would offer the best chance of not causing a regression. If you are +1, then I'll make it default.