Code review comment for lp:~dmj726/ubiquity/nvme-fix

Revision history for this message
David Jordan (dmj726) wrote :

I just tested the new code, and your updated regex still breaks the installation in exactly the same way as before.
The portion of the regex that reads '/dev/[a-z]+' truncates the target to '/dev/nvme' before it gets to the bit you added. You should be able to use the following:

            target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/nvme[0-9]+n[0-9]+\
                            |/dev/[a-z]+).*', r'\1', target)

« Back to merge proposal