Code review comment for lp:~diegosarmentero/unity8/processing-signal

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

I can see the pulsating text when going tryPreviewPayments, and the test below (please add it) supports that:

=== modified file 'tests/qmltests/Dash/Previews/tst_PreviewPayments.qml'
--- tests/qmltests/Dash/Previews/tst_PreviewPayments.qml 2014-08-15 18:03:55 +0000
+++ tests/qmltests/Dash/Previews/tst_PreviewPayments.qml 2014-08-19 12:32:44 +0000
@@ -88,6 +88,11 @@
             var button = findChild(root, "paymentButton");
             var progress = findChild(root, "loadingBar");

+ tryCompare(progress, "visible", false);
+ tryCompare(progress, "opacity", 0);
+ tryCompare(button, "visible", true);
+ tryCompare(button, "opacity", 1);
+
             mouseClick(button, button.width / 2, button.height / 2);

             spy.wait();

review: Needs Fixing

« Back to merge proposal