Merge into trunk : processing-signal : Code : Unity 8

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2014-08-20
Michał Sawicz		2014-08-07	Approve on 2014-08-19
Review via email: mp+230002@code.launchpad.net

lp:~diegosarmentero/unity8/processing-signal updated on 2014-08-07

1117. By Diego Sarmentero on 2014-08-07: changing property name

Revision history for this message

Alejandro J. Cura (alecu) wrote on 2014-08-07:

#

Please make sure to test this branch with the very latest change in the spinner (a cylon-like orange bar at the bottom of the screen)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-08:

#

FAILED: Continuous integration, rev:1117
http://jenkins.qa.ubuntu.com/job/unity8-ci/3821/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3209/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/823/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/915
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/915
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/915/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/915
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4454/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3821/rebuild

review: Needs Fixing (continuous-integration)

lp:~diegosarmentero/unity8/processing-signal updated on 2014-08-08

1118. By Diego Sarmentero on 2014-08-08: [ Michal Hruby ]
* Work with the scopes-v4 branch + departments->navigation renaming
[ Michał Sawicz ]
* Hardcode art shape size for click scope local and predefined
  categories While at it, drop the fillmode of cards
* Use the correct API in PageHeader. (LP: #1353048)
* Refactor dash activity indicator. (LP: #1351539)
[ Albert Astals ]
* Dash Departments fixes Update maxHeight manually since it depends on
  the position of the item and its parents and it can't know when the
  binding has to be updated Make parent stuff non interactive when the
  department list is shown
* PageHeader: when on search clip y-coordinates otherwise the
  background spills out when on search (LP: #1350398)
* Dash: Implement OverlayColor support in Cards
* Hardcode art shape size for click scope local and predefined
  categories While at it, drop the fillmode of cards
* Make test_departments test more stable There's various
  DashDepartments on the dash, make sure we're working over the one
  that is on screen, otherwise clicks don't end up where they should
* Work with the scopes-v4 branch + departments->navigation renaming
* Fixes for dash as app Load i18n catalog Process command line options
  Add the posibility to have a mouse touch adaptor (LP: #1353351)
* Implement the Expandable Preview Widget Now TextSummary is not
  expandable by itself anymore, you have to use it inside an
  Expandable to get the behaviour
* Add test prefix to xml output, seems CI needs it
[ Antti Kaijanmäki ]
* Indicators: Adds new ModemInfoItem to be used with indicator-network
  (LP: #1329204)
[ Michael Terry ]
* When the edge demo is running, don't show the greeter if the screen
  is turned off. This avoids an odd interaction where parts of the
  greeter are disabled but the edge demo isn't visible until you slide
  the greeter away. (LP: #1283425)
* Don't hardcode the phablet password in our testing script.
[ Ying-Chun Liu ]
* Add divider dots.
[ Mirco Müller ]
* Make sure the TextField of a snap-decision notification has the
  active focus upon creation, thus the osk shows up right away. (LP:
  #1346867)
[ Andrea Cimitan ]
* Add touchdown effect to dash cards.
* Import Ubuntu.Components for preview image gallery to pick up
  default flicking speeds.
1119. By Diego Sarmentero on 2014-08-08: show processing feedback on action progress
1120. By Diego Sarmentero on 2014-08-08: fix attribute naming
1121. By Diego Sarmentero on 2014-08-08: fixing variable name
1122. By Diego Sarmentero on 2014-08-08: disable button on process action
1123. By Diego Sarmentero on 2014-08-08: link button enabled state to processActive attribute

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-09:

#

FAILED: Continuous integration, rev:1118
http://jenkins.qa.ubuntu.com/job/unity8-ci/3835/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3248/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/837/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/929
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/929
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/929/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/929
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4493/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3835/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-09:

#

FAILED: Continuous integration, rev:1123
http://jenkins.qa.ubuntu.com/job/unity8-ci/3845/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3279
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/847/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/939
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/939
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/939/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/939
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/3241
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4524
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4524/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/11215

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3845/rebuild

review: Needs Fixing (continuous-integration)

lp:~diegosarmentero/unity8/processing-signal updated on 2014-08-11

1124. By Diego Sarmentero on 2014-08-11: fix doc string

Revision history for this message

Michał Sawicz (saviq) wrote on 2014-08-11:

#

I think we should instead replace the button with

ProgressBar {
indeterminate: true
}

This way we don't need the weird "Purchasing…" string, nor we have a button which is not really a button, in the UI. And then the bottom activity indicator is meant to convey that there's communication between the dash and the scope, so the whole page isn't ready, which isn't the case here.

review: Needs Fixing

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-11:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3853/rebuild

review: Needs Fixing (continuous-integration)

lp:~diegosarmentero/unity8/processing-signal updated on 2014-08-11

1125. By Diego Sarmentero on 2014-08-11: show progress bar instead of spinner

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-12:

#

FAILED: Continuous integration, rev:1125
http://jenkins.qa.ubuntu.com/job/unity8-ci/3863/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3353
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/865
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/957
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/957
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/957/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/957
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/3289
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4598
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4598/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/11284

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3863/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michał Sawicz (saviq) wrote on 2014-08-12:

#

See inline.

review: Needs Fixing

Revision history for this message

Michał Sawicz (saviq) wrote on 2014-08-12:

#

Also, could you add a test confirming this behaves as expected?

lp:~diegosarmentero/unity8/processing-signal updated on 2014-08-12

1126. By Diego Sarmentero on 2014-08-12: invert calls
1127. By Diego Sarmentero on 2014-08-12: improves requested
1128. By Diego Sarmentero on 2014-08-12: specific opacity
1129. By Diego Sarmentero on 2014-08-12: opacity fixed

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-13:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3873/rebuild

review: Needs Fixing (continuous-integration)

lp:~diegosarmentero/unity8/processing-signal updated on 2014-08-13

1130. By Diego Sarmentero on 2014-08-13: adding test

Revision history for this message

Michał Sawicz (saviq) wrote on 2014-08-13:

#

See inline.

review: Needs Fixing

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-13:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3882/rebuild

review: Needs Fixing (continuous-integration)

lp:~diegosarmentero/unity8/processing-signal updated on 2014-08-14

1131. By Diego Sarmentero on 2014-08-14: fixing proposal

Revision history for this message

Diego Sarmentero (diegosarmentero) wrote on 2014-08-14:

#

> See inline.

Done

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-14:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3908/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michał Sawicz (saviq) wrote on 2014-08-15:

#

Failed tests:
qmltestrunner.PreviewPaymentsTest::test_purchase_completed
qmltestrunner.PreviewPaymentsTest::test_purchase_error

Your new test leaves artifacts (the progress bar is on screen indefinitely).

You need to either recreate the widget in init() or somehow reset it in cleanup().

review: Needs Fixing

lp:~diegosarmentero/unity8/processing-signal updated on 2014-08-15

1132. By Diego Sarmentero on 2014-08-15: cleanup in test

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-15:

#

FAILED: Continuous integration, rev:1132
http://jenkins.qa.ubuntu.com/job/unity8-ci/3939/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3617
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/940
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1033
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/1033
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/1033/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1033
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/3506
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4864
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4864/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/11572

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3939/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-16:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3958/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-17:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3981/rebuild

review: Approve (continuous-integration)

Revision history for this message

Michał Sawicz (saviq) wrote on 2014-08-19:

#

I can see the pulsating text when going tryPreviewPayments, and the test below (please add it) supports that:

=== modified file 'tests/qmltests/Dash/Previews/tst_PreviewPayments.qml'
--- tests/qmltests/Dash/Previews/tst_PreviewPayments.qml 2014-08-15 18:03:55 +0000
+++ tests/qmltests/Dash/Previews/tst_PreviewPayments.qml 2014-08-19 12:32:44 +0000
@@ -88,6 +88,11 @@
var button = findChild(root, "paymentButton");
var progress = findChild(root, "loadingBar");

+ tryCompare(progress, "visible", false);
+ tryCompare(progress, "opacity", 0);
+ tryCompare(button, "visible", true);
+ tryCompare(button, "opacity", 1);
+
mouseClick(button, button.width / 2, button.height / 2);

spy.wait();

review: Needs Fixing

lp:~diegosarmentero/unity8/processing-signal updated on 2014-08-19

1133. By Diego Sarmentero on 2014-08-19: changing visibility link
1134. By Diego Sarmentero on 2014-08-19: [ CI bot ]
* Resync trunk
[ Michał Sawicz ]
* Fix dash overview test and prevent crash in mock ApplicationInfo's
  d'tor. tryCompareFunction didn't work because .item threw.
[ Michael Terry ]
* Bring dialer to front on incoming call even when device is locked
  (LP: #1354532)
[ CI bot ]
* Resync trunk
[ Michał Sawicz ]
* Use palette's baseText for text colour in dash.
* Update qmltypes definitions
* Move PageHeader out of qml/Components into qml/Dash
* Reshuffle and update dependencies
* Fix cardtool test and make card creator output debugging info on
  errors.
* Support previews for scopes in overview and hook up preview
  processing to activity indicator.
* Fix notifications indicator title
* Fix horizontal list activation and add test for it.
[ Ying-Chun Liu ]
* Add button colors and i18n for power off dialog. (LP: #1354506)
[ Mirco Müller ]
* Force plain-text rendering for summary- and body-text. (LP:
  #1335787)
[ Michael Terry ]
* Add --lightdm= argument to ./run.sh that lets developers choose
  which lightdm backend to use. Stop letting a user that is
  immediately denied via PAM into the shell by fixing some assumptions
  that a user which was not prompted was successfully authenticated.
  This is not a common situation, you'd have to manually change your
  PAM config. Fix a small console warning .
* Make wrong-password handling much nicer by showing a pretty spinner
  while we wait for PAM, by improving the prompt text to match
  designs, by forcing the user to wait five seconds after every five
  failed attemps, and by supporting (but not yet enabling) an opt-in
  "factory-reset your phone after X failed attemps" feature.
[ Michael Zanetti ]
* bring back network caching in dash (LP: #1355729)
[ Michał Sawicz ]
* Add --lightdm= argument to ./run.sh that lets developers choose
  which lightdm backend to use. Stop letting a user that is
  immediately denied via PAM into the shell by fixing some assumptions
  that a user which was not prompted was successfully authenticated.
  This is not a common situation, you'd have to manually change your
  PAM config. Fix a small console warning .
* Fix anchor in PreviewListView.qml.
* Make wrong-password handling much nicer by showing a pretty spinner
  while we wait for PAM, by improving the prompt text to match
  designs, by forcing the user to wait five seconds after every five
  failed attemps, and by supporting (but not yet enabling) an opt-in
  "factory-reset your phone after X failed attemps" feature.
* Add new horizontal list category layout. (LP: #1352226)
* Fix qml tests - loader around PageHeader, more retries for selecting
  a scope and undefined attributes in mock overview scope.
[ Leo Arias ]
* Added autopilot helpers and tests for the launcher and dash icon.
* Added an autopilot helper to click a scope item.
* Added an autopilot test for focusing an app clicking the icon on the
  launcher.
[ Mirco Müller ]
* Allow ENTER/RETURN in a TextField to accept a snap-decision
  notification. (LP: #1305885)
[ Andrea Cimitan ]
* Add emblem support in dash cards.
[ Michael Terry ]
* Fix a variety of design nits with the current lockscreen: * disable
  indicators and launcher when locked * when reversing the direction
  of a greeter flick, treat it as a cancel * don't animate dots when
  changing the infographic data source * make cancelling a login
  nicer: * reduce the delay before greeter starts animating * show the
  greeter from the same side of the screen that it hid to * don't re-
  animate the infographic (LP: #1351027)
[ Stephen M. Webb ]
* enables the unity8 upstart job for desktop sessions (LP: #1353041)
[ Albert Astals ]
* Dash Overview (LP: #1317683)
* GenericScopeView: On click only activate scope:// uris and
  clickscope items The rest of clicks result in a preview, also
  scope:// uris don't get a preview
* Pass the scope search hint up to the search line
[ CI bot ]
* Resync trunk
[ Nick Dedekind ]
* Added application prompt surfaces to allow prompting application
  which have not yet created a surface.

Revision history for this message

Michał Sawicz (saviq) wrote on 2014-08-19:

#

> I can see the pulsating text when going tryPreviewPayments, and the test below (please add it) supports that:

OK this was some temporary thing. Passes / works now. Please that part
of the test to verify.

lp:~diegosarmentero/unity8/processing-signal updated on 2014-08-19

1135. By Diego Sarmentero on 2014-08-19: checking before click

Revision history for this message

Michał Sawicz (saviq) wrote on 2014-08-19:

#

* Did you perform an exploratory manual test run of the code change and any related functionality?
Y
* Did CI run pass? If not, please explain why.
Y!

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-19:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4025/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-20:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4030/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-20:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4032/rebuild

review: Approve (continuous-integration)

Unity 8

Merge lp:~diegosarmentero/unity8/processing-signal into lp:unity8

Commit message

Description of the change

Preview Diff

Subscribers

 === modified file 'qml/Dash/Previews/PreviewPayments.qml'
 --- qml/Dash/Previews/PreviewPayments.qml	2014-06-30 14:43:01 +0000
 +++ qml/Dash/Previews/PreviewPayments.qml	2014-08-19 14:48:34 +0000
@@ -37,9 +37,15 @@
          color: Theme.palette.selected.foreground
          text: paymentClient.formattedPrice
--        onClicked: paymentClient.start()
++        onClicked: {
++            paymentClient.start();
++            paymentButton.opacity = 0;
++        }
          anchors.right: parent.right
          width: (root.width - units.gu(1)) / 2
++        opacity: 1
++        visible: paymentButton.opacity == 0 ? false : true
++        Behavior on opacity { PropertyAnimation { duration: UbuntuAnimation.FastDuration } }
          Payments {
              id: paymentClient
@@ -49,8 +55,21 @@
              price: source["price"]
              currency: source["currency"]
              storeItemId: source["store_item_id"]
--            onPurchaseCompleted: root.triggered(widgetId, "purchaseCompleted", source)
--            onPurchaseError: root.triggered(widgetId, "purchaseError", source)
++            onPurchaseCompleted: {
++                root.triggered(widgetId, "purchaseCompleted", source);
++            }
++            onPurchaseError: {
++                root.triggered(widgetId, "purchaseError", source);
++            }
+         }
+     }
++
++    ProgressBar {
++        id: loadingBar
++        objectName: "loadingBar"
++        indeterminate: true
++        anchors.fill: paymentButton
++        opacity: 1 - paymentButton.opacity
++        visible: !paymentButton.visible
++    }
+ }
 === modified file 'tests/qmltests/Dash/Previews/tst_PreviewPayments.qml'
 --- tests/qmltests/Dash/Previews/tst_PreviewPayments.qml	2014-07-01 14:36:25 +0000
 +++ tests/qmltests/Dash/Previews/tst_PreviewPayments.qml	2014-08-19 14:48:34 +0000
@@ -52,6 +52,8 @@
          function cleanup()
+         {
              spy.clear();
++            var button = findChild(root, "paymentButton");
++            button.opacity = 1;
+         }
          function test_purchase_text_display() {
@@ -79,6 +81,28 @@
              compare(args[2], jsonPurchase["source"]);
+         }
++        function test_progress_show() {
++            // Make sure the progress bar is shown.
++            previewPayments.widgetData = jsonPurchase;
++
++            var button = findChild(root, "paymentButton");
++            var progress = findChild(root, "loadingBar");
++
++            tryCompare(progress, "visible", false);
++            tryCompare(progress, "opacity", 0);
++            tryCompare(button, "visible", true);
++            tryCompare(button, "opacity", 1);
++
++            mouseClick(button, button.width / 2, button.height / 2);
++
++            spy.wait();
++
++            tryCompare(progress, "visible", true);
++            tryCompare(progress, "opacity", 1);
++            tryCompare(button, "visible", false);
++            tryCompare(button, "opacity", 0);
++        }
++
          function test_purchase_error() {
              // The mock Payments triggers an error when com.example.invalid is
              // passed to it as store_item_id. Exercise it here