Merge lp:~diegosarmentero/ubuntuone-windows-installer/close-on-license-again into lp:ubuntuone-windows-installer
Proposed by
Diego Sarmentero
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Roberto Alsina | ||||
Approved revision: | 78 | ||||
Merged at revision: | 80 | ||||
Proposed branch: | lp:~diegosarmentero/ubuntuone-windows-installer/close-on-license-again | ||||
Merge into: | lp:ubuntuone-windows-installer | ||||
Diff against target: |
43 lines (+6/-6) 2 files modified
ubuntuone_installer/gui/qt/gui.py (+2/-2) ubuntuone_installer/gui/qt/tests/test_gui.py (+4/-4) |
||||
To merge this branch: | bzr merge lp:~diegosarmentero/ubuntuone-windows-installer/close-on-license-again | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Roberto Alsina (community) | Approve | ||
Manuel de la Peña (community) | Approve | ||
Review via email: mp+78596@code.launchpad.net |
Commit message
Fixed: Wizard is not closed on license agreement screen (LP: #835167).
Description of the change
Fixed: Wizard is not closed on license agreement screen (LP: #835167).
To post a comment you must log in.
What happened here is that the return value of the dialog changed. I think that the best way to approach this would be to have a couple of constants against the ones we can compare. For example:
if AreYouSure( self).exec_ () == AreYouSure( self).YES:
print 'You are sure!'
That way if the value returned changed the code is still valid and the reponsability of ensuring that the dialog works in on the dialog developer and not the user.