Code review comment for lp:~diegosarmentero/ubuntuone-windows-installer/close-on-license-again

Revision history for this message
Manuel de la Peña (mandel) wrote :

> What happened here is that the return value of the dialog changed. I think
> that the best way to approach this would be to have a couple of constants
> against the ones we can compare. For example:
>
> if AreYouSure(self).exec_() == AreYouSure.YES:
> print 'You are sure!'
>
> That way if the value returned changed the code is still valid and the
> reponsability of ensuring that the dialog works in on the dialog developer and
> not the user.

Remove the (self), sorry for the typo, stupid copy and paste :P

« Back to merge proposal