Merge lp:~diegosarmentero/ubuntuone-windows-installer/captcha-refresh into lp:ubuntuone-windows-installer
- captcha-refresh
- Merge into trunk
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Natalia Bidart | ||||||||
Approved revision: | 78 | ||||||||
Merged at revision: | 74 | ||||||||
Proposed branch: | lp:~diegosarmentero/ubuntuone-windows-installer/captcha-refresh | ||||||||
Merge into: | lp:ubuntuone-windows-installer | ||||||||
Diff against target: |
251 lines (+53/-17) 9 files modified
ubuntuone_installer/gui/qt/gui.py (+2/-1) ubuntuone_installer/gui/qt/main/tests/test_windows.py (+1/-1) ubuntuone_installer/gui/qt/main/windows.py (+3/-1) ubuntuone_installer/gui/qt/setup_account.py (+14/-0) ubuntuone_installer/gui/qt/tests/test_gui.py (+4/-2) ubuntuone_installer/gui/qt/tests/test_setup_account.py (+21/-0) ubuntuone_installer/gui/qt/utils/__init__.py (+2/-2) ubuntuone_installer/gui/qt/utils/tests/test_windows.py (+5/-9) ubuntuone_installer/gui/qt/utils/windows.py (+1/-1) |
||||||||
To merge this branch: | bzr merge lp:~diegosarmentero/ubuntuone-windows-installer/captcha-refresh | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Natalia Bidart (community) | Approve | ||
Roberto Alsina (community) | Approve | ||
Review via email:
|
Commit message
- Fixed: There is no feedback on captcha loading/refreshing (LP: #852105).
Description of the change
- Fixed: There is no feedback on captcha loading/refreshing (LP: #852105).
- 74. By Diego Sarmentero
-
Fixed lint issues.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Natalia Bidart (nataliabidart) wrote : | # |
I'm now getting all these PEP8 issues:
./ubuntuone_
./ubuntuone_
./ubuntuone_
./ubuntuone_
./ubuntuone_
./ubuntuone_
./ubuntuone_
./ubuntuone_
./ubuntuone_
./ubuntuone_
./ubuntuone_
./ubuntuone_
./ubuntuone_
Seems like last week several errors were added to the repo.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Natalia Bidart (nataliabidart) wrote : | # |
Can you please add those, even those are not added by your branch?
Thanks!
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Diego Sarmentero (diegosarmentero) wrote : | # |
> Can you please add those, even those are not added by your branch?
>
> Thanks!
Yes, no problem!
- 75. By Diego Sarmentero
-
Fixed PEP8 issues.
- 76. By Diego Sarmentero
-
Added bug number.
- 77. By Diego Sarmentero
-
Fixed PEP8 issues.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Natalia Bidart (nataliabidart) wrote : | # |
Looks good!
One thing to fix:
10:30:55 AM) nessita: gatox: and what I see is that as soon as I open the installer, the overlay is shown, even if I did not click on register
(10:31:18 AM) nessita: gatox: that should not be there: the loading overlay shoul only be shown in the register screen (when loading captcha)
(10:31:41 AM) ralsina: that's because we are loading the captcha in __init__
(10:31:47 AM) ralsina: and we should load it in initializePage
(10:31:57 AM) ralsina: that's a sso fix
(10:32:19 AM) nessita: gatox: open the installer with your captcha branch, having the sso captcha branch in the PYTHONPATH
(10:32:34 AM) nessita: gatox: you will get the overlay in the first screen of the installer
- 78. By Diego Sarmentero
-
Fixed overlay to only show if the captcha has not been received and the user reach the setup account page.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Natalia Bidart (nataliabidart) wrote : | # |
Looks good!
Preview Diff
1 | === modified file 'ubuntuone_installer/gui/qt/gui.py' | |||
2 | --- ubuntuone_installer/gui/qt/gui.py 2011-09-22 19:05:56 +0000 | |||
3 | +++ ubuntuone_installer/gui/qt/gui.py 2011-09-28 17:34:23 +0000 | |||
4 | @@ -85,7 +85,8 @@ | |||
5 | 85 | SKIP_TOUR = _("Skip tour, go to Dashboard") | 85 | SKIP_TOUR = _("Skip tour, go to Dashboard") |
6 | 86 | START_SETUP = _("Start setup") | 86 | START_SETUP = _("Start setup") |
7 | 87 | UPDATE_TITLE = _("Updates are available") | 87 | UPDATE_TITLE = _("Updates are available") |
9 | 88 | UPDATE_SOFTWARE = _("There is a new version available. Do you want perform an upgrade?") | 88 | UPDATE_SOFTWARE = _("There is a new version available. " |
10 | 89 | "Do you want perform an upgrade?") | ||
11 | 89 | # Invalid name logger | 90 | # Invalid name logger |
12 | 90 | # pylint: disable=C0103 | 91 | # pylint: disable=C0103 |
13 | 91 | logger = setup_logging('qt.gui') | 92 | logger = setup_logging('qt.gui') |
14 | 92 | 93 | ||
15 | === modified file 'ubuntuone_installer/gui/qt/main/tests/test_windows.py' | |||
16 | --- ubuntuone_installer/gui/qt/main/tests/test_windows.py 2011-09-22 19:05:56 +0000 | |||
17 | +++ ubuntuone_installer/gui/qt/main/tests/test_windows.py 2011-09-28 17:34:23 +0000 | |||
18 | @@ -86,7 +86,7 @@ | |||
19 | 86 | """A fake stop.""" | 86 | """A fake stop.""" |
20 | 87 | self.stopped = True | 87 | self.stopped = True |
21 | 88 | 88 | ||
23 | 89 | def check_updates(self, gui, logger): | 89 | def check_updates(self, gui_ref, logger): |
24 | 90 | """A fake check updates.""" | 90 | """A fake check updates.""" |
25 | 91 | self.updates_checked = True | 91 | self.updates_checked = True |
26 | 92 | 92 | ||
27 | 93 | 93 | ||
28 | === modified file 'ubuntuone_installer/gui/qt/main/windows.py' | |||
29 | --- ubuntuone_installer/gui/qt/main/windows.py 2011-09-22 19:40:28 +0000 | |||
30 | +++ ubuntuone_installer/gui/qt/main/windows.py 2011-09-28 17:34:23 +0000 | |||
31 | @@ -44,6 +44,7 @@ | |||
32 | 44 | 'Error while getting the credentials: %r', exc) | 44 | 'Error while getting the credentials: %r', exc) |
33 | 45 | stop() | 45 | stop() |
34 | 46 | 46 | ||
35 | 47 | |||
36 | 47 | @defer.inlineCallbacks | 48 | @defer.inlineCallbacks |
37 | 48 | def success_cb(creds, gui, installing, logger): | 49 | def success_cb(creds, gui, installing, logger): |
38 | 49 | """Handle credentials success.""" | 50 | """Handle credentials success.""" |
39 | @@ -84,13 +85,14 @@ | |||
40 | 84 | else: | 85 | else: |
41 | 85 | yield success_cb(creds, gui, installer, logger) | 86 | yield success_cb(creds, gui, installer, logger) |
42 | 86 | 87 | ||
43 | 88 | |||
44 | 87 | @defer.inlineCallbacks | 89 | @defer.inlineCallbacks |
45 | 88 | def check_updates(gui, logger): | 90 | def check_updates(gui, logger): |
46 | 89 | """Check for updates.""" | 91 | """Check for updates.""" |
47 | 90 | logger.info('Checking for updates.') | 92 | logger.info('Checking for updates.') |
48 | 91 | # the idea is simple, check if there are updates, ask user if we perform | 93 | # the idea is simple, check if there are updates, ask user if we perform |
49 | 92 | # the update and continue. | 94 | # the update and continue. |
51 | 93 | are_updates_present = yield utils.are_updates_present(logger) | 95 | are_updates_present = yield utils.are_updates_present(logger) |
52 | 94 | logger.debug('Updates present: %r', are_updates_present) | 96 | logger.debug('Updates present: %r', are_updates_present) |
53 | 95 | if are_updates_present: | 97 | if are_updates_present: |
54 | 96 | logger.info('Updates are present.') | 98 | logger.info('Updates are present.') |
55 | 97 | 99 | ||
56 | === modified file 'ubuntuone_installer/gui/qt/setup_account.py' | |||
57 | --- ubuntuone_installer/gui/qt/setup_account.py 2011-09-16 18:01:37 +0000 | |||
58 | +++ ubuntuone_installer/gui/qt/setup_account.py 2011-09-28 17:34:23 +0000 | |||
59 | @@ -70,6 +70,7 @@ | |||
60 | 70 | self.ui.hlayout_check.addWidget(self.terms_checkbox) | 70 | self.ui.hlayout_check.addWidget(self.terms_checkbox) |
61 | 71 | 71 | ||
62 | 72 | self.set_up_button = None | 72 | self.set_up_button = None |
63 | 73 | self.captcha_received = False | ||
64 | 73 | 74 | ||
65 | 74 | # Invalid name "initializePage" | 75 | # Invalid name "initializePage" |
66 | 75 | # pylint: disable=C0103 | 76 | # pylint: disable=C0103 |
67 | @@ -183,6 +184,8 @@ | |||
68 | 183 | QtCore.SIGNAL("focusChanged(QWidget*, QWidget*)"), | 184 | QtCore.SIGNAL("focusChanged(QWidget*, QWidget*)"), |
69 | 184 | self.focus_changed) | 185 | self.focus_changed) |
70 | 185 | super(SetupAccountPage, self).showEvent(event) | 186 | super(SetupAccountPage, self).showEvent(event) |
71 | 187 | if not self.captcha_received: | ||
72 | 188 | self.wizard().overlay.show() | ||
73 | 186 | 189 | ||
74 | 187 | def hideEvent(self, event): | 190 | def hideEvent(self, event): |
75 | 188 | """Disconnect the focusChanged signal when the page change.""" | 191 | """Disconnect the focusChanged signal when the page change.""" |
76 | @@ -196,6 +199,17 @@ | |||
77 | 196 | pass | 199 | pass |
78 | 197 | super(SetupAccountPage, self).hideEvent(event) | 200 | super(SetupAccountPage, self).hideEvent(event) |
79 | 198 | 201 | ||
80 | 202 | def on_captcha_refreshing(self): | ||
81 | 203 | """Show overlay when captcha is refreshing.""" | ||
82 | 204 | if self.isVisible(): | ||
83 | 205 | self.wizard().overlay.show() | ||
84 | 206 | self.captcha_received = False | ||
85 | 207 | |||
86 | 208 | def on_captcha_refresh_complete(self): | ||
87 | 209 | """Hide overlay when captcha finished refreshing.""" | ||
88 | 210 | self.wizard().overlay.hide() | ||
89 | 211 | self.captcha_received = True | ||
90 | 212 | |||
91 | 199 | 213 | ||
92 | 200 | def is_min_required_password(password): | 214 | def is_min_required_password(password): |
93 | 201 | """Return if the password meets the minimum requirements.""" | 215 | """Return if the password meets the minimum requirements.""" |
94 | 202 | 216 | ||
95 | === modified file 'ubuntuone_installer/gui/qt/tests/test_gui.py' | |||
96 | --- ubuntuone_installer/gui/qt/tests/test_gui.py 2011-09-22 19:05:56 +0000 | |||
97 | +++ ubuntuone_installer/gui/qt/tests/test_gui.py 2011-09-28 17:34:23 +0000 | |||
98 | @@ -664,6 +664,7 @@ | |||
99 | 664 | QtGui.QWizard.FinishButton, | 664 | QtGui.QWizard.FinishButton, |
100 | 665 | QtGui.QWizard.NextButton]) | 665 | QtGui.QWizard.NextButton]) |
101 | 666 | 666 | ||
102 | 667 | |||
103 | 667 | class UpgradeQuestion(BaseTestCase): | 668 | class UpgradeQuestion(BaseTestCase): |
104 | 668 | """Test the dialog that ask the user if he wants to upgrade.""" | 669 | """Test the dialog that ask the user if he wants to upgrade.""" |
105 | 669 | 670 | ||
106 | @@ -672,7 +673,7 @@ | |||
107 | 672 | """Set the tests.""" | 673 | """Set the tests.""" |
108 | 673 | yield super(UpgradeQuestion, self).setUp() | 674 | yield super(UpgradeQuestion, self).setUp() |
109 | 674 | self.answer = 0 | 675 | self.answer = 0 |
111 | 675 | self.parent = None | 676 | self.parent = None |
112 | 676 | self.title = None | 677 | self.title = None |
113 | 677 | self.text = None | 678 | self.text = None |
114 | 678 | self.yes_button = None | 679 | self.yes_button = None |
115 | @@ -704,7 +705,8 @@ | |||
116 | 704 | def user_wants_to_update_false(self): | 705 | def user_wants_to_update_false(self): |
117 | 705 | """Test the question.""" | 706 | """Test the question.""" |
118 | 706 | self.answer = gui.QtGui.QMessageBox.No | 707 | self.answer = gui.QtGui.QMessageBox.No |
120 | 707 | self.assertFalse(gui.user_wants_to_update(), 'User DOES NOT want to update.') | 708 | self.assertFalse(gui.user_wants_to_update(), |
121 | 709 | 'User DOES NOT want to update.') | ||
122 | 708 | # lets assert the parameters | 710 | # lets assert the parameters |
123 | 709 | self.assertTrue(None, self.parent) | 711 | self.assertTrue(None, self.parent) |
124 | 710 | self.assertTrue(self.title, gui.UPDATE_TITLE) | 712 | self.assertTrue(self.title, gui.UPDATE_TITLE) |
125 | 711 | 713 | ||
126 | === modified file 'ubuntuone_installer/gui/qt/tests/test_setup_account.py' | |||
127 | --- ubuntuone_installer/gui/qt/tests/test_setup_account.py 2011-09-19 15:41:40 +0000 | |||
128 | +++ ubuntuone_installer/gui/qt/tests/test_setup_account.py 2011-09-28 17:34:23 +0000 | |||
129 | @@ -165,6 +165,8 @@ | |||
130 | 165 | self.ui.set_up_button) | 165 | self.ui.set_up_button) |
131 | 166 | self.assertFalse(self.ui.set_up_button.isEnabled()) | 166 | self.assertFalse(self.ui.set_up_button.isEnabled()) |
132 | 167 | 167 | ||
133 | 168 | self.assertFalse(self.ui.captcha_received) | ||
134 | 169 | |||
135 | 168 | # labels | 170 | # labels |
136 | 169 | self.assertEqual(self.ui.ui.name_label.text(), gui.NAME) | 171 | self.assertEqual(self.ui.ui.name_label.text(), gui.NAME) |
137 | 170 | self.assertEqual(self.ui.ui.email_label.text(), gui.EMAIL) | 172 | self.assertEqual(self.ui.ui.email_label.text(), gui.EMAIL) |
138 | @@ -187,6 +189,7 @@ | |||
139 | 187 | """Validation and overlay is shown when the setupbutton is clicked.""" | 189 | """Validation and overlay is shown when the setupbutton is clicked.""" |
140 | 188 | self.patch(self.ui.controller, 'set_next_validation', self._set_called) | 190 | self.patch(self.ui.controller, 'set_next_validation', self._set_called) |
141 | 189 | self.ui.initializePage() | 191 | self.ui.initializePage() |
142 | 192 | self.ui.captcha_received = True | ||
143 | 190 | self.ui.show() | 193 | self.ui.show() |
144 | 191 | self.addCleanup(self.ui.hide) | 194 | self.addCleanup(self.ui.hide) |
145 | 192 | 195 | ||
146 | @@ -307,3 +310,21 @@ | |||
147 | 307 | """Check that show_event works when set_up_button is none.""" | 310 | """Check that show_event works when set_up_button is none.""" |
148 | 308 | self.assertEqual(self.ui.set_up_button, None) | 311 | self.assertEqual(self.ui.set_up_button, None) |
149 | 309 | self.ui.showEvent(QtGui.QShowEvent()) | 312 | self.ui.showEvent(QtGui.QShowEvent()) |
150 | 313 | |||
151 | 314 | def test_on_captcha_refreshing(self): | ||
152 | 315 | """Check the state of the overlay on captcha refreshing.""" | ||
153 | 316 | self.assertEqual(self.ui.wizard().overlay.show_counter, 0) | ||
154 | 317 | self.ui.on_captcha_refreshing() | ||
155 | 318 | self.assertEqual(self.ui.wizard().overlay.show_counter, 0) | ||
156 | 319 | self.ui.captcha_received = True | ||
157 | 320 | self.ui.show() | ||
158 | 321 | self.addCleanup(self.ui.hide) | ||
159 | 322 | self.assertEqual(self.ui.wizard().overlay.show_counter, 0) | ||
160 | 323 | self.ui.on_captcha_refreshing() | ||
161 | 324 | self.assertEqual(self.ui.wizard().overlay.show_counter, 1) | ||
162 | 325 | |||
163 | 326 | def test_on_captcha_refresh_complete(self): | ||
164 | 327 | """Check the state of the overlay on captcha refreshing complete.""" | ||
165 | 328 | self.assertEqual(self.ui.wizard().overlay.hide_counter, 0) | ||
166 | 329 | self.ui.on_captcha_refresh_complete() | ||
167 | 330 | self.assertEqual(self.ui.wizard().overlay.hide_counter, 1) | ||
168 | 310 | 331 | ||
169 | === modified file 'ubuntuone_installer/gui/qt/utils/__init__.py' | |||
170 | --- ubuntuone_installer/gui/qt/utils/__init__.py 2011-09-19 15:14:38 +0000 | |||
171 | +++ ubuntuone_installer/gui/qt/utils/__init__.py 2011-09-28 17:34:23 +0000 | |||
172 | @@ -36,5 +36,5 @@ | |||
173 | 36 | start_control_panel = linux.start_control_panel | 36 | start_control_panel = linux.start_control_panel |
174 | 37 | add_syncdaemon_to_autostart = linux.add_syncdaemon_to_autostart | 37 | add_syncdaemon_to_autostart = linux.add_syncdaemon_to_autostart |
175 | 38 | default_folders = linux.default_folders | 38 | default_folders = linux.default_folders |
178 | 39 | are_updates_present = lambda *args, **kwargs: False | 39 | are_updates_present = lambda *args, **kwargs: False |
179 | 40 | perform_update = lambda *args, **kwargs: None | 40 | perform_update = lambda *args, **kwargs: None |
180 | 41 | 41 | ||
181 | === modified file 'ubuntuone_installer/gui/qt/utils/tests/test_windows.py' | |||
182 | --- ubuntuone_installer/gui/qt/utils/tests/test_windows.py 2011-09-22 19:40:28 +0000 | |||
183 | +++ ubuntuone_installer/gui/qt/utils/tests/test_windows.py 2011-09-28 17:34:23 +0000 | |||
184 | @@ -196,7 +196,7 @@ | |||
185 | 196 | self.assertEqual(self.registry.set_args, | 196 | self.assertEqual(self.registry.set_args, |
186 | 197 | [(('KEY', 'Ubuntu One', 0, 1, | 197 | [(('KEY', 'Ubuntu One', 0, 1, |
187 | 198 | 'C:\\Python27\\ubuntuone-syncdaemon.exe'), {}), | 198 | 'C:\\Python27\\ubuntuone-syncdaemon.exe'), {}), |
189 | 199 | (('KEY', 'Ubuntu One Icon', 0, 1, | 199 | (('KEY', 'Ubuntu One Icon', 0, 1, |
190 | 200 | 'C:\\Python27\\ubuntuone-control-panel-qt.exe --minimized'), | 200 | 'C:\\Python27\\ubuntuone-control-panel-qt.exe --minimized'), |
191 | 201 | {})]) | 201 | {})]) |
192 | 202 | 202 | ||
193 | @@ -247,7 +247,7 @@ | |||
194 | 247 | def debug(self, message, *args, **kwargs): | 247 | def debug(self, message, *args, **kwargs): |
195 | 248 | """Set a debug log message.""" | 248 | """Set a debug log message.""" |
196 | 249 | self.called_methods.append(('debug', message, args, kwargs)) | 249 | self.called_methods.append(('debug', message, args, kwargs)) |
198 | 250 | 250 | ||
199 | 251 | 251 | ||
200 | 252 | class AutoupdaterTestCase(BaseTestCase): | 252 | class AutoupdaterTestCase(BaseTestCase): |
201 | 253 | """Test the code that is used for the auto update process.""" | 253 | """Test the code that is used for the auto update process.""" |
202 | @@ -270,14 +270,13 @@ | |||
203 | 270 | self.fake_logger = FakeLogger() | 270 | self.fake_logger = FakeLogger() |
204 | 271 | self.patch(utils.windows, 'getProcessValue', fake_execute_process) | 271 | self.patch(utils.windows, 'getProcessValue', fake_execute_process) |
205 | 272 | self.patch(utils.windows, '_get_update_path', | 272 | self.patch(utils.windows, '_get_update_path', |
208 | 273 | lambda:self.auto_update_path) | 273 | lambda: self.auto_update_path) |
207 | 274 | |||
209 | 275 | 274 | ||
210 | 276 | @defer.inlineCallbacks | 275 | @defer.inlineCallbacks |
211 | 277 | def test_are_updates_present_true(self): | 276 | def test_are_updates_present_true(self): |
212 | 278 | """Test when updates are present.""" | 277 | """Test when updates are present.""" |
213 | 279 | # the idea is simple, set the value to be returned from | 278 | # the idea is simple, set the value to be returned from |
215 | 280 | # the fake call, assert that we get true and also that | 279 | # the fake call, assert that we get true and also that |
216 | 281 | # we did use the correct parameters. | 280 | # we did use the correct parameters. |
217 | 282 | self.return_from_call = 0 | 281 | self.return_from_call = 0 |
218 | 283 | are_present = yield utils.are_updates_present(self.fake_logger) | 282 | are_present = yield utils.are_updates_present(self.fake_logger) |
219 | @@ -287,13 +286,12 @@ | |||
220 | 287 | self.assertEqual(expected_args, self.args) | 286 | self.assertEqual(expected_args, self.args) |
221 | 288 | self.assertEqual(self.command, self.auto_update_path) | 287 | self.assertEqual(self.command, self.auto_update_path) |
222 | 289 | 288 | ||
223 | 290 | |||
224 | 291 | @defer.inlineCallbacks | 289 | @defer.inlineCallbacks |
225 | 292 | def test_are_updates_present_false(self): | 290 | def test_are_updates_present_false(self): |
226 | 293 | """Test when updates are not present.""" | 291 | """Test when updates are not present.""" |
227 | 294 | # similar to test_are_updates_present_true but with diff retcode | 292 | # similar to test_are_updates_present_true but with diff retcode |
228 | 295 | self.return_from_call = 40 | 293 | self.return_from_call = 40 |
230 | 296 | are_present = yield utils.are_updates_present(self.fake_logger) | 294 | are_present = yield utils.are_updates_present(self.fake_logger) |
231 | 297 | self.assertFalse(are_present, 'Updates should NOT be present.') | 295 | self.assertFalse(are_present, 'Updates should NOT be present.') |
232 | 298 | # lets assert that we did use the correct args | 296 | # lets assert that we did use the correct args |
233 | 299 | expected_args = ('--mode', 'unattended') | 297 | expected_args = ('--mode', 'unattended') |
234 | @@ -312,5 +310,3 @@ | |||
235 | 312 | 310 | ||
236 | 313 | def test_get_auto_update_path(self): | 311 | def test_get_auto_update_path(self): |
237 | 314 | """Test the method used to get the autoupdate.""" | 312 | """Test the method used to get the autoupdate.""" |
238 | 315 | |||
239 | 316 | |||
240 | 317 | 313 | ||
241 | === modified file 'ubuntuone_installer/gui/qt/utils/windows.py' | |||
242 | --- ubuntuone_installer/gui/qt/utils/windows.py 2011-09-22 19:40:28 +0000 | |||
243 | +++ ubuntuone_installer/gui/qt/utils/windows.py 2011-09-28 17:34:23 +0000 | |||
244 | @@ -31,7 +31,7 @@ | |||
245 | 31 | # pylint: enable=F0401 | 31 | # pylint: enable=F0401 |
246 | 32 | 32 | ||
247 | 33 | from twisted.internet import defer | 33 | from twisted.internet import defer |
249 | 34 | from twisted.internet.utils import getProcessValue | 34 | from twisted.internet.utils import getProcessValue |
250 | 35 | 35 | ||
251 | 36 | AUTORUN_KEY = r"Software\Microsoft\Windows\CurrentVersion\Run" | 36 | AUTORUN_KEY = r"Software\Microsoft\Windows\CurrentVersion\Run" |
252 | 37 | 37 |
Lint issues:
ubuntuone_ installer/ gui/qt/ gui.py:
88: [C0301] Line too long (88/79)
ubuntuone_ installer/ gui/qt/ main/tests/ test_windows. py: nTestCase. check_updates] Redefining name 'gui' from outer scope (line 24)
89: [W0621, CredsFailureMai
ubuntuone_ installer/ gui/qt/ tests/test_ gui.py:
707: [C0301] Line too long (85/79)