Code review comment for lp:~diegosarmentero/ubuntuone-client/ipcmenu

Revision history for this message
Alejandro J. Cura (alecu) wrote :

Please make constants out of the keys for the data dict ('recent-transfers' and 'uploading'), so that the strings are only defined once and use those constants through the branch. This makes it faster to catch mistakes.

Please provide detailed information on the keys, and very detailed info too on the dbus types of each of the possible values, of the dbus dictionary of variants returned by the method exposed on dbus. This should be done as a multiline docstring of the exported method.

review: Needs Fixing

« Back to merge proposal