Merge lp:~diegosarmentero/ubuntuone-client/ipcmenu into lp:ubuntuone-client
Proposed by
Diego Sarmentero
Status: | Merged |
---|---|
Approved by: | Alejandro J. Cura |
Approved revision: | 1298 |
Merged at revision: | 1290 |
Proposed branch: | lp:~diegosarmentero/ubuntuone-client/ipcmenu |
Merge into: | lp:ubuntuone-client |
Prerequisite: | lp:~diegosarmentero/ubuntuone-client/menu |
Diff against target: |
346 lines (+126/-11) 12 files modified
contrib/testing/testcase.py (+6/-0) tests/platform/ipc/test_external_interface.py (+14/-0) tests/platform/test_tools.py (+10/-0) tests/status/test_aggregator.py (+16/-7) ubuntuone/platform/ipc/ipc_client.py (+16/-0) ubuntuone/platform/ipc/linux.py (+33/-0) ubuntuone/platform/ipc/perspective_broker.py (+5/-0) ubuntuone/platform/tools/__init__.py (+7/-0) ubuntuone/status/aggregator.py (+1/-1) ubuntuone/syncdaemon/__init__.py (+5/-0) ubuntuone/syncdaemon/interaction_interfaces.py (+4/-0) ubuntuone/syncdaemon/status_listener.py (+9/-3) |
To merge this branch: | bzr merge lp:~diegosarmentero/ubuntuone-client/ipcmenu |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alejandro J. Cura (community) | Approve | ||
Brian Curtin (community) | Approve | ||
Roberto Alsina (community) | Approve | ||
Review via email: mp+118621@code.launchpad.net |
Commit message
- Adding ipc support to share the menu data (LP: #1032659).
To post a comment you must log in.
Please make constants out of the keys for the data dict ('recent-transfers' and 'uploading'), so that the strings are only defined once and use those constants through the branch. This makes it faster to catch mistakes.
Please provide detailed information on the keys, and very detailed info too on the dbus types of each of the possible values, of the dbus dictionary of variants returned by the method exposed on dbus. This should be done as a multiline docstring of the exported method.