Code review comment for lp:~diegosarmentero/ubuntu-sso-client/reset-password-page

We need to maintain a strict separation between the modules where, all the QT related stuff end inside the gui/qt python package. So all the new addings to ubuntu_sso/utils/ui.py can't be there. This module only holds constants and methods that are common to any UI implementation.

So, we can't have QT-specific markup such as BAD, GOOD, NORMAL nor any of the password_* or check_* methods. If you need a common place, I would advice gui/qt/__init__.py or a gui/qt/common.py module.
Of course tests should be moved too.

For reference, when running the non-qt suite, I'm having a crash like this:

  LineEditStyleTestCase
    test_check_invalid ... QWidget: Must construct a QApplication before a QPaintDevice
Aborted

because if no -qt switch is given, we use the glib reactor (and we want to keep that suite running with that reactor).