Merge lp:~diegosarmentero/ubuntu-sso-client/reset-password-page into lp:ubuntu-sso-client

[Diego Sarmentero]

Reset Password Page Complete.

Reset Password Page Complete.

[Roberto Alsina (ralsina)]

+1 looks good!

review: Approve

[Natalia Bidart (nataliabidart)]

We need to maintain a strict separation between the modules where, all the QT related stuff end inside the gui/qt python package. So all the new addings to ubuntu_sso/utils/ui.py can't be there. This module only holds constants and methods that are common to any UI implementation.

So, we can't have QT-specific markup such as BAD, GOOD, NORMAL nor any of the password_* or check_* methods. If you need a common place, I would advice gui/qt/__init__.py or a gui/qt/common.py module.
Of course tests should be moved too.

For reference, when running the non-qt suite, I'm having a crash like this:

  LineEditStyleTestCase
    test_check_invalid ... QWidget: Must construct a QApplication before a QPaintDevice
Aborted

because if no -qt switch is given, we use the glib reactor (and we want to keep that suite running with that reactor).

review: Needs Fixing

[lp:~diegosarmentero/ubuntu-sso-client/reset-password-page]

774. By Diego Sarmentero on 2011-09-01

Added Qt common functionality to common.py module.

[Natalia Bidart (nataliabidart)]

* ubuntu_sso/qt/tests/test_reset_password.py:
    82: [W0212, SetupAccountTestCase.test_focus_changed_1] Access to a protected member _called of a client class
    85: [W0212, SetupAccountTestCase.test_focus_changed_1] Access to a protected member _called of a client class
    93: [W0212, SetupAccountTestCase.test_focus_changed_2] Access to a protected member _called of a client class
    96: [W0212, SetupAccountTestCase.test_focus_changed_2] Access to a protected member _called of a client class

* Question: should showEvent and hideEvent call super()?

* Silly fix: ubuntu_sso/qt/tests/test_common.py should have you as author, not mandel :-). Same for ubuntu_sso/qt/tests/test_reset_password.py.

* This is not valid style for our project!

+from ubuntu_sso.qt.common import (check_as_invalid,
+ check_as_valid,
+ password_assistance,
+ password_check_match,
+ BAD,
+ GOOD,
+ NORMAL,
+ PASSWORD_DIGIT,
+ PASSWORD_LENGTH,
+ PASSWORD_MATCH,
+ PASSWORD_UPPER)
+

it should be:

+from ubuntu_sso.qt.common import (check_as_invalid,
+ check_as_valid,
+ password_assistance,
+ password_check_match,
+ BAD,
+ GOOD,
+ NORMAL,
+ PASSWORD_DIGIT,
+ PASSWORD_LENGTH,
+ PASSWORD_MATCH,
+ PASSWORD_UPPER,
+)

* I advice to use twisted TestCase instead of unittest's.

* I think there is no need to cut off some sentences like:

+ password_assistance(line_edit,
+ label_assistance)

can you please check the rest?

* Can we have this moved to a setUp? seems to be used in every test:

+ line_edit = QtGui.QLineEdit()
+ label_assistance = QtGui.QLabel()

* This two should be together by alphabetical order:

+from PyQt4 import QtCore, QtGui
+from twisted.trial.unittest import TestCase

It looks really good! Big applause for all the tests!

review: Needs Fixing

[lp:~diegosarmentero/ubuntu-sso-client/reset-password-page]

775. By Diego Sarmentero on 2011-09-01

Fixed to follow some coding guidelines.

776. By Diego Sarmentero on 2011-09-01

Fixed lint issues

777. By Diego Sarmentero on 2011-09-02

Added bug number.
Moving button to the bottom right.

[Natalia Bidart (nataliabidart)]

Looks good!

review: Approve

[lp:~diegosarmentero/ubuntu-sso-client/reset-password-page]

778. By Diego Sarmentero on 2011-09-02

Changed import order for PyQt4 modules to avoid some issues.

=== modified file 'data/qt/reset_password.ui'
--- data/qt/reset_password.ui	2011-08-05 14:37:00 +0000
+++ data/qt/reset_password.ui	2011-09-02 11:41:29 +0000
@@ -6,7 +6,7 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>476</width>
+    <width>580</width>
     <height>262</height>
    </rect>
   </property>
@@ -17,25 +17,37 @@
    <item>
     <layout class="QHBoxLayout" name="horizontalLayout">
      <item>
-      <spacer name="horizontalSpacer_2">
-       <property name="orientation">
-        <enum>Qt::Horizontal</enum>
-       </property>
-       <property name="sizeHint" stdset="0">
-        <size>
-         <width>40</width>
-         <height>20</height>
-        </size>
-       </property>
-      </spacer>
-     </item>
-     <item>
       <layout class="QVBoxLayout" name="verticalLayout_2">
        <item>
-        <widget class="QLineEdit" name="reset_code_line_edit"/>
+        <widget class="QLineEdit" name="reset_code_line_edit">
+         <property name="minimumSize">
+          <size>
+           <width>300</width>
+           <height>0</height>
+          </size>
+         </property>
+         <property name="maximumSize">
+          <size>
+           <width>300</width>
+           <height>16777215</height>
+          </size>
+         </property>
+        </widget>
        </item>
        <item>
         <widget class="QLineEdit" name="password_line_edit">
+         <property name="minimumSize">
+          <size>
+           <width>300</width>
+           <height>0</height>
+          </size>
+         </property>
+         <property name="maximumSize">
+          <size>
+           <width>300</width>
+           <height>16777215</height>
+          </size>
+         </property>
          <property name="echoMode">
           <enum>QLineEdit::Password</enum>
          </property>
@@ -43,46 +55,31 @@
        </item>
        <item>
         <widget class="QLineEdit" name="confirm_password_line_edit">
+         <property name="minimumSize">
+          <size>
+           <width>300</width>
+           <height>0</height>
+          </size>
+         </property>
+         <property name="maximumSize">
+          <size>
+           <width>300</width>
+           <height>16777215</height>
+          </size>
+         </property>
          <property name="echoMode">
           <enum>QLineEdit::Password</enum>
          </property>
         </widget>
        </item>
        <item>
-        <layout class="QHBoxLayout" name="horizontalLayout_3">
-         <item>
-          <spacer name="horizontalSpacer_4">
-           <property name="orientation">
-            <enum>Qt::Horizontal</enum>
-           </property>
-           <property name="sizeHint" stdset="0">
-            <size>
-             <width>40</width>
-             <height>20</height>
-            </size>
-           </property>
-          </spacer>
-         </item>
-         <item>
-          <widget class="QPushButton" name="reset_password_button">
-           <property name="enabled">
-            <bool>false</bool>
-           </property>
-           <property name="text">
-            <string/>
-           </property>
-          </widget>
-         </item>
-        </layout>
-       </item>
-       <item>
         <spacer name="verticalSpacer">
          <property name="orientation">
           <enum>Qt::Vertical</enum>
          </property>
          <property name="sizeHint" stdset="0">
           <size>
-           <width>379</width>
+           <width>300</width>
            <height>222</height>
           </size>
          </property>
@@ -91,17 +88,96 @@
       </layout>
      </item>
      <item>
-      <spacer name="horizontalSpacer">
-       <property name="orientation">
-        <enum>Qt::Horizontal</enum>
-       </property>
-       <property name="sizeHint" stdset="0">
-        <size>
-         <width>40</width>
-         <height>20</height>
-        </size>
-       </property>
-      </spacer>
+      <layout class="QVBoxLayout" name="verticalLayout_3">
+       <item>
+        <widget class="QLabel" name="password_assistance">
+         <property name="minimumSize">
+          <size>
+           <width>250</width>
+           <height>100</height>
+          </size>
+         </property>
+         <property name="maximumSize">
+          <size>
+           <width>300</width>
+           <height>16777215</height>
+          </size>
+         </property>
+         <property name="text">
+          <string>password_assistance</string>
+         </property>
+         <property name="indent">
+          <number>20</number>
+         </property>
+        </widget>
+       </item>
+       <item>
+        <spacer name="verticalSpacer_2">
+         <property name="orientation">
+          <enum>Qt::Vertical</enum>
+         </property>
+         <property name="sizeHint" stdset="0">
+          <size>
+           <width>20</width>
+           <height>40</height>
+          </size>
+         </property>
+        </spacer>
+       </item>
+       <item>
+        <spacer name="horizontalSpacer">
+         <property name="orientation">
+          <enum>Qt::Horizontal</enum>
+         </property>
+         <property name="sizeType">
+          <enum>QSizePolicy::Fixed</enum>
+         </property>
+         <property name="sizeHint" stdset="0">
+          <size>
+           <width>250</width>
+           <height>0</height>
+          </size>
+         </property>
+        </spacer>
+       </item>
+      </layout>
+     </item>
+    </layout>
+   </item>
+   <item>
+    <layout class="QHBoxLayout" name="horizontalLayout_2">
+     <item>
+      <layout class="QHBoxLayout" name="horizontalLayout_3">
+       <property name="rightMargin">
+        <number>0</number>
+       </property>
+       <item>
+        <spacer name="horizontalSpacer_4">
+         <property name="orientation">
+          <enum>Qt::Horizontal</enum>
+         </property>
+         <property name="sizeType">
+          <enum>QSizePolicy::Expanding</enum>
+         </property>
+         <property name="sizeHint" stdset="0">
+          <size>
+           <width>40</width>
+           <height>20</height>
+          </size>
+         </property>
+        </spacer>
+       </item>
+       <item>
+        <widget class="QPushButton" name="reset_password_button">
+         <property name="enabled">
+          <bool>false</bool>
+         </property>
+         <property name="text">
+          <string/>
+         </property>
+        </widget>
+       </item>
+      </layout>
      </item>
     </layout>
    </item>

=== added file 'ubuntu_sso/qt/common.py'
--- ubuntu_sso/qt/common.py	1970-01-01 00:00:00 +0000
+++ ubuntu_sso/qt/common.py	2011-09-02 11:41:29 +0000
@@ -0,0 +1,94 @@
+# -*- coding: utf-8 -*-
+#
+# Author: Diego Sarmentero <[e-mail]>
+#
+# Copyright 2011 Canonical Ltd.
+#
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+# PURPOSE.  See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program.  If not, see <http://www.gnu.org/licenses/>.
+"""Common functionality used by the UI modules."""
+
+import re
+import gettext
+
+gettext.textdomain('ubuntu-sso-client')
+_ = gettext.gettext
+
+# all the text + styles that are used in the gui
+BAD = u'<img src=":/password_hint_warning.png" /><font> %s </font>'
+GOOD = u'<img src=":/password_hint_ok.png" /><font> %s </font>'
+NORMAL = u'<font> %s </font>'
+PASSWORD_DIGIT = _("At least one number")
+PASSWORD_LENGTH = _("At least 8 characters")
+PASSWORD_MATCH = _("Passwords don't match")
+PASSWORD_MUST_CONTAIN = _("Your password must contain")
+PASSWORD_UPPER = _("At least one uppercase letter")
+
+
+def password_assistance(line_edit, assistance, icon_type=BAD):
+    """Show help for the password field."""
+    text1 = unicode(line_edit.text())
+    label_text = ["<b>%s</b>" % PASSWORD_MUST_CONTAIN, ]
+
+    if len(text1) < 8:
+        sign = icon_type
+    else:
+        sign = GOOD
+    label_text.append(sign % PASSWORD_LENGTH)
+
+    if re.search('[A-Z]', text1) is None:
+        sign = icon_type
+    else:
+        sign = GOOD
+    label_text.append(sign % PASSWORD_UPPER)
+
+    if re.search('[\d+]', text1) is None:
+        sign = icon_type
+    else:
+        sign = GOOD
+    label_text.append(sign % PASSWORD_DIGIT)
+
+    assistance.setText("<br>".join(label_text))
+
+
+def password_check_match(line_edit, line_edit_confirm, assistance):
+    """Check if passwords match, otherwise show a message."""
+    password_assistance(line_edit, assistance)
+    label_text = unicode(assistance.text())
+    text1 = unicode(line_edit.text())
+    text2 = unicode(line_edit_confirm.text())
+    if text1 != text2:
+        label_text += "<br>" + BAD % PASSWORD_MATCH
+    assistance.setText(label_text)
+
+
+def password_default_assistance(assistance):
+    """Show default help for the password field."""
+    label_text = ["<b>%s</b>" % PASSWORD_MUST_CONTAIN, ]
+    label_text.append(NORMAL % PASSWORD_LENGTH)
+    label_text.append(NORMAL % PASSWORD_UPPER)
+    label_text.append(NORMAL % PASSWORD_DIGIT)
+    assistance.setText("<br>".join(label_text))
+
+
+def check_as_invalid(line_edit):
+    """Set QLineEdit's formError property as True, refresh the style."""
+    line_edit.setProperty("formError", True)
+    line_edit.style().unpolish(line_edit)
+    line_edit.style().polish(line_edit)
+
+
+def check_as_valid(line_edit):
+    """Set QLineEdit's formError property as False, refresh the style."""
+    line_edit.setProperty("formError", False)
+    line_edit.style().unpolish(line_edit)
+    line_edit.style().polish(line_edit)

=== modified file 'ubuntu_sso/qt/gui.py'
--- ubuntu_sso/qt/gui.py	2011-08-26 18:21:29 +0000
+++ ubuntu_sso/qt/gui.py	2011-09-02 11:41:29 +0000
@@ -16,8 +16,7 @@
 # with this program.  If not, see <http://www.gnu.org/licenses/>.
 """Qt implementation of the UI."""
 
-from PyQt4.QtCore import pyqtSignal
-from PyQt4.QtCore import Qt
+from PyQt4.QtCore import pyqtSignal, Qt, SIGNAL
 from PyQt4.QtGui import (
     QApplication,
     QWidget,
@@ -31,6 +30,7 @@
     QLabel)
 
 from ubuntu_sso.logger import setup_logging
+from ubuntu_sso.qt import common
 # pylint: disable=F0401,E0611
 from ubuntu_sso.qt.choose_sign_in_ui import Ui_ChooseSignInPage
 from ubuntu_sso.qt.current_user_sign_in_ui import Ui_CurrentUserSignInPage
@@ -289,6 +289,51 @@
     def __init__(self, ui, controller, parent=None):
         """Create a new instance."""
         SSOWizardEnhancedEditPage.__init__(self, ui, controller, parent)
+        self.ui.password_line_edit.textEdited.connect(
+            lambda: common.password_assistance(self.ui.password_line_edit,
+                                                 self.ui.password_assistance,
+                                                 common.NORMAL))
+        self.ui.confirm_password_line_edit.textEdited.connect(
+            lambda: common.password_check_match(self.ui.password_line_edit,
+                                      self.ui.confirm_password_line_edit,
+                                      self.ui.password_assistance))
+
+    def focus_changed(self, old, now):
+        """Check who has the focus to activate password popups if necessary."""
+        if now == self.ui.password_line_edit:
+            self.ui.password_assistance.setVisible(True)
+            common.password_default_assistance(self.ui.password_assistance)
+        elif now == self.ui.confirm_password_line_edit:
+            common.password_check_match(self.ui.password_line_edit,
+                                      self.ui.confirm_password_line_edit,
+                                      self.ui.password_assistance)
+
+    # Invalid name "initializePage"
+    # pylint: disable=C0103
+
+    def initializePage(self):
+        super(ResetPasswordPage, self).initializePage()
+        common.password_default_assistance(self.ui.password_assistance)
+        self.ui.password_assistance.setVisible(False)
+
+    def showEvent(self, event):
+        """Connect focusChanged signal from the application."""
+        super(ResetPasswordPage, self).showEvent(event)
+        self.connect(QApplication.instance(),
+            SIGNAL("focusChanged(QWidget*, QWidget*)"),
+            self.focus_changed)
+
+    def hideEvent(self, event):
+        """Disconnect the focusChanged signal when the page change."""
+        super(ResetPasswordPage, self).hideEvent(event)
+        try:
+            self.disconnect(QApplication.instance(),
+                SIGNAL("focusChanged(QWidget*, QWidget*)"),
+                self.focus_changed)
+        except TypeError:
+            pass
+
+    # pylint: enable=C0103
 
 
 class SetupAccountPage(SSOWizardEnhancedEditPage):

=== added file 'ubuntu_sso/qt/tests/test_common.py'
--- ubuntu_sso/qt/tests/test_common.py	1970-01-01 00:00:00 +0000
+++ ubuntu_sso/qt/tests/test_common.py	2011-09-02 11:41:29 +0000
@@ -0,0 +1,234 @@
+# -*- coding: utf-8 -*-
+# Author: Diego Sarmentero <[e-mail]>
+#
+# Copyright 2011 Canonical Ltd.
+#
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+# PURPOSE.  See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program.  If not, see <http://www.gnu.org/licenses/>.
+"""Test the common functions."""
+
+from PyQt4 import QtGui
+from twisted.trial.unittest import TestCase
+
+from ubuntu_sso.qt.common import (check_as_invalid,
+    check_as_valid,
+    password_assistance,
+    password_check_match,
+    BAD,
+    GOOD,
+    NORMAL,
+    PASSWORD_DIGIT,
+    PASSWORD_LENGTH,
+    PASSWORD_MATCH,
+    PASSWORD_UPPER)
+
+
+class PasswordTestCase(TestCase):
+    """Test passwords conditions."""
+
+    def setUp(self):
+        """Setup tests."""
+        super(PasswordTestCase, self).setUp()
+        self.line_edit = QtGui.QLineEdit()
+        self.line_edit_confirm = QtGui.QLineEdit()
+        self.label_assistance = QtGui.QLabel()
+
+    def test_short_password(self):
+        """Status with short password.
+
+        * Password assistance contains the right message.
+        """
+        self.line_edit.setText("foobar")
+        password_assistance(self.line_edit, self.label_assistance)
+        self.assertIn(
+            BAD % PASSWORD_LENGTH,
+            unicode(self.label_assistance.text()),
+        )
+
+    def test_long_password(self):
+        """Status with long password.
+
+        * Password assistance contains the right message.
+        """
+        self.line_edit.setText("foobarbaz")
+        password_assistance(self.line_edit, self.label_assistance)
+        self.assertIn(
+            GOOD % PASSWORD_LENGTH,
+            unicode(self.label_assistance.text()),
+        )
+
+    def test_no_number_password(self):
+        """Status with password without a number.
+
+        * Password assistance contains the right message.
+        """
+        self.line_edit.setText("foobarbaz")
+        password_assistance(self.line_edit, self.label_assistance)
+        self.assertIn(
+            BAD % PASSWORD_DIGIT,
+            unicode(self.label_assistance.text()),
+        )
+
+    def test_number_password(self):
+        """Status with password with a number.
+
+        * Password assistance contains the right message.
+        """
+        self.line_edit.setText("foobarba7")
+        password_assistance(self.line_edit, self.label_assistance)
+        self.assertIn(
+            GOOD % PASSWORD_DIGIT,
+            unicode(self.label_assistance.text()),
+        )
+
+    def test_no_uppercase_password(self):
+        """Status with password without uppercase letters.
+
+        * Password assistance contains the right message.
+        """
+        self.line_edit.setText("foobarbaz")
+        password_assistance(self.line_edit, self.label_assistance)
+        self.assertIn(
+            BAD % PASSWORD_UPPER,
+            unicode(self.label_assistance.text()),
+        )
+
+    def test_upper_password(self):
+        """Status with password with uppercase letters.
+
+        * Password assistance contains the right message.
+        """
+        self.line_edit.setText("Foobarba7")
+        password_assistance(self.line_edit, self.label_assistance)
+        self.assertIn(
+            GOOD % PASSWORD_UPPER,
+            unicode(self.label_assistance.text()),
+        )
+
+    def test_matching_passwords(self):
+        """Status when the passwords match.
+
+        * Password assistance doesn't contain the message.
+        """
+        self.line_edit.setText("Foobarba7")
+        self.line_edit_confirm.setText("Foobarba7")
+        password_check_match(self.line_edit,
+            self.line_edit_confirm, self.label_assistance)
+        self.assertNotIn(
+            BAD % PASSWORD_MATCH,
+            unicode(self.label_assistance.text()))
+
+    def test_not_matching_passwords(self):
+        """Status when the passwords not match.
+
+        * Password assistance contains the right message.
+        """
+        self.line_edit.setText("Foobarba7")
+        self.line_edit_confirm.setText("BazBarFo0")
+        password_check_match(self.line_edit,
+            self.line_edit_confirm, self.label_assistance)
+        self.assertIn(
+            BAD % PASSWORD_MATCH,
+            unicode(self.label_assistance.text()),
+        )
+
+    def test_password_assistance_in_focus_length_correct(self):
+        """Check the QLineEdit for password when the length is correct."""
+        self.line_edit.setText("aaaaaaaaa")
+        self.line_edit_confirm.setText("")
+        password_assistance(self.line_edit, self.label_assistance, NORMAL)
+        self.assertIn(
+            GOOD % PASSWORD_LENGTH,
+            unicode(self.label_assistance.text()),
+        )
+        self.assertIn(
+            NORMAL % PASSWORD_UPPER,
+            unicode(self.label_assistance.text()),
+        )
+        self.assertIn(
+            NORMAL % PASSWORD_DIGIT,
+            unicode(self.label_assistance.text()),
+        )
+
+    def test_password_assistance_in_focus_with_upper(self):
+        """Check the QLineEdit for password when it has an upper case char."""
+        self.line_edit.setText("AAa")
+        self.line_edit_confirm.setText("")
+        password_assistance(self.line_edit, self.label_assistance, NORMAL)
+        self.assertIn(
+            NORMAL % PASSWORD_LENGTH,
+            unicode(self.label_assistance.text()),
+        )
+        self.assertIn(
+            GOOD % PASSWORD_UPPER,
+            unicode(self.label_assistance.text()),
+        )
+        self.assertIn(
+            NORMAL % PASSWORD_DIGIT,
+            unicode(self.label_assistance.text()),
+        )
+
+    def test_password_assistance_in_focus_with_number(self):
+        """Check the QLineEdit for password when it contains numbers."""
+        self.line_edit.setText("a123")
+        self.line_edit_confirm.setText("")
+        password_assistance(self.line_edit, self.label_assistance, NORMAL)
+        self.assertIn(
+            NORMAL % PASSWORD_LENGTH,
+            unicode(self.label_assistance.text()),
+        )
+        self.assertIn(
+            NORMAL % PASSWORD_UPPER,
+            unicode(self.label_assistance.text()),
+        )
+        self.assertIn(
+            GOOD % PASSWORD_DIGIT,
+            unicode(self.label_assistance.text()),
+        )
+
+    def test_password_assistance_in_focus_all_ok(self):
+        """Check the QLineEdit for password when all the condition are ok."""
+        self.line_edit.setText("T3st3rqw")
+        self.line_edit_confirm.setText("T3st3rqw")
+        password_assistance(self.line_edit, self.label_assistance, NORMAL)
+        self.assertIn(
+            GOOD % PASSWORD_LENGTH,
+            unicode(self.label_assistance.text()),
+        )
+        self.assertIn(
+            GOOD % PASSWORD_UPPER,
+            unicode(self.label_assistance.text()),
+        )
+        self.assertIn(
+            GOOD % PASSWORD_DIGIT,
+            unicode(self.label_assistance.text()),
+        )
+        self.assertNotIn(
+            NORMAL % PASSWORD_MATCH,
+            unicode(self.label_assistance.text()),
+        )
+
+
+class LineEditStyleTestCase(TestCase):
+    """Test QLineEdit styles for errors."""
+
+    def test_check_valid(self):
+        """Check the propery value of a QLineEdit marked as valid."""
+        line_edit = QtGui.QLineEdit()
+        check_as_valid(line_edit)
+        self.assertFalse(line_edit.property("formError").toBool())
+
+    def test_check_invalid(self):
+        """Check the propery value of a QLineEdit marked as invalid."""
+        line_edit = QtGui.QLineEdit()
+        check_as_invalid(line_edit)
+        self.assertTrue(line_edit.property("formError").toBool())

=== added file 'ubuntu_sso/qt/tests/test_reset_password.py'
--- ubuntu_sso/qt/tests/test_reset_password.py	1970-01-01 00:00:00 +0000
+++ ubuntu_sso/qt/tests/test_reset_password.py	2011-09-02 11:41:29 +0000
@@ -0,0 +1,99 @@
+# -*- coding: utf-8 -*-
+# Author: Manuel de la Pena <[e-mail]>
+#
+# Copyright 2011 Canonical Ltd.
+#
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+# PURPOSE.  See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program.  If not, see <http://www.gnu.org/licenses/>.
+"""Test the Reset Password Page."""
+
+from PyQt4 import QtGui, QtCore
+from twisted.trial.unittest import TestCase
+
+from ubuntu_sso.qt import common
+from ubuntu_sso.qt.gui import ResetPasswordPage
+from ubuntu_sso.qt.reset_password_ui import Ui_ResetPasswordPage
+
+
+class FakePasswordAssistance(object):
+    """Fake password_assistance_* calls."""
+
+    _called = False
+
+    def call(self, *args, **kwargs):
+        """Check if the method was called."""
+        FakePasswordAssistance._called = True
+
+    def clenaup(self):
+        """Clean up the variable."""
+        FakePasswordAssistance._called = False
+
+
+class SetupAccountTestCase(TestCase):
+    """Test the ResetPasswordPage code."""
+
+    def setUp(self):
+        super(SetupAccountTestCase, self).setUp()
+        self.page = ResetPasswordPage(Ui_ResetPasswordPage(),
+                                                None,
+                                                None)
+        self.fake = FakePasswordAssistance()
+
+    def test_init(self):
+        """Check the initial state of ResetPassword."""
+        self.assertEqual(self.page.ui.password_line_edit.receivers(
+            QtCore.SIGNAL('textEdited(QString)')), 1)
+        self.assertEqual(self.page.ui.confirm_password_line_edit.receivers(
+            QtCore.SIGNAL('textEdited(QString)')), 1)
+
+    def test_focus_changed_password_visibility(self):
+        """Check visibility changes when focus_changed() is executed."""
+        self.page.show()
+        self.addCleanup(self.page.hide)
+        self.page.focus_changed(None, self.page.ui.password_line_edit)
+        self.assertTrue(self.page.ui.password_assistance.isVisible())
+
+    def test_show_hide_event(self):
+        """Check connections to focusChanged on show and hide event."""
+        self.page.show()
+        self.addCleanup(self.page.hide)
+        self.assertEqual(QtGui.QApplication.instance().receivers(
+            QtCore.SIGNAL("focusChanged(QWidget*, QWidget*)")), 1)
+        self.page.hide()
+        self.assertEqual(QtGui.QApplication.instance().receivers(
+            QtCore.SIGNAL("focusChanged(QWidget*, QWidget*)")), 0)
+
+    # pylint: disable=W0212
+
+    def test_focus_changed_1(self):
+        """Check functions execution when focus_changed() is executed."""
+        self.patch(common, 'password_default_assistance', self.fake.call)
+        self.addCleanup(self.fake.clenaup)
+        self.page.show()
+        self.addCleanup(self.page.hide)
+        self.assertFalse(FakePasswordAssistance._called)
+        self.page.focus_changed(None, self.page.ui.password_line_edit)
+        self.assertTrue(self.page.ui.password_assistance.isVisible())
+        self.assertTrue(FakePasswordAssistance._called)
+
+    def test_focus_changed_2(self):
+        """Check functions execution when focus_changed() is executed."""
+        self.patch(common, 'password_check_match', self.fake.call)
+        self.addCleanup(self.fake.clenaup)
+        self.page.show()
+        self.addCleanup(self.page.hide)
+        self.assertFalse(FakePasswordAssistance._called)
+        self.page.focus_changed(None, self.page.ui.confirm_password_line_edit)
+        self.assertTrue(self.page.ui.password_assistance.isVisible())
+        self.assertTrue(FakePasswordAssistance._called)
+
+    # pylint: enable=W0212