Code review comment for lp:~didrocks/unity-lens-music/add-local-radio

Revision history for this message
Paweł Stołowski (stolowski) wrote :

1) I think we may need to adjust album handling logic in "search" method, as iradio records seem to have empty album names - I think we should skip album if TYPE == RADIO; see lines 654 - 665, i.e.
 bool first_track_from_album = !(album in albums_list_nosearch);
 ...
 if (first_track_from_album)
 ...
    add_result (search.results_model, model, iter, ResultType.ALBUM, category_id);

2) Can you use TrackType as the type of Track - type_track instead of int?

review: Needs Fixing

« Back to merge proposal