Merge lp:~didrocks/unity-lens-music/add-local-radio into lp:unity-lens-music

[Didier Roche-Tolomelli]

adds local radio detection from rhythmbox. The category will
only be placed after the "for purchase one" to be unobstrusive (LP: #969697)
Also fix the non translated "Unknown" album filter appearing for non english
users (LP: #1009069)
Add some tests for the parser part (radios and songs)

This branch adds local radio detection from rhythmbox. The category will
only be placed after the "for purchase one" to be unobstrusive (LP: #969697)

Also fix the non translated "Unknown" album filter appearing for non english
users (LP: #1009069)

Add some tests for the parser part (radios and songs)

[Paweł Stołowski (stolowski)]

1) I think we may need to adjust album handling logic in "search" method, as iradio records seem to have empty album names - I think we should skip album if TYPE == RADIO; see lines 654 - 665, i.e.
 bool first_track_from_album = !(album in albums_list_nosearch);
 ...
 if (first_track_from_album)
 ...
    add_result (search.results_model, model, iter, ResultType.ALBUM, category_id);

2) Can you use TrackType as the type of Track - type_track instead of int?

review: Needs Fixing

[lp:~didrocks/unity-lens-music/add-local-radio]

86. By Didier Roche-Tolomelli on 2012-06-29

add it to an album if only it's a song, make type_track TypeTrack

[Didier Roche-Tolomelli (didrocks)]

Good spot! Changes made :)

I only add albums for now if the type is a song. Please rereview

[Paweł Stołowski (stolowski)]

Looks good now, and works fine. Well done!

review: Approve

=== modified file 'Makefile.am'
--- Makefile.am	2011-09-14 18:16:32 +0000
+++ Makefile.am	2012-06-29 15:58:20 +0000
@@ -1,4 +1,4 @@
-SUBDIRS = src data po
+SUBDIRS = src data po tests
 
 #
 # Install the music.lens and musicstore.scope files

=== modified file 'configure.ac'
--- configure.ac	2012-04-27 07:45:16 +0000
+++ configure.ac	2012-06-29 15:58:20 +0000
@@ -121,6 +121,7 @@
   src/Makefile
   src/config.vala
   po/Makefile.in
+  tests/Makefile
 ])
 AC_OUTPUT
 

=== modified file 'src/categories.vala'
--- src/categories.vala	2012-01-20 11:48:10 +0000
+++ src/categories.vala	2012-06-29 15:58:20 +0000
@@ -23,7 +23,8 @@
     SONGS,
     ALBUMS,
     PURCHASE,
-    MUSIC
+    MUSIC,
+    RADIOS
   }
 
 }

=== modified file 'src/daemon.vala'
--- src/daemon.vala	2012-04-23 12:35:38 +0000
+++ src/daemon.vala	2012-06-29 15:58:20 +0000
@@ -74,7 +74,7 @@
         filter.add_option ("1960", _("60s"));
         filter.add_option ("1970", _("70s"));
         filter.add_option ("1980", _("80s"));
-	filter.add_option ("1990", _("90s"));
+	      filter.add_option ("1990", _("90s"));
         filter.add_option ("2000", _("00s"));
         filter.add_option ("2010", _("10s"));
 
@@ -135,6 +135,10 @@
                                 new FileIcon (icon_dir.get_child ("group-songs.svg")));
       categories.append (cat);
 
+      cat = new Unity.Category (_("Radio"),
+                                new FileIcon (icon_dir.get_child ("group-songs.svg")));
+      categories.append (cat);
+
       lens.categories = categories;
     }
   }

=== modified file 'src/rhythmbox-collection.vala'
--- src/rhythmbox-collection.vala	2012-04-25 17:26:44 +0000
+++ src/rhythmbox-collection.vala	2012-06-29 15:58:20 +0000
@@ -26,6 +26,7 @@
 
     private enum Columns
     {
+        TYPE,
         URI,
         TITLE,
         ARTIST,
@@ -43,7 +44,7 @@
 
     class RhythmboxCollection : Object
     {
-        const string UNKNOWN_ALBUM = "Unknown";
+        const string UNKNOWN_ALBUM = _("Unknown");
 
         SequenceModel all_tracks;
         ModelTag<int> album_art_tag;
@@ -56,7 +57,7 @@
 
         HashTable<unowned string, Variant> variant_store;
         HashTable<int, Variant> int_variant_store;
-        Variant row_buffer[11];
+        Variant row_buffer[12];
 
         Analyzer analyzer;
         Index? index;
@@ -64,7 +65,7 @@
 
         string media_art_dir;
 
-        class XmlParser: Object
+        public class XmlParser: Object
         {
           const MarkupParser parser =
           {
@@ -91,7 +92,7 @@
             return context.parse (content, (ssize_t) len);
           }
 
-          bool processing_song;
+          bool processing_track;
           Track current_track;
           int current_data = -1;
 
@@ -99,21 +100,24 @@
             [CCode (array_length = false, array_null_terminated = true)] string[] attr_names, [CCode (array_length = false, array_null_terminated = true)] string[] attr_values)
             throws MarkupError
           {
-            if (!processing_song)
+            if (!processing_track)
             {
               switch (name)
               {
                 case "rhythmdb": is_rhythmdb_xml = true; break;
                 case "entry":
-                  bool is_song = false;
+                  string accepted_element_name = null;
                   for (int i = 0; attr_names[i] != null; i++)
                   {
-                    if (attr_names[i] == "type" && attr_values[i] == "song")
-                      is_song = true;
+                    if (attr_names[i] == "type" && (attr_values[i] == "song"
+                        || attr_values[i] == "iradio"))
+                      accepted_element_name = attr_values[i];
                   }
-                  if (!is_song) return;
-                  processing_song = true;
+                  if (accepted_element_name == null) return;
+                  processing_track = true;
                   current_track = new Track ();
+                  current_track.type_track = accepted_element_name == "song" ?
+                                             TrackType.SONG : TrackType.RADIO;
                   break;
               }
             }
@@ -156,14 +160,14 @@
                 if (current_data >= 0) current_data = -1;
                 break;
               case "hidden":
-                if (processing_song) processing_song = false;
+                if (processing_track) processing_track = false;
                 break;
               case "entry":
-                if (processing_song && current_track != null)
+                if (processing_track && current_track != null)
                 {
                   track_info_ready (current_track);
                 }
-                processing_song = false;
+                processing_track = false;
                 break;
             }
           }
@@ -172,7 +176,7 @@
                                      string text, size_t text_len)
             throws MarkupError
           {
-            if (!processing_song || current_data < 0) return;
+            if (!processing_track || current_data < 0) return;
             switch (current_data)
             {
               case Columns.URI: current_track.uri = text; break;
@@ -203,7 +207,7 @@
 
         construct
         {
-          static_assert (11 == Columns.N_COLUMNS); // sync with row_buffer size
+          static_assert (12 == Columns.N_COLUMNS); // sync with row_buffer size
           media_art_dir = Path.build_filename (
               Environment.get_user_cache_dir (), "media-art");
 
@@ -213,7 +217,7 @@
                                                            direct_equal);
           all_tracks = new SequenceModel ();
           // the columns correspond to the Columns enum
-          all_tracks.set_schema ("s", "s", "s", "s", "s", "s",
+          all_tracks.set_schema ("i", "s", "s", "s", "s", "s", "s",
                                  "s", "s", "i", "i", "i");
           assert (all_tracks.get_schema ().length == Columns.N_COLUMNS);
           album_art_tag = new ModelTag<int> (all_tracks);
@@ -383,6 +387,7 @@
 
         private void prepare_row_buffer (Track track)
         {
+          Variant type = cached_variant_for_int (track.type_track);
           Variant uri = new Variant.string (track.uri);
           Variant title = new Variant.string (track.title);
           Variant artist = cached_variant_for_string (track.artist);
@@ -395,17 +400,18 @@
           Variant year = cached_variant_for_int (track.year);
           Variant play_count = cached_variant_for_int (track.play_count);
 
-          row_buffer[0] = uri;
-          row_buffer[1] = title;
-          row_buffer[2] = artist;
-          row_buffer[3] = album;
-          row_buffer[4] = artwork;
-          row_buffer[5] = mime_type;
-          row_buffer[6] = genre;
-          row_buffer[7] = album_artist;
-          row_buffer[8] = track_number;
-          row_buffer[9] = year;
-          row_buffer[10] = play_count;
+          row_buffer[0] = type;
+          row_buffer[1] = uri;
+          row_buffer[2] = title;
+          row_buffer[3] = artist;
+          row_buffer[4] = album;
+          row_buffer[5] = artwork;
+          row_buffer[6] = mime_type;
+          row_buffer[7] = genre;
+          row_buffer[8] = album_artist;
+          row_buffer[9] = track_number;
+          row_buffer[10] = year;
+          row_buffer[11] = play_count;
         }
 
         public void parse_metadata_file (string path)
@@ -475,7 +481,7 @@
             prepare_row_buffer (track);
             var iter = all_tracks.append_row (row_buffer);
 
-            if (track.album == UNKNOWN_ALBUM) return;
+            if (track.album == "" || track.album == UNKNOWN_ALBUM) return;
             var album_key = "%s - %s".printf (track.album, track.album_artist != null ? track.album_artist : track.artist);
             var arr = album_to_tracks_map[album_key];
             if (arr == null)
@@ -520,7 +526,8 @@
         private enum ResultType
         {
           ALBUM,
-          SONG
+          SONG,
+          RADIO
         }
 
         private void add_result (Model results_model, Model model,
@@ -556,14 +563,15 @@
             album_art_tag[model, iter] = current_album_art_tag;
           }
 
-          var title_col = result_type == ResultType.SONG ?
+          var title_col = (result_type == ResultType.SONG
+                           || result_type == ResultType.RADIO) ?
             Columns.TITLE : Columns.ALBUM;
           unowned string title = model.get_string (iter, title_col);
           var uri = model.get_string (iter, Columns.URI);
           var dnd_uri = model.get_string (iter, Columns.URI);
           if (result_type == ResultType.ALBUM)
           {
-            if (title == UNKNOWN_ALBUM) return;
+            if (title == "" || title == UNKNOWN_ALBUM) return;
             unowned string artist = model.get_string (iter,
                                                       Columns.ALBUM_ARTIST);
             if (artist == "")
@@ -598,6 +606,7 @@
             int min_year;
             int max_year;
             int category_id;
+            ResultType result_type;
 
             Model model = all_tracks;
             get_decade_filter (filters, out min_year, out max_year);
@@ -639,26 +648,36 @@
                         }
                     }
 
-                    unowned string album = model.get_string (iter,
-                                                             Columns.ALBUM);
-                    // it's not first as in track #1, but first found from album
-                    bool first_track_from_album = !(album in albums_list_nosearch);
-                    albums_list_nosearch.add (album);
-                    
-                    if (first_track_from_album)
-                    {
-                        category_id = category_override >= 0 ?
-                            category_override : Category.ALBUMS;
-                        
-                        add_result (search.results_model, model, iter,
-                                    ResultType.ALBUM, category_id);
-                    }
-
-                    category_id = category_override >= 0 ?
-                        category_override : Category.SONGS;
-
+                    if (model.get_int32 (iter, Columns.TYPE) == TrackType.SONG)
+                    {
+                      category_id = Category.SONGS;
+                      result_type = ResultType.SONG;
+
+                      unowned string album = model.get_string (iter,
+                                                               Columns.ALBUM);
+                      // it's not first as in track #1, but first found from album
+                      bool first_track_from_album = !(album in albums_list_nosearch);
+                      albums_list_nosearch.add (album);
+                    
+                      if (first_track_from_album)
+                      {
+                          category_id = category_override >= 0 ?
+                              category_override : Category.ALBUMS;
+                          
+                          add_result (search.results_model, model, iter,
+                                      ResultType.ALBUM, category_id);
+                      }
+                    }
+                    else
+                    {
+                      category_id = Category.RADIOS;
+                      result_type = ResultType.RADIO;
+                    }
+                    if (category_override >= 0)
+                      category_id = category_override;
+                    
                     add_result (helper_model, model, iter,
-                                ResultType.SONG, category_id);
+                                result_type, category_id);
 
                     num_results++;
                     if (max_results >= 0 && num_results >= max_results) break;
@@ -730,27 +749,37 @@
                     }
                 }
 
-                unowned string album = model.get_string (model_iter,
-                                                         Columns.ALBUM);
-
-                // it's not first as in track #1, but first found from album
-                bool first_track_from_album = !(album in albums_list);
-                albums_list.add (album);
-
-                if (first_track_from_album)
-                {
-                    category_id = category_override >= 0 ?
-                        category_override : Category.ALBUMS;
-
-                    add_result (search.results_model, model, model_iter,
-                                ResultType.ALBUM, category_id);
-                }
-
-                category_id = category_override >= 0 ?
-                    category_override : Category.SONGS;
-
+
+                if (model.get_int32 (model_iter, Columns.TYPE) == TrackType.SONG)
+                {
+                  category_id = Category.SONGS;
+                  result_type = ResultType.SONG;
+
+                  unowned string album = model.get_string (model_iter,
+                                                           Columns.ALBUM);
+                  // it's not first as in track #1, but first found from album
+                  bool first_track_from_album = !(album in albums_list);
+                  albums_list.add (album);
+  
+                  if (first_track_from_album)
+                  {
+                      category_id = category_override >= 0 ?
+                          category_override : Category.ALBUMS;
+  
+                      add_result (search.results_model, model, model_iter,
+                                  ResultType.ALBUM, category_id);
+                  }
+                }
+                else
+                {
+                  category_id = Category.RADIOS;
+                  result_type = ResultType.RADIO;
+                }
+                if (category_override >= 0)
+                  category_id = category_override;
+                
                 add_result (helper_model, model, model_iter,
-                            ResultType.SONG, category_id);
+                            result_type, category_id);
 
                 num_results++;
                 if (max_results >= 0 && num_results >= max_results) break;

=== modified file 'src/rhythmbox-scope.vala'
--- src/rhythmbox-scope.vala	2012-04-25 17:26:44 +0000
+++ src/rhythmbox-scope.vala	2012-06-29 15:58:20 +0000
@@ -68,7 +68,7 @@
       yield;
     }
     /**
-     * Tells banshee to play the selected uri(s)
+     * Tells rhythmbox to play the selected uri(s)
      */
     public Unity.ActivationResponse activate (string uri)
     {

=== modified file 'src/track.vala'
--- src/track.vala	2012-03-27 13:31:14 +0000
+++ src/track.vala	2012-06-29 15:58:20 +0000
@@ -19,8 +19,15 @@
 
 namespace Unity.MusicLens {
   
+  public enum TrackType
+  {
+    SONG,
+    RADIO
+  }
+
   public class Track : GLib.Object
   {
+    public TrackType type_track { get; set; }
     public string title { get; set; }
     public string uri { get; set; }
     public string artist { get; set; }

=== added directory 'tests'
=== added file 'tests/Makefile.am'
--- tests/Makefile.am	1970-01-01 00:00:00 +0000
+++ tests/Makefile.am	2012-06-29 15:58:20 +0000
@@ -0,0 +1,45 @@
+check_PROGRAMS = test-rhythmbox-parser
+
+TESTS = $(check_PROGRAMS)
+
+AM_CPPFLAGS = \
+  -w \
+  $(LENS_DAEMON_CFLAGS) \
+  -DGETTEXT_PACKAGE=\"$(GETTEXT_PACKAGE)\" \
+  -I$(top_srcdir)/src \
+  $(NULL)
+
+AM_VALAFLAGS = \
+  -C			\
+  --pkg dee-1.0 \
+  --pkg gee-1.0 \
+  --pkg gio-2.0 \
+  --pkg gio-unix-2.0 \
+  --pkg glib-2.0 \
+  --vapidir $(top_srcdir)/src \
+  --pkg tdb \
+  --pkg unity \
+  $(srcdir)/assertions.vapi \
+  $(NULL)
+
+test_libs = \
+  $(LENS_DAEMON_LIBS) \
+  $(NULL)
+
+test_rhythmbox_parser_LDADD = $(test_libs)
+
+test_rhythmbox_parser_SOURCES = \
+  test-rhythmbox-parser.vala \
+  $(top_srcdir)/src/album.vala \
+  $(top_srcdir)/src/categories.vala \
+  $(top_srcdir)/src/config.vala \
+  $(top_srcdir)/src/filter-parser.vala \
+  $(top_srcdir)/src/filter-parser-decade.vala \
+  $(top_srcdir)/src/filter-parser-genre.vala \
+  $(top_srcdir)/src/genre.vala \
+  $(top_srcdir)/src/rhythmbox-collection.vala \
+  $(top_srcdir)/src/track.vala \
+  $(NULL)
+
+CLEANFILES = *.stamp
+

=== added file 'tests/assertions.vapi'
--- tests/assertions.vapi	1970-01-01 00:00:00 +0000
+++ tests/assertions.vapi	2012-06-29 15:58:20 +0000
@@ -0,0 +1,23 @@
+[CCode (cprefix = "G", lower_case_cprefix = "g_", cheader_filename = "glib.h")]
+namespace Assertions {
+  public enum OperatorType {
+    [CCode (cname = "==")]
+    EQUAL,
+    [CCode (cname = "!=")]
+    NOT_EQUAL,
+    [CCode (cname = "<")]
+    LESS_THAN,
+    [CCode (cname = ">")]
+    GREATER_THAN,
+    [CCode (cname = "<=")]
+    LESS_OR_EQUAL,
+    [CCode (cname = ">=")]
+    GREATER_OR_EQUAL
+  }
+
+  public void assert_cmpstr (string? s1, OperatorType op, string? s2);
+  public void assert_cmpint (int n1, OperatorType op, int n2);
+  public void assert_cmpuint (uint n1, OperatorType op, uint n2);
+  public void assert_cmphex (uint n1, OperatorType op, uint n2);
+  public void assert_cmpfloat (float n1, OperatorType op, float n2);
+}

=== added file 'tests/test-rhythmbox-parser.vala'
--- tests/test-rhythmbox-parser.vala	1970-01-01 00:00:00 +0000
+++ tests/test-rhythmbox-parser.vala	2012-06-29 15:58:20 +0000
@@ -0,0 +1,170 @@
+/*
+ * Copyright (C) 2012 Canonical Ltd
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authored by Didier Roche <[e-mail]>
+ *
+ */
+
+using Unity.MusicLens;
+using Assertions;
+
+public class Main
+{
+  public static int main (string[] args)
+  {
+    Test.init (ref args);
+
+    Test.add_data_func ("/Unit/ParserChecker/Radios", test_radios);
+    Test.add_data_func ("/Unit/ParserChecker/Songs", test_songs);
+    Test.add_data_func ("/Unit/ParserChecker/LazyLoad", test_lazy_load);
+    Test.add_data_func ("/Unit/ParserChecker/LazyLoad", test_invalid_songload);
+
+    Test.run ();
+
+    return 0;
+  }
+
+  private static void test_radios ()
+  {
+    var parser = new RhythmboxCollection.XmlParser ();
+
+    string collection_to_parse = """<?xml version="1.0" standalone="yes"?>
+<rhythmdb version="1.8">
+  <entry type="iradio">
+    <title>Absolute Radio 80s (Modem)</title>
+    <genre>80's</genre>
+    <artist></artist>
+    <album></album>
+    <location>http://network.absoluteradio.co.uk/core/audio/ogg/live.pls?service=a8</location>
+    <play-count>6</play-count>
+    <last-played>1339693331</last-played>
+    <bitrate>32</bitrate>
+    <date>0</date>
+    <media-type>application/octet-stream</media-type>
+  </entry>
+</rhythmdb>""";
+
+    parser.track_info_ready.connect ((track) =>
+    {
+      assert_cmpstr (track.title, OperatorType.EQUAL, "Absolute Radio 80s (Modem)");
+      assert_cmpstr (track.genre, OperatorType.EQUAL, "other");
+      assert_cmpstr (track.artist, OperatorType.EQUAL, "");
+      assert_cmpstr (track.album, OperatorType.EQUAL, "");
+      assert_cmpstr (track.uri, OperatorType.EQUAL, "http://network.absoluteradio.co.uk/core/audio/ogg/live.pls?service=a8");
+      assert_cmpint (track.year, OperatorType.EQUAL, 0);
+      assert (track.type_track == TrackType.RADIO);
+    });
+    parser.parse(collection_to_parse, collection_to_parse.length);
+  }
+
+
+  private static void test_songs ()
+  {
+    var parser = new RhythmboxCollection.XmlParser ();
+
+    string collection_to_parse = """<?xml version="1.0" standalone="yes"?>
+<rhythmdb version="1.8">
+  <entry type="song">
+    <title>LA PASSION</title>
+    <genre>Dance</genre>
+    <artist>GIGI D'AGOSTINO</artist>
+    <album>Loulou 007</album>
+    <duration>228</duration>
+    <file-size>3661842</file-size>
+    <location>file:///home/moi/Gigi%20d'agostino%20Passion.mp3</location>
+    <mtime>1338273042</mtime>
+    <first-seen>1338536342</first-seen>
+    <last-seen>1340378542</last-seen>
+    <bitrate>128</bitrate>
+    <date>730142</date>
+    <media-type>audio/mpeg</media-type>
+    <comment>http://www.danceparadise.ca.tc</comment>
+  </entry>
+</rhythmdb>""";
+
+    parser.track_info_ready.connect ((track) =>
+    {
+      assert_cmpstr (track.title, OperatorType.EQUAL, "LA PASSION");
+      assert_cmpstr (track.genre, OperatorType.EQUAL, "techno");
+      assert_cmpstr (track.artist, OperatorType.EQUAL, "GIGI D'AGOSTINO");
+      assert_cmpstr (track.album, OperatorType.EQUAL, "Loulou 007");
+      assert_cmpstr (track.uri, OperatorType.EQUAL, "file:///home/moi/Gigi%20d'agostino%20Passion.mp3");
+      assert_cmpint (track.year, OperatorType.EQUAL, 2000);
+      assert_cmpstr (track.mime_type, OperatorType.EQUAL, "audio/mpeg");
+      assert (track.type_track == TrackType.SONG);
+    });
+    parser.parse(collection_to_parse, collection_to_parse.length);
+  }
+
+
+  private static void test_lazy_load ()
+  {
+    var parser = new RhythmboxCollection.XmlParser ();
+
+    string collection_to_parse_chunk = """<?xml version="1.0" standalone="yes"?>
+<rhythmdb version="1.8">
+  <entry type="song">
+    <title>LA PASSION</title>
+    <genre>Dance</genre>
+    <artist>GIGI D'AGOSTINO</artist>
+""";
+    parser.parse(collection_to_parse_chunk, collection_to_parse_chunk.length);
+
+    collection_to_parse_chunk = """
+    <album>Loulou 007</album>
+    <duration>228</duration>
+    <file-size>3661842</file-size>
+    <location>file:///home/moi/Gigi%20d'agostino%20Passion.mp3</location>
+    <mtime>1338273042</mtime>
+    <first-seen>1338536342</first-seen>
+    <last-seen>1340378542</last-seen>
+    <bitrate>128</bitrate>
+    <date>730142</date>
+    <media-type>audio/mpeg</media-type>
+    <comment>http://www.danceparadise.ca.tc</comment>
+  </entry>""";
+    parser.track_info_ready.connect ((track) =>
+    {
+      assert_cmpstr (track.title, OperatorType.EQUAL, "LA PASSION");
+      assert_cmpstr (track.album, OperatorType.EQUAL, "Loulou 007");
+      assert (track.type_track == TrackType.SONG);
+    });  
+    parser.parse(collection_to_parse_chunk, collection_to_parse_chunk.length);
+  }
+
+
+  private static void test_invalid_songload ()
+  {
+    var parser = new RhythmboxCollection.XmlParser ();
+
+    string collection_to_parse_chunk = """<?xml version="1.0" standalone="yes"?>
+<rhythmdb version="1.8">
+  <entry type="song">
+    <title>LA PASSION</title>
+    <genre>Dance</genre>
+  <entry type="song">
+    <title>le poisson</title>
+    <genre>Dance</genre>
+  </entry>""";
+
+    parser.track_info_ready.connect ((track) =>
+    {
+      assert_cmpstr (track.title, OperatorType.EQUAL, "le poisson");
+      assert (track.type_track == TrackType.SONG);
+    });     
+    parser.parse(collection_to_parse_chunk, collection_to_parse_chunk.length);
+  }
+
+}
\ No newline at end of file