Code review comment for lp:~didrocks/ubiquity/intall-metrics

Revision history for this message
Iain Lane (laney) wrote :

Thanks, this is great. I have some comments inline, nothing too major. :)

After fixing those, I don't think that you'd need to re-test the full matrix: if it works for one it should work equally for all the others.

Just for the record, as jibel said on IRC, it would be good to test if this works with preseeding. Even if not, that could be fixed later on though.

review: Needs Fixing

« Back to merge proposal