Code review comment for lp:~didrocks/libunity/add-remote-disabling-support

Revision history for this message
Michal Hruby (mhr3) wrote :

146 + public class LensPreferencesManager : GLib.Object

Drop the Lens from the name pls.

159 + private LensPreferencesManager ()
160 + {
161 + gp_settings = new Settings ("com.canonical.Unity.Lenses");
162 + gp_settings.bind (REMOTE_CONTENT_KEY, this, "remote_content_search", SettingsBindFlags.GET);
163 + }

The binding should be in construct {} block. Constructor should be just:
private PreferencesManager ()
{
  Object ();
}

269 + Process.spawn_command_line_sync ("glib-compile-schemas " + gsettings_schema_dir);

Is this really necessary? Don't remember seeing it in other projects?

Otherwise looking good, thanks ;)

review: Needs Fixing

« Back to merge proposal