Merge lp:~didrocks/libunity/add-remote-disabling-support into lp:libunity
Proposed by
Didier Roche-Tolomelli
Status: | Merged |
---|---|
Approved by: | Didier Roche-Tolomelli |
Approved revision: | 189 |
Merged at revision: | 181 |
Proposed branch: | lp:~didrocks/libunity/add-remote-disabling-support |
Merge into: | lp:libunity |
Diff against target: |
305 lines (+184/-1) 11 files modified
Makefile.am (+2/-1) configure.ac (+13/-0) data/Makefile.am (+16/-0) data/com.canonical.Unity.Lenses.gschema.xml.in.in (+10/-0) po/POTFILES.in (+4/-0) po/POTFILES.skip (+1/-0) src/Makefile.am (+1/-0) src/unity-lens-preferences-manager.vala (+68/-0) test/vala/Makefile.am (+2/-0) test/vala/test-preferences.vala (+54/-0) test/vala/test-vala.vala (+13/-0) |
To merge this branch: | bzr merge lp:~didrocks/libunity/add-remote-disabling-support |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michal Hruby (community) | Approve | ||
Review via email: mp+126284@code.launchpad.net |
Commit message
Add remote search disabling option support to libunity for lenses to consume it.
Description of the change
Add remote search disabling option support to libunity for lenses to consume
it.
Tests included
To post a comment you must log in.
146 + public class LensPreferences Manager : GLib.Object
Drop the Lens from the name pls.
159 + private LensPreferences Manager () .Unity. Lenses" ); CONTENT_ KEY, this, "remote_ content_ search" , SettingsBindFla gs.GET) ;
160 + {
161 + gp_settings = new Settings ("com.canonical
162 + gp_settings.bind (REMOTE_
163 + }
The binding should be in construct {} block. Constructor should be just:
private PreferencesManager ()
{
Object ();
}
269 + Process. spawn_command_ line_sync ("glib- compile- schemas " + gsettings_ schema_ dir);
Is this really necessary? Don't remember seeing it in other projects?
Otherwise looking good, thanks ;)