Ubuntu Help App

Merge lp:~dholbach/help-app/question-navigation.fixes into lp:~ubuntu-touch-coreapps-drivers/help-app/trunk

  1. question-navigation.fixes
  2. Merge into trunk
Proposed by Daniel Holbach
Status: Merged
Merged at revision: 89
Proposed branch: lp:~dholbach/help-app/question-navigation.fixes
Merge into: lp:~ubuntu-touch-coreapps-drivers/help-app/trunk
Diff against target: 0 lines
To merge this branch: bzr merge lp:~dholbach/help-app/question-navigation.fixes
Reviewer Review Type Date Requested Status
David Planella Pending
Review via email: mp+252478@code.launchpad.net

This proposal supersedes a proposal from 2015-03-10.

To post a comment you must log in.
Revision history for this message
David Planella (dpm) wrote : Posted in a previous version of this proposal

Looks good to me. One comment, though:

- The other type of content that we might not want translated will be probably raw HTML (e.g. <div class="eight-col">). This code without modifications would not work for that case. However, as much as I'd like to use additional HTML to make the output more user-friendly, I'm also tempted to keep things simple and not use raw HTML.
- Same as above with python-markdown's attribute lists, which can also get trickier, as they can be added inline to e.g. a header:

## Myheader {: #myid .myclass}

review: Approve
Revision history for this message
Daniel Holbach (dholbach) wrote : Posted in a previous version of this proposal

Did this land now?

Preview Diff

Empty

Subscribers

People subscribed via source and target branches