Code review comment for lp:~dholbach/help-app/question-navigation.fixes

Revision history for this message
David Planella (dpm) wrote :

Looks good to me. One comment, though:

- The other type of content that we might not want translated will be probably raw HTML (e.g. <div class="eight-col">). This code without modifications would not work for that case. However, as much as I'd like to use additional HTML to make the output more user-friendly, I'm also tempted to keep things simple and not use raw HTML.
- Same as above with python-markdown's attribute lists, which can also get trickier, as they can be added inline to e.g. a header:

## Myheader {: #myid .myclass}

review: Approve

« Back to merge proposal