Merge lp:~dholbach/click-reviewers-tools/1390163 into lp:click-reviewers-tools

[Daniel Holbach]

[Daniel Holbach (dholbach)]

<jdstrand> dholbach: it looks fine

review: Approve

=== modified file 'clickreviews/cr_security.py'
--- clickreviews/cr_security.py	2014-12-04 15:05:27 +0000
+++ clickreviews/cr_security.py	2014-12-16 16:14:15 +0000
@@ -294,10 +294,12 @@
             t = 'info'
             n = 'policy_version_is_highest (%s, %s)' % (str(highest), f)
             s = "OK"
+            l = None
             if float(m['policy_version']) != highest:
                 t = 'info'
+                l = 'http://askubuntu.com/q/562116/94326'
                 s = '%s != %s' % (str(m['policy_version']), str(highest))
-            self._add_result(t, n, s)
+            self._add_result(t, n, s, l)
 
             t = 'info'
             n = 'policy_version_matches_framework (%s)' % (f)
@@ -555,6 +557,7 @@
                     t = 'info'
                     n = 'policy_groups_safe_%s (%s)' % (app, i)
                     s = 'OK'
+                    l = None
                     manual_review = False
 
                     aa_type = self._get_policy_group_type(vendor, version, i)
@@ -566,12 +569,14 @@
                         t = 'error'
                         s = "(MANUAL REVIEW) %s policy group " % aa_type + \
                             "'%s': vetted applications only" % (i)
+                        if i == "debug":
+                            l = 'http://askubuntu.com/a/562123/94326'
                         manual_review = True
                     elif aa_type != "common":
                         t = 'error'
                         s = "policy group '%s' has" % i + \
                             "unknown type '%s'" % (aa_type)
-                    self._add_result(t, n, s, manual_review=manual_review)
+                    self._add_result(t, n, s, l, manual_review=manual_review)
 
     def check_ignored(self):
         '''Check ignored fields'''
 
=== modified file 'debian/changelog'
--- debian/changelog	2014-12-10 18:16:46 +0000
+++ debian/changelog	2014-12-16 16:14:15 +0000
@@ -29,7 +29,11 @@
   * allow filenames to end with .snap
   * allow flat namesapces in check_maintainer_email()
 
- -- Jamie Strandboge <[e-mail]>  Wed, 03 Dec 2014 09:43:57 -0600
+  [ Daniel Holbach ]
+  * Add askubuntu explanation for policy_version_is_highest.
+  * Add askubuntu explanation for debug builds. (LP: #1390163)
+
+ -- Daniel Holbach <[e-mail]>  Tue, 16 Dec 2014 17:07:36 +0100
 
 click-reviewers-tools (0.18) utopic; urgency=medium