Canonical Click Reviewers tools (obsolete)

Merge lp:~dholbach/click-reviewers-tools/1390163 into lp:click-reviewers-tools

  1. 1390163
  2. Merge into trunk
Proposed by Daniel Holbach
Status: Merged
Merged at revision: 347
Proposed branch: lp:~dholbach/click-reviewers-tools/1390163
Merge into: lp:click-reviewers-tools
Diff against target: 57 lines (+12/-3)
2 files modified
clickreviews/cr_security.py (+7/-2)
debian/changelog (+5/-1)
To merge this branch: bzr merge lp:~dholbach/click-reviewers-tools/1390163
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Approve
Review via email: mp+244875@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

<jdstrand> dholbach: it looks fine

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'clickreviews/cr_security.py'
2--- clickreviews/cr_security.py 2014-12-04 15:05:27 +0000
3+++ clickreviews/cr_security.py 2014-12-16 16:14:15 +0000
4@@ -294,10 +294,12 @@
5 t = 'info'
6 n = 'policy_version_is_highest (%s, %s)' % (str(highest), f)
7 s = "OK"
8+ l = None
9 if float(m['policy_version']) != highest:
10 t = 'info'
11+ l = 'http://askubuntu.com/q/562116/94326'
12 s = '%s != %s' % (str(m['policy_version']), str(highest))
13- self._add_result(t, n, s)
14+ self._add_result(t, n, s, l)
15
16 t = 'info'
17 n = 'policy_version_matches_framework (%s)' % (f)
18@@ -555,6 +557,7 @@
19 t = 'info'
20 n = 'policy_groups_safe_%s (%s)' % (app, i)
21 s = 'OK'
22+ l = None
23 manual_review = False
24
25 aa_type = self._get_policy_group_type(vendor, version, i)
26@@ -566,12 +569,14 @@
27 t = 'error'
28 s = "(MANUAL REVIEW) %s policy group " % aa_type + \
29 "'%s': vetted applications only" % (i)
30+ if i == "debug":
31+ l = 'http://askubuntu.com/a/562123/94326'
32 manual_review = True
33 elif aa_type != "common":
34 t = 'error'
35 s = "policy group '%s' has" % i + \
36 "unknown type '%s'" % (aa_type)
37- self._add_result(t, n, s, manual_review=manual_review)
38+ self._add_result(t, n, s, l, manual_review=manual_review)
39
40 def check_ignored(self):
41 '''Check ignored fields'''
42
43=== modified file 'debian/changelog'
44--- debian/changelog 2014-12-10 18:16:46 +0000
45+++ debian/changelog 2014-12-16 16:14:15 +0000
46@@ -29,7 +29,11 @@
47 * allow filenames to end with .snap
48 * allow flat namesapces in check_maintainer_email()
49
50- -- Jamie Strandboge <jamie@ubuntu.com> Wed, 03 Dec 2014 09:43:57 -0600
51+ [ Daniel Holbach ]
52+ * Add askubuntu explanation for policy_version_is_highest.
53+ * Add askubuntu explanation for debug builds. (LP: #1390163)
54+
55+ -- Daniel Holbach <daniel.holbach@ubuntu.com> Tue, 16 Dec 2014 17:07:36 +0100
56
57 click-reviewers-tools (0.18) utopic; urgency=medium
58

Subscribers

People subscribed via source and target branches