Code review comment for lp:~dhillon-v10/launchpad/fix-bug-91905

Revision history for this message
Vikram Dhillon (dhillon-v10) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/22/2010 09:03 AM, Tom Berger wrote:
> Review: Disapprove
> Vikram, I am rejecting this MP for now, not because there's anything wrong in the code, but because the solution is probably not the appropriate one. Instead, let's discuss in the bug and/or on the mailing list how to improve the usability of 'user' fields in Launchpad and work towards implementing that. Thanks again for picking up this issue and starting the work on a fix. I'm sure the eventual solution will make Launchpad much easier to use.

Thanks for giving me a change to help :) its as you said, you should
talk about this before me going and implementing something. I thought it
was a little string change that I can get done with quickly but I forgot
launchpad is used by millions of people, and any change I make is
affecting everyone :)

- --
Regards,
Vikram Dhillon

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkuC9tUACgkQcoBavQdRHcyl0wCfRZe+VTRJdlLNya5eHjYvcN1Y
6noAniweRYacNFIYGBgybsJ6JlzExw5R
=8WgG
-----END PGP SIGNATURE-----

« Back to merge proposal