Merge lp:~dhillon-v10/launchpad/fix-bug-91905 into lp:launchpad/db-devel

[Vikram Dhillon]

[Vikram Dhillon (dhillon-v10)]

A very minor fix, changing a string in lib/lp/bugs/interfaces/bugsupervisor.py

[Eleanor Berger (intellectronica)]

Vikram, thanks for contributing this improvement. Have you had a change to discuss the solution with another developer, and decide this is the best way to go? I can see how it improves the experience for new users, but it does this in a very local fashion, fixing only one field, rather then improve the experience for all person fields, which are very common in Launchpad.

Also, the diff doesn't show any test change. It's not strictly necessary to extend the test suite for such a minor UI-related tweak, but did you check that no existing tests require changing as a result?

[Eleanor Berger (intellectronica)]

Vikram, I am rejecting this MP for now, not because there's anything wrong in the code, but because the solution is probably not the appropriate one. Instead, let's discuss in the bug and/or on the mailing list how to improve the usability of 'user' fields in Launchpad and work towards implementing that. Thanks again for picking up this issue and starting the work on a fix. I'm sure the eventual solution will make Launchpad much easier to use.

review: Disapprove

[Vikram Dhillon (dhillon-v10)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/22/2010 09:03 AM, Tom Berger wrote:
> Review: Disapprove
> Vikram, I am rejecting this MP for now, not because there's anything wrong in the code, but because the solution is probably not the appropriate one. Instead, let's discuss in the bug and/or on the mailing list how to improve the usability of 'user' fields in Launchpad and work towards implementing that. Thanks again for picking up this issue and starting the work on a fix. I'm sure the eventual solution will make Launchpad much easier to use.

Thanks for giving me a change to help :) its as you said, you should
talk about this before me going and implementing something. I thought it
was a little string change that I can get done with quickly but I forgot
launchpad is used by millions of people, and any change I make is
affecting everyone :)

- --
Regards,
Vikram Dhillon

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkuC9tUACgkQcoBavQdRHcyl0wCfRZe+VTRJdlLNya5eHjYvcN1Y
6noAniweRYacNFIYGBgybsJ6JlzExw5R
=8WgG
-----END PGP SIGNATURE-----

Unmerged revisions

10304. By Vikram Dhillon on 2010-02-14

Making the bug contact statement clear

=== modified file 'lib/lp/bugs/interfaces/bugsupervisor.py'
--- lib/lp/bugs/interfaces/bugsupervisor.py	2009-12-05 18:50:48 +0000
+++ lib/lp/bugs/interfaces/bugsupervisor.py	2010-02-14 04:52:18 +0000
@@ -23,8 +23,10 @@
     bug_supervisor = PublicPersonChoice(
         title=_("Bug Supervisor"),
         description=_(
-            "The person or team responsible for bug management."),
+            "The person or team responsible for bug management 
+            (enter their email address or launchpad login-id)."),
         required=False, vocabulary='ValidPersonOrTeam')
+# Making the description less ambigious above
 
     def setBugSupervisor(self, bug_supervisor, user):
         """Set the bug contact and create a bug subscription."""