Code review comment for lp:~dhillon-v10/launchpad/fix-bug-91905

Revision history for this message
Eleanor Berger (intellectronica) wrote :

Vikram, thanks for contributing this improvement. Have you had a change to discuss the solution with another developer, and decide this is the best way to go? I can see how it improves the experience for new users, but it does this in a very local fashion, fixing only one field, rather then improve the experience for all person fields, which are very common in Launchpad.

Also, the diff doesn't show any test change. It's not strictly necessary to extend the test suite for such a minor UI-related tweak, but did you check that no existing tests require changing as a result?

« Back to merge proposal