Code review comment for lp:~deryck/launchpad/less-restrictive-assign-someone-else-603281

Revision history for this message
Robert Collins (lifeless) wrote :

BTW:

               user.inTeam(self.pillar.bug_supervisor) or
               user.inTeam(self.pillar.owner) or
               user.inTeam(self.pillar.driver) or
               (self.distroseries is not None and
                user.inTeam(self.distroseries.driver)) or
               (self.productseries is not None and
                user.inTeam(self.productseries.driver)) or
               user.inTeam(celebrities.admin)
               or user == celebrities.bug_importer)

Is slow code - it will do, on a bad day, 5 or 6 queries all on its
own. Thats not a huge issue, unless it ends up in a loop - but as it
happens we have loops that do this - the bug importer loops.

Please consider making a tech debt bug or something.

« Back to merge proposal