Merge lp:~deryck/launchpad/less-restrictive-assign-someone-else-603281 into lp:launchpad

[Deryck Hodge]

Allow anyone to set bugtask assignee if there is not a defined bug supervisor.

This branch fixes bug 603281, which notes that when we changed
permissions for who can assign a bug to someone else that we made that a
bit too strict for projects without a bug supervisor.

This branch fixes that by lifting the restrictions if a bug supervisor
is not set for a project/distro. This means that projects that haven't
yet set a bug supervisor will be able to assign bugs without having to
set a bug supervisor. The functionality returns to what it once was.

But for projects that have a bug supervisor, the new requirements will
remain, i.e. that you cannot assign a bug to someone else.

This includes a test update and then the couple line change to
BugTask.userCanSetAnyAssignee to get this working. Since the web UI uses
this method, nothing had to be changed with the JS widget.

[Brad Crittenden (bac)]

Hi Deryck,

Thanks for making this fix rolling back some restrictions.

In userCanSetAnyAssignee,I think the test would read better if you factored out the test for 'user is None' and return False immediately. So I'm suggesting (I hope formatting is preserved)

    def userCanSetAnyAssignee(self, user):
        """See `IBugTask`."""
        celebrities = getUtility(ILaunchpadCelebrities)
        if user is None:
            return False
        elif self.pillar.bug_supervisor is None:
            return True
        else:
            return (
                user.inTeam(self.pillar.bug_supervisor) or
                user.inTeam(self.pillar.owner) or
                user.inTeam(self.pillar.driver) or
                (self.distroseries is not None and
                 user.inTeam(self.distroseries.driver)) or
                (self.productseries is not None and
                 user.inTeam(self.productseries.driver)) or
                user.inTeam(celebrities.admin)
                or user == celebrities.bug_importer)

The technique you provided in setBugSupervisor of having the base class provide two alternatives for the subclasses to choose is very interesting. I've never seen that before.

review: Approve

[Deryck Hodge (deryck)]

Hi, bac.

Thanks for the review! I like your suggestion and will do that.

Cheers,
deryck

[Robert Collins (lifeless)]

BTW:

               user.inTeam(self.pillar.bug_supervisor) or
               user.inTeam(self.pillar.owner) or
               user.inTeam(self.pillar.driver) or
               (self.distroseries is not None and
                user.inTeam(self.distroseries.driver)) or
               (self.productseries is not None and
                user.inTeam(self.productseries.driver)) or
               user.inTeam(celebrities.admin)
               or user == celebrities.bug_importer)

Is slow code - it will do, on a bad day, 5 or 6 queries all on its
own. Thats not a huge issue, unless it ends up in a loop - but as it
happens we have loops that do this - the bug importer loops.

Please consider making a tech debt bug or something.

=== modified file 'lib/lp/bugs/browser/tests/test_bugtask.py'
--- lib/lp/bugs/browser/tests/test_bugtask.py	2010-08-20 20:31:18 +0000
+++ lib/lp/bugs/browser/tests/test_bugtask.py	2010-08-31 18:56:47 +0000
@@ -312,11 +312,16 @@
 
     def setUp(self):
         super(TestBugTaskEditViewAssigneeField, self).setUp()
-        self.bugtask = self.factory.makeBug().default_bugtask
+        self.owner = self.factory.makePerson()
+        self.product = self.factory.makeProduct(owner=self.owner)
+        self.bugtask = self.factory.makeBug(
+            product=self.product).default_bugtask
 
-    def test_assignee_field_vocabulary_regular_user(self):
+    def test_assignee_vocabulary_regular_user_with_bug_supervisor(self):
         # For regular users, the assignee vocabulary is
-        # AllUserTeamsParticipation.
+        # AllUserTeamsParticipation if there is a bug supervisor defined.
+        login_person(self.owner)
+        self.product.setBugSupervisor(self.owner, self.owner)
         login('[e-mail]')
         view = BugTaskEditView(self.bugtask, LaunchpadTestRequest())
         view.initialize()
@@ -324,6 +329,18 @@
             'AllUserTeamsParticipation',
             view.form_fields['assignee'].field.vocabularyName)
 
+    def test_assignee_vocabulary_regular_user_without_bug_supervisor(self):
+        # For regular users, the assignee vocabulary is
+        # ValidAssignee is there is not a bug supervisor defined.
+        login_person(self.owner)
+        self.product.setBugSupervisor(None, self.owner)
+        login('[e-mail]')
+        view = BugTaskEditView(self.bugtask, LaunchpadTestRequest())
+        view.initialize()
+        self.assertEqual(
+            'ValidAssignee',
+            view.form_fields['assignee'].field.vocabularyName)
+
     def test_assignee_field_vocabulary_privileged_user(self):
         # Privileged users, like the bug task target owner, can
         # assign anybody.

=== modified file 'lib/lp/bugs/doc/bugtask.txt'
--- lib/lp/bugs/doc/bugtask.txt	2010-07-25 14:39:52 +0000
+++ lib/lp/bugs/doc/bugtask.txt	2010-08-31 18:56:47 +0000
@@ -564,80 +564,6 @@
     ...     devel_focus_alsa_utils_task.date_assigned)
     True
 
-Ordinary users can assign themselves and teams they are a member of.
-
-    >>> login('[e-mail]')
-    >>> devel_focus_alsa_utils_task.transitionToAssignee(None)
-    Traceback (most recent call last):
-    ...
-    UserCannotEditBugTaskAssignee: Regular users can assign and unassign
-    only themselves and their teams. Only project owners, bug supervisors,
-    drivers and release managers can assign others.
-
-    >>> devel_focus_alsa_utils_task.transitionToAssignee(sample_person)
-    >>> print generic_alsa_utils_task.assignee.displayname
-    Sample Person
-    >>> login('[e-mail]')
-    >>> devel_focus_alsa_utils_task.transitionToAssignee(no_priv)
-    >>> print devel_focus_alsa_utils_task.assignee.displayname
-    No Privileges Person
-    >>> devel_focus_alsa_utils_task.transitionToAssignee(None)
-    >>> print generic_alsa_utils_task.assignee
-    None
-
-    >>> warty_security_team = getUtility(IPersonSet).getByName('name20')
-    >>> no_priv.inTeam(warty_security_team)
-    False
-    >>> devel_focus_alsa_utils_task.transitionToAssignee(warty_security_team)
-    Traceback (most recent call last):
-    ...
-    UserCannotEditBugTaskAssignee: Regular users can assign and unassign
-    only themselves and their teams. Only project owners, bug supervisors,
-    drivers and release managers can assign others.
-
-    >>> login('[e-mail]')
-    >>> sample_person.inTeam(warty_security_team)
-    True
-    >>> devel_focus_alsa_utils_task.transitionToAssignee(warty_security_team)
-    >>> print devel_focus_alsa_utils_task.assignee.displayname
-    Warty Security Team
-
-These persons can assign anybody: Project owners...
-
-    >>> from lp.testing import login_person
-    >>> login_person(devel_focus_alsa_utils_task.pillar.owner)
-    >>> devel_focus_alsa_utils_task.transitionToAssignee(no_priv)
-    >>> print generic_alsa_utils_task.assignee.displayname
-    No Privileges Person
-
-...drivers...
-
-    >>> devel_focus_alsa_utils_task.pillar.driver = sample_person
-    >>> login('[e-mail]')
-    >>> devel_focus_alsa_utils_task.transitionToAssignee(None)
-    >>> print devel_focus_alsa_utils_task.assignee
-    None
-    >>> devel_focus_alsa_utils_task.transitionToAssignee(mark)
-    >>> print devel_focus_alsa_utils_task.assignee.displayname
-    Mark Shuttleworth
-
-...bug supervisors...
-
-    >>> login_person(devel_focus_alsa_utils_task.pillar.owner)
-    >>> devel_focus_alsa_utils_task.pillar.setBugSupervisor(
-    ...     sample_person, devel_focus_alsa_utils_task.pillar.owner)
-    >>> devel_focus_alsa_utils_task.pillar.driver = None
-    >>> login('[e-mail]')
-    >>> devel_focus_alsa_utils_task.transitionToAssignee(no_priv)
-    >>> print devel_focus_alsa_utils_task.assignee.displayname
-    No Privileges Person
-
- ...and Launchpad admins.
-
-    >>> login('[e-mail]')
-    >>> devel_focus_alsa_utils_task.transitionToAssignee(sample_person)
-
-
 3. Importance
 
     >>> print generic_netapplet_task.importance.title

=== modified file 'lib/lp/bugs/interfaces/bugtask.py'
--- lib/lp/bugs/interfaces/bugtask.py	2010-08-26 18:57:35 +0000
+++ lib/lp/bugs/interfaces/bugtask.py	2010-08-31 18:56:47 +0000
@@ -737,8 +737,9 @@
     def userCanSetAnyAssignee(user):
         """Check if the current user can set anybody sa a bugtask assignee.
 
-        Return True for project owner, project drivers, series drivers,
-        bug supervisors and Launchpad admins; return False for other users.
+        Owners, drivers, bug supervisors and Launchpad admins can always
+        assign to someone else.  Other users can assign to someone else if a
+        bug supervisor is not defined.
         """
 
     def userCanUnassign(user):
@@ -1401,7 +1402,7 @@
     def searchBugIds(params):
         """Search bug ids.
 
-        This is a variation on IBugTaskSet.search that returns only the bug ids.
+        This is a variation on IBugTaskSet.search that returns only bug ids.
 
         :param params: the BugTaskSearchParams to search on.
         """

=== modified file 'lib/lp/bugs/model/bugtask.py'
--- lib/lp/bugs/model/bugtask.py	2010-08-24 15:29:01 +0000
+++ lib/lp/bugs/model/bugtask.py	2010-08-31 18:56:47 +0000
@@ -21,7 +21,7 @@
 
 
 import datetime
-from operator import attrgetter, itemgetter
+from operator import attrgetter
 
 from lazr.enum import DBItem
 import pytz
@@ -42,7 +42,6 @@
     Or,
     SQL,
     )
-from storm.sqlobject import SQLObjectResultSet
 from storm.store import EmptyResultSet
 from storm.zope.interfaces import (
     IResultSet,
@@ -74,7 +73,9 @@
     SQLBase,
     sqlvalues,
     )
-from canonical.launchpad.components.decoratedresultset import DecoratedResultSet
+from canonical.launchpad.components.decoratedresultset import (
+    DecoratedResultSet,
+    )
 from canonical.launchpad.helpers import shortlist
 from canonical.launchpad.interfaces.launchpad import ILaunchpadCelebrities
 from canonical.launchpad.interfaces.lpstorm import IStore
@@ -90,7 +91,6 @@
     ILaunchBag,
     IStoreSelector,
     MAIN_STORE,
-    SLAVE_FLAVOR,
     )
 from lp.app.errors import NotFoundError
 from lp.bugs.interfaces.bug import IBugSet
@@ -157,15 +157,16 @@
 from lp.soyuz.model.publishing import SourcePackagePublishingHistory
 from lp.soyuz.model.sourcepackagerelease import SourcePackageRelease
 
-
-debbugsseveritymap = {None:        BugTaskImportance.UNDECIDED,
-                      'wishlist':  BugTaskImportance.WISHLIST,
-                      'minor':     BugTaskImportance.LOW,
-                      'normal':    BugTaskImportance.MEDIUM,
-                      'important': BugTaskImportance.HIGH,
-                      'serious':   BugTaskImportance.HIGH,
-                      'grave':     BugTaskImportance.HIGH,
-                      'critical':  BugTaskImportance.CRITICAL}
+debbugsseveritymap = {
+    None: BugTaskImportance.UNDECIDED,
+    'wishlist': BugTaskImportance.WISHLIST,
+    'minor': BugTaskImportance.LOW,
+    'normal': BugTaskImportance.MEDIUM,
+    'important': BugTaskImportance.HIGH,
+    'serious': BugTaskImportance.HIGH,
+    'grave': BugTaskImportance.HIGH,
+    'critical': BugTaskImportance.CRITICAL,
+    }
 
 
 def bugtask_sort_key(bugtask):
@@ -209,6 +210,7 @@
         bugtask.bug.id, distribution_name, product_name, productseries_name,
         distroseries_name, sourcepackage_name)
 
+
 def get_related_bugtasks_search_params(user, context, **kwargs):
     """Returns a list of `BugTaskSearchParams` which can be used to
     search for all tasks related to a user given by `context`.
@@ -255,7 +257,9 @@
 
 class BugTaskDelta:
     """See `IBugTaskDelta`."""
+
     implements(IBugTaskDelta)
+
     def __init__(self, bugtask, status=None, importance=None,
                  assignee=None, milestone=None, statusexplanation=None,
                  bugwatch=None, target=None):
@@ -461,7 +465,7 @@
         'productseriesID': IProductSeriesSet,
         'sourcepackagenameID': ISourcePackageNameSet,
         'distributionID': IDistributionSet,
-        'distroseriesID': IDistroSeriesSet
+        'distroseriesID': IDistroSeriesSet,
         }[attr]
     if value is None:
         target_params[attr[:-2]] = None
@@ -477,6 +481,7 @@
 
 class PassthroughValue:
     """A wrapper to allow setting values on conjoined bug tasks."""
+
     def __init__(self, value):
         self.value = value
 
@@ -543,7 +548,7 @@
         "date_closed", "date_incomplete", "date_left_new",
         "date_triaged", "date_fix_committed", "date_fix_released",
         "date_left_closed")
-    _NON_CONJOINED_STATUSES = (BugTaskStatus.WONTFIX,)
+    _NON_CONJOINED_STATUSES = (BugTaskStatus.WONTFIX, )
 
     bug = ForeignKey(dbName='bug', foreignKey='Bug', notNull=True)
     product = ForeignKey(
@@ -589,7 +594,7 @@
         notNull=False, default=None)
     date_assigned = UtcDateTimeCol(notNull=False, default=None,
         storm_validator=validate_conjoined_attribute)
-    datecreated  = UtcDateTimeCol(notNull=False, default=UTC_NOW)
+    datecreated = UtcDateTimeCol(notNull=False, default=UTC_NOW)
     date_confirmed = UtcDateTimeCol(notNull=False, default=None,
         storm_validator=validate_conjoined_attribute)
     date_inprogress = UtcDateTimeCol(notNull=False, default=None,
@@ -1009,10 +1014,10 @@
         if new_status < BugTaskStatus.FIXRELEASED:
             self.date_fix_released = None
 
-    def userCanSetAnyAssignee(self, user):
-        """See `IBugTask`."""
+    def _userCanSetAssignee(self, user):
+        """Used by methods to check if user can assign or unassign bugtask."""
         celebrities = getUtility(ILaunchpadCelebrities)
-        return user is not None and (
+        return (
             user.inTeam(self.pillar.bug_supervisor) or
             user.inTeam(self.pillar.owner) or
             user.inTeam(self.pillar.driver) or
@@ -1023,6 +1028,15 @@
             user.inTeam(celebrities.admin)
             or user == celebrities.bug_importer)
 
+    def userCanSetAnyAssignee(self, user):
+        """See `IBugTask`."""
+        if user is None:
+            return False
+        elif self.pillar.bug_supervisor is None:
+            return True
+        else:
+            return self._userCanSetAssignee(user)
+
     def userCanUnassign(self, user):
         """True if user can set the assignee to None.
 
@@ -1031,7 +1045,7 @@
         Launchpad admins can always unassign.
         """
         return user is not None and (
-            user.inTeam(self.assignee) or self.userCanSetAnyAssignee(user))
+            user.inTeam(self.assignee) or self._userCanSetAssignee(user))
 
     def canTransitionToAssignee(self, assignee):
         """See `IBugTask`."""
@@ -1162,7 +1176,7 @@
             component_name = component.name
 
         if IUpstreamBugTask.providedBy(self):
-            header_value = 'product=%s;' %  self.target.name
+            header_value = 'product=%s;' % self.target.name
         elif IProductSeriesBugTask.providedBy(self):
             header_value = 'product=%s; productseries=%s;' %  (
                 self.productseries.product.name, self.productseries.name)
@@ -1311,7 +1325,7 @@
 
 def _nocache_bug_decorator(obj):
     """A pass through decorator for consistency.
-    
+
     :seealso: get_bug_privacy_filter_with_decorator
     """
     return obj
@@ -1723,7 +1737,7 @@
                     sqlvalues(personid=params.subscriber.id))
 
         if params.structural_subscriber is not None:
-            structural_subscriber_clause = ( """BugTask.id IN (
+            structural_subscriber_clause = ("""BugTask.id IN (
                 SELECT BugTask.id FROM BugTask, StructuralSubscription
                 WHERE BugTask.product = StructuralSubscription.product
                   AND StructuralSubscription.subscriber = %(personid)s
@@ -2161,7 +2175,7 @@
 
     def search(self, params, *args, **kwargs):
         """See `IBugTaskSet`.
-        
+
         :param _noprejoins: Private internal parameter to BugTaskSet which
             disables all use of prejoins : consolidated from code paths that
             claim they were inefficient and unwanted.
@@ -2171,7 +2185,8 @@
         from lp.bugs.model.bug import Bug
         _noprejoins = kwargs.get('_noprejoins', False)
         store = IStore(BugTask)
-        query, clauseTables, orderby, bugtask_decorator = self.buildQuery(params)
+        query, clauseTables, orderby, bugtask_decorator = self.buildQuery(
+            params)
         if len(args) == 0:
             if _noprejoins:
                 resultset = store.find(BugTask,
@@ -2228,8 +2243,8 @@
             return bugtask
 
         # Build up the joins.
-        # TODO: implement _noprejoins for this code path: as of 20100818 it has
-        # been silently disabled because clients of the API were setting
+        # TODO: implement _noprejoins for this code path: as of 20100818 it
+        # has been silently disabled because clients of the API were setting
         # prejoins=[] which had no effect; this TODO simply notes the reality
         # already existing when it was added.
         joins = Alias(result._get_select(), "BugTask")
@@ -2279,9 +2294,10 @@
             # Import here because of cyclic references.
             from lp.registry.model.milestone import (
                 Milestone, milestone_sort_key)
-            # We need the store that was used, we have no objects to key off of
-            # other than the search result, and Store.of() doesn't currently
-            # work on result sets. Additionally it may be a DecoratedResultSet.
+            # We need the store that was used, we have no objects to key off
+            # of other than the search result, and Store.of() doesn't
+            # currently work on result sets. Additionally it may be a
+            # DecoratedResultSet.
             if zope_isinstance(search_results, DecoratedResultSet):
                 store = removeSecurityProxy(search_results).result_set._store
             else:

=== modified file 'lib/lp/bugs/stories/bugtask-management/xx-change-assignee.txt'
--- lib/lp/bugs/stories/bugtask-management/xx-change-assignee.txt	2010-05-25 14:50:42 +0000
+++ lib/lp/bugs/stories/bugtask-management/xx-change-assignee.txt	2010-08-31 18:56:47 +0000
@@ -90,7 +90,19 @@
 
 == Bug task assignment by regular users ==
 
-Regular users can only set themselves and their teams as assignees.
+Regular users can only set themselves and their teams as assignees if
+there is a bug supervisor established for a project.
+
+To demonstrate, let's first set a bug supervisor for the jokosher
+project used in these tests.
+
+    >>> login('[e-mail]')
+    >>> from lp.registry.interfaces.product import IProductSet
+    >>> jokosher = getUtility(IProductSet).getByName('jokosher')
+    >>> foobar = getUtility(IPersonSet).getByName('name16')
+    >>> jokosher.setBugSupervisor(foobar, foobar)
+    >>> logout()
+
 To avoid any confusion, the option to assign somebody else is only
 shown if the user has sufficient privileges to assign anybody or if
 the user is a member of at least one team. no-priv is no a member of

=== modified file 'lib/lp/bugs/tests/test_bugtask.py'
--- lib/lp/bugs/tests/test_bugtask.py	2010-08-26 18:57:35 +0000
+++ lib/lp/bugs/tests/test_bugtask.py	2010-08-31 18:56:47 +0000
@@ -25,7 +25,6 @@
     BugTaskImportance,
     BugTaskSearchParams,
     BugTaskStatus,
-    IBugTaskSet,
     )
 from lp.bugs.model.bugtask import build_tag_search_clause
 from lp.hardwaredb.interfaces.hwdb import (
@@ -541,15 +540,9 @@
         self.regular_user = self.factory.makePerson()
 
         login_person(self.target_owner_member)
+        # Target and bug supervisor creation are deferred to sub-classes.
         self.makeTarget()
-
-        self.supervisor_team = self.factory.makeTeam(
-            owner=self.target_owner_member)
-        self.supervisor_member = self.factory.makePerson()
-        self.supervisor_team.addMember(
-            self.supervisor_member, self.target_owner_member)
-        self.target.setBugSupervisor(
-            self.supervisor_team, self.target_owner_member)
+        self.setBugSupervisor()
 
         self.driver_team = self.factory.makeTeam(
             owner=self.target_owner_member)
@@ -582,6 +575,29 @@
         """
         raise NotImplementedError(self.makeTarget)
 
+    def setBugSupervisor(self):
+        """Set bug supervisor variables.
+
+        This is the standard interface for sub-classes, but this
+        method should return _setBugSupervisorData or
+        _setBugSupervisorDataNone depending on what is required.
+        """
+        raise NotImplementedError(self.setBugSupervisor)
+
+    def _setBugSupervisorData(self):
+        """Helper function used by sub-classes to setup bug supervisors."""
+        self.supervisor_team = self.factory.makeTeam(
+            owner=self.target_owner_member)
+        self.supervisor_member = self.factory.makePerson()
+        self.supervisor_team.addMember(
+            self.supervisor_member, self.target_owner_member)
+        self.target.setBugSupervisor(
+            self.supervisor_team, self.target_owner_member)
+
+    def _setBugSupervisorDataNone(self):
+        """Helper for sub-classes to work around setting a bug supervisor."""
+        self.supervisor_member = None
+
     def test_userCanSetAnyAssignee_anonymous_user(self):
         # Anonymous users cannot set anybody as an assignee.
         login(ANONYMOUS)
@@ -595,12 +611,20 @@
         self.assertFalse(self.series_bugtask.userCanUnassign(None))
 
     def test_userCanSetAnyAssignee_regular_user(self):
-        # Ordinary users cannot set others as an assignee.
+        # If we have a bug supervisor, check that regular user cannot
+        # assign to someone else.  Otherwise, the regular user should
+        # be able to assign to anyone.
         login_person(self.regular_user)
-        self.assertFalse(
-            self.target_bugtask.userCanSetAnyAssignee(self.regular_user))
-        self.assertFalse(
-            self.series_bugtask.userCanSetAnyAssignee(self.regular_user))
+        if self.supervisor_member is not None:
+            self.assertFalse(
+                self.target_bugtask.userCanSetAnyAssignee(self.regular_user))
+            self.assertFalse(
+                self.series_bugtask.userCanSetAnyAssignee(self.regular_user))
+        else:
+            self.assertTrue(
+                self.target_bugtask.userCanSetAnyAssignee(self.regular_user))
+            self.assertTrue(
+                self.series_bugtask.userCanSetAnyAssignee(self.regular_user))
 
     def test_userCanUnassign_regular_user(self):
         # Ordinary users can unassign themselves...
@@ -640,19 +664,23 @@
 
     def test_userCanSetAnyAssignee_bug_supervisor(self):
         # A bug supervisor can assign anybody.
-        login_person(self.supervisor_member)
-        self.assertTrue(
-            self.target_bugtask.userCanSetAnyAssignee(self.supervisor_member))
-        self.assertTrue(
-            self.series_bugtask.userCanSetAnyAssignee(self.supervisor_member))
+        if self.supervisor_member is not None:
+            login_person(self.supervisor_member)
+            self.assertTrue(
+                self.target_bugtask.userCanSetAnyAssignee(
+                    self.supervisor_member))
+            self.assertTrue(
+                self.series_bugtask.userCanSetAnyAssignee(
+                    self.supervisor_member))
 
     def test_userCanUnassign_bug_supervisor(self):
         # A bug supervisor can unassign anybody.
-        login_person(self.supervisor_member)
-        self.assertTrue(
-            self.target_bugtask.userCanUnassign(self.supervisor_member))
-        self.assertTrue(
-            self.series_bugtask.userCanUnassign(self.supervisor_member))
+        if self.supervisor_member is not None:
+            login_person(self.supervisor_member)
+            self.assertTrue(
+                self.target_bugtask.userCanUnassign(self.supervisor_member))
+            self.assertTrue(
+                self.series_bugtask.userCanUnassign(self.supervisor_member))
 
     def test_userCanSetAnyAssignee_driver(self):
         # A project driver can assign anybody.
@@ -676,10 +704,16 @@
         self.assertTrue(
             self.series_bugtask.userCanSetAnyAssignee(
                 self.series_driver_member))
-        # But he cannot assign anybody to bug tasks of the main target.
-        self.assertFalse(
-            self.target_bugtask.userCanSetAnyAssignee(
-                self.series_driver_member))
+        if self.supervisor_member is not None:
+            # But he cannot assign anybody to bug tasks of the main target...
+            self.assertFalse(
+                self.target_bugtask.userCanSetAnyAssignee(
+                    self.series_driver_member))
+        else:
+            # ...unless a bug supervisor is not set.
+            self.assertTrue(
+                self.target_bugtask.userCanSetAnyAssignee(
+                    self.series_driver_member))
 
     def test_userCanUnassign_series_driver(self):
         # The target owner can unassign anybody from series bug tasks...
@@ -733,6 +767,23 @@
         self.target = self.factory.makeProduct(owner=self.target_owner_team)
         self.series = self.factory.makeProductSeries(self.target)
 
+    def setBugSupervisor(self):
+        """Establish a bug supervisor for this target."""
+        self._setBugSupervisorData()
+
+
+class TestProductNoBugSupervisorBugTaskPermissionsToSetAssignee(
+    TestBugTaskPermissionsToSetAssigneeMixin, TestCaseWithFactory):
+
+    def makeTarget(self):
+        """Create a product and a product series without a bug supervisor."""
+        self.target = self.factory.makeProduct(owner=self.target_owner_team)
+        self.series = self.factory.makeProductSeries(self.target)
+
+    def setBugSupervisor(self):
+        """Set bug supervisor to None."""
+        self._setBugSupervisorDataNone()
+
 
 class TestDistributionBugTaskPermissionsToSetAssignee(
     TestBugTaskPermissionsToSetAssigneeMixin, TestCaseWithFactory):
@@ -743,6 +794,24 @@
             owner=self.target_owner_team)
         self.series = self.factory.makeDistroSeries(self.target)
 
+    def setBugSupervisor(self):
+        """Set bug supervisor to None."""
+        self._setBugSupervisorData()
+
+
+class TestDistributionNoBugSupervisorBugTaskPermissionsToSetAssignee(
+    TestBugTaskPermissionsToSetAssigneeMixin, TestCaseWithFactory):
+
+    def makeTarget(self):
+        """Create a distribution and a distroseries."""
+        self.target = self.factory.makeDistribution(
+            owner=self.target_owner_team)
+        self.series = self.factory.makeDistroSeries(self.target)
+
+    def setBugSupervisor(self):
+        """Establish a bug supervisor for this target."""
+        self._setBugSupervisorDataNone()
+
 
 class TestBugTaskSearch(TestCaseWithFactory):
 
@@ -814,11 +883,11 @@
         person = self.login()
         self.factory.makeBug(product=target, private=True, owner=person)
         self.factory.makeBug(product=target, private=True, owner=person)
-        # Search style and parameters taken from the milestone index view where
-        # the issue was discovered.
+        # Search style and parameters taken from the milestone index view
+        # where the issue was discovered.
         login_person(person)
-        tasks = target.searchTasks(BugTaskSearchParams(person, omit_dupes=True,
-            orderby=['status', '-importance', 'id']))
+        tasks = target.searchTasks(BugTaskSearchParams(
+            person, omit_dupes=True, orderby=['status', '-importance', 'id']))
         # We must be finding the bugs.
         self.assertEqual(2, tasks.count())
         # Cache in the storm cache the account->person lookup so its not
@@ -828,7 +897,7 @@
         # allow access to getConjoinedMaster attribute - an attribute that
         # triggers a permission check (nb: id does not trigger such a check)
         self.assertStatementCount(1,
-            lambda:[task.getConjoinedMaster for task in tasks])
+            lambda: [task.getConjoinedMaster for task in tasks])
 
     def test_omit_targeted_default_is_false(self):
         # The default value of omit_targeted is false so bugs targeted