Code review comment for lp:~dedeco/bzr-explorer/fix-948268
Revision history for this message
| Alexander Belchenko (bialix) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
The actual change looks good enough for me. But why did you change the identation of the surrounding code? It's a bad idea to arbitrary change identation or formatting in open source projects. Furthermore, in bzr-explorer, qbzr, we're trying to follow recommendations of PEP-8 for python syntax, e.g. use 4 spaces for identation.
I'm inclined to merge only relevant part of you patch and revert other changes.