Merge lp:~dedeco/bzr-explorer/fix-948268 into lp:bzr-explorer
Proposed by
Dedeco
Status: | Superseded |
---|---|
Proposed branch: | lp:~dedeco/bzr-explorer/fix-948268 |
Merge into: | lp:bzr-explorer |
Diff against target: |
29 lines (+9/-8) 1 file modified
lib/i18n.py (+9/-8) |
To merge this branch: | bzr merge lp:~dedeco/bzr-explorer/fix-948268 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bazaar Explorer Developers | Pending | ||
Review via email: mp+96426@code.launchpad.net |
This proposal has been superseded by a proposal from 2012-03-15.
Commit message
Prefer language in configuration before enviroment variables. Fixes bug #948268.
Description of the change
Fixes bug #948268.
To post a comment you must log in.
The actual change looks good enough for me. But why did you change the identation of the surrounding code? It's a bad idea to arbitrary change identation or formatting in open source projects. Furthermore, in bzr-explorer, qbzr, we're trying to follow recommendations of PEP-8 for python syntax, e.g. use 4 spaces for identation.
I'm inclined to merge only relevant part of you patch and revert other changes.