Code review comment for ~ddstreet/software-properties:simple_http_unix_connection

Revision history for this message
Shivaram Lingamneni (slingamn) wrote :

This crashed for me on 20.04:

Jan 26 12:17:00 guivm gnome-control-center.desktop[2058]: Traceback (most recent call last):
Jan 26 12:17:00 guivm gnome-control-center.desktop[2058]: File "/usr/bin/software-properties-gtk", line 37, in <module>
Jan 26 12:17:00 guivm gnome-control-center.desktop[2058]: from softwareproperties.gtk.SoftwarePropertiesGtk import SoftwarePropertiesGtk
Jan 26 12:17:00 guivm gnome-control-center.desktop[2058]: File "/usr/lib/python3/dist-packages/softwareproperties/gtk/SoftwarePropertiesGtk.py", line 56, in <module>
Jan 26 12:17:00 guivm gnome-control-center.desktop[2058]: from .LivepatchPage import LivepatchPage
Jan 26 12:17:00 guivm gnome-control-center.desktop[2058]: File "/usr/lib/python3/dist-packages/softwareproperties/gtk/LivepatchPage.py", line 31, in <module>
Jan 26 12:17:00 guivm gnome-control-center.desktop[2058]: from softwareproperties.LivepatchService import (
Jan 26 12:17:00 guivm gnome-control-center.desktop[2058]: File "/usr/lib/python3/dist-packages/softwareproperties/LivepatchService.py", line 24, in <module>
Jan 26 12:17:00 guivm gnome-control-center.desktop[2058]: from urllib import urlparse, urlencode
Jan 26 12:17:00 guivm gnome-control-center.desktop[2058]: ImportError: cannot import name 'urlparse' from 'urllib' (/usr/lib/python3.8/urllib/__init__.py)

With the import changed to `from urllib.parse import urlparse, urlencode`, it doesn't crash, but the UI displays "Failed to retrieve Livepatch status.". I think it might be hitting an exception somewhere?

« Back to merge proposal