Merge ~ddstreet/software-properties:simple_http_unix_connection into software-properties:ubuntu/master
Proposed by
Dan Streetman
Status: | Merged |
---|---|
Merged at revision: | fe446246f23a119d305b5cb924eeba31ca2b366d |
Proposed branch: | ~ddstreet/software-properties:simple_http_unix_connection |
Merge into: | software-properties:ubuntu/master |
Diff against target: |
163 lines (+41/-60) 2 files modified
dev/null (+0/-43) softwareproperties/LivepatchService.py (+41/-17) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Shivaram Lingamneni | Pending | ||
Review via email: mp+396926@code.launchpad.net |
To post a comment you must log in.
This crashed for me on 20.04:
Jan 26 12:17:00 guivm gnome-control- center. desktop[ 2058]: Traceback (most recent call last): center. desktop[ 2058]: File "/usr/bin/ software- properties- gtk", line 37, in <module> center. desktop[ 2058]: from softwarepropert ies.gtk. SoftwarePropert iesGtk import SoftwarePropert iesGtk center. desktop[ 2058]: File "/usr/lib/ python3/ dist-packages/ softwarepropert ies/gtk/ SoftwarePropert iesGtk. py", line 56, in <module> center. desktop[ 2058]: from .LivepatchPage import LivepatchPage center. desktop[ 2058]: File "/usr/lib/ python3/ dist-packages/ softwarepropert ies/gtk/ LivepatchPage. py", line 31, in <module> center. desktop[ 2058]: from softwarepropert ies.LivepatchSe rvice import ( center. desktop[ 2058]: File "/usr/lib/ python3/ dist-packages/ softwarepropert ies/LivepatchSe rvice.py" , line 24, in <module> center. desktop[ 2058]: from urllib import urlparse, urlencode center. desktop[ 2058]: ImportError: cannot import name 'urlparse' from 'urllib' (/usr/lib/ python3. 8/urllib/ __init_ _.py)
Jan 26 12:17:00 guivm gnome-control-
Jan 26 12:17:00 guivm gnome-control-
Jan 26 12:17:00 guivm gnome-control-
Jan 26 12:17:00 guivm gnome-control-
Jan 26 12:17:00 guivm gnome-control-
Jan 26 12:17:00 guivm gnome-control-
Jan 26 12:17:00 guivm gnome-control-
Jan 26 12:17:00 guivm gnome-control-
Jan 26 12:17:00 guivm gnome-control-
With the import changed to `from urllib.parse import urlparse, urlencode`, it doesn't crash, but the UI displays "Failed to retrieve Livepatch status.". I think it might be hitting an exception somewhere?