Ubuntu
systemd package

Code review comment for ~daxtens/ubuntu/+source/systemd:lp1812760-bionic

  1. Git
  2. lp:~daxtens/ubuntu/+source/systemd
  3. lp1812760-bionic
  4. Merge into ubuntu/bionic-devel
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Hi Daniel,
this isn't a full review as I'm not feeling authorized for that on systemd.
I added xnox as a reviewer to take a look from that POV.
But already I saw a few formal things you could address.

- The changelog entry should list the patches in d/p/... that are related to this fix.
- the patches should get more entries to follow dep3 [1] standard
  You have backported changes (modified) and used as-is - mark those accordingly
  Please use URLs to a git, not just hash values.
  The following snippet might help

# IF MODIFIED
Author: <<our mail/name>
Original-Author: <todo-author>
Origin: backport, <todo-URL-to-git>
# OTHERWISE
Origin: upstream, <todo-URL-to-git>

Bug-Ubuntu: https://bugs.launchpad.net/bugs/1812760
Last-Update: 2019-01-22

[1]: https://dep-team.pages.debian.net/deps/dep3/

review: Needs Fixing

« Back to merge proposal