Merge ~daxtens/ubuntu/+source/systemd:lp1812760-bionic into ubuntu/+source/systemd:ubuntu/bionic-devel
Status: | Rejected |
---|---|
Rejected by: | Christian Ehrhardt |
Proposed branch: | ~daxtens/ubuntu/+source/systemd:lp1812760-bionic |
Merge into: | ubuntu/+source/systemd:ubuntu/bionic-devel |
Diff against target: |
498 lines (+458/-0) 6 files modified
debian/changelog (+15/-0) debian/patches/Install-routes-after-addresses-are-ready.patch (+98/-0) debian/patches/Move-link_check_ready-to-later-in-the-file.patch (+147/-0) debian/patches/networkd-don-t-remove-ip-address.patch (+92/-0) debian/patches/networkd-don-t-remove-route.patch (+102/-0) debian/patches/series (+4/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Ehrhardt (community) | Needs Fixing | ||
Dimitri John Ledkov | Pending | ||
Canonical Server Core Reviewers | Pending | ||
Canonical Server | Pending | ||
Review via email: mp+362056@code.launchpad.net |
Description of the change
* Fix an issue where IPv6 routes that specified PreferredSource
would not be added - upstream bug #5882. (LP: #1812760)
PPA: ppa:daxtens/
Steps to test:
Start a Bionic VM.
Add the following netplan yaml (adjust for ethernet card and MAC):
network:
version: 2
ethernets:
ens3:
dhcp4: true
match:
routes:
- to: "a::/16"
- to: "fd8f:1d7d:
Run netplan apply or reboot. (If you have run netplan apply, wait ~10s for addresses to leave tentative state.)
With the current version, ip -6 route reports:
ubuntu@b-np:~$ ip -6 route
fd8f:1d7d:b141::/64 dev ens3 proto kernel metric 256 pref medium
fe80::/64 dev ens3 proto kernel metric 256 pref medium
This is missing the route to "a::/16", and the route to "fd8f:1d7d:
Test the new version:
sudo apt-add-repository ppa:daxtens/
sudo apt update
sudo apt install systemd
sudo reboot # it's not sufficient to run netplan apply here as the addresses already exist and are not tentative
Now, we see:
ubuntu@b-np:~$ ip -6 route
a::/16 via fd8f:1d7d:b141::1 dev ens3 proto static src fd8f:1d7d:b141::2 metric 1024 pref medium
fd8f:1d7d:b141::/64 dev ens3 proto static src fd8f:1d7d:b141::2 metric 255 pref medium
fd8f:1d7d:b141::/64 dev ens3 proto kernel metric 256 pref medium
fe80::/64 dev ens3 proto kernel metric 256 pref medium
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Hi Daniel,
this isn't a full review as I'm not feeling authorized for that on systemd.
I added xnox as a reviewer to take a look from that POV.
But already I saw a few formal things you could address.
- The changelog entry should list the patches in d/p/... that are related to this fix.
- the patches should get more entries to follow dep3 [1] standard
You have backported changes (modified) and used as-is - mark those accordingly
Please use URLs to a git, not just hash values.
The following snippet might help
# IF MODIFIED
Author: <<our mail/name>
Original-Author: <todo-author>
Origin: backport, <todo-URL-to-git>
# OTHERWISE
Origin: upstream, <todo-URL-to-git>
Bug-Ubuntu: https:/ /bugs.launchpad .net/bugs/ 1812760
Last-Update: 2019-01-22
[1]: https:/ /dep-team. pages.debian. net/deps/ dep3/