Merge lp:~davidgomes/granite/fix-1116864 into lp:~elementary-pantheon/granite/granite

[David Gomes]

Fixed bug #1116864 by destroying a tab's page_container. I used kalikiana's patch, so I --author'd him.

[David Gomes (davidgomes)]

Note: this needs testing.

[David Gomes (davidgomes)]

Alright, I tested it and it works as a fix for Midori Granite. More testing is appreciated, though.

[Sergey "Shnatsel" Davidoff (shnatsel)]

Try tricking people into running "elementary-test-merge https://code.launchpad.net/~davidgomes/granite/fix-1116864/+merge/153237" and observe results.

[RabbitBot (rabbitbot-a)]

review: Approve

=== modified file 'lib/Widgets/DynamicNotebook.vala'
--- lib/Widgets/DynamicNotebook.vala	2013-01-03 05:38:19 +0000
+++ lib/Widgets/DynamicNotebook.vala	2013-03-13 20:05:28 +0000
@@ -459,6 +459,7 @@
         unowned Gtk.Notebook on_create_window (Gtk.Widget page, int x, int y) {
             var tab = notebook.get_tab_label (page) as Tab;
             notebook.remove_page (notebook.page_num (tab.page_container));
+            tab.page_container.destroy ();
 
             tab_moved (tab, 0, true, x, y);
             return null;
@@ -491,6 +492,7 @@
             var pos = get_tab_position (tab);
             if (pos != -1)
                 notebook.remove_page (pos);
+            tab.page_container.destroy ();
         }
 
         public void next_page () {
@@ -578,6 +580,7 @@
 
             tab.new_window.connect (() => {
                 notebook.remove_page (notebook.page_num (tab.page_container));
+                tab.page_container.destroy ();
                 tab_moved (tab, 0, true, 0, 0);
             });