DynamicNotebook.remove_tab - Audio keeps playing in closed tab

Bug #1116864 reported by Cassidy James Blaede
30
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Granite
Fix Released
Critical
Cris Dywan
Midori Web Browser
Fix Released
Undecided
Unassigned

Bug Description

I'm using midori-granite on elementary OS Luna (Ubuntu 12.04) and 12.10. If I play an HTML5 video in a tab, then close that tab while it's playing, it continues to play. Since I closed the tab, there is no way to stop it.

Related branches

description: updated
Revision history for this message
Danielle Foré (danrabbit) wrote :

I think this is a dynamic notebook issue. It seems like the tab is removed from the notebook, but the webkit view is not actually destroyed.

tags: added: dynamic-notebook granite
Revision history for this message
Julián Unrrein (junrrein) wrote :

I had a somewhat similar situation to what Dan comments. I has a tab with Facebook opened. I closed it and continued browsing, but then i started hearing the "Message received" sound. I concluded that the website was still opened even when the tab was closed.

Revision history for this message
Arturo Torres Sánchez (r2d2.art2005) wrote :

Is this related to bug 1021565? Maybe it was not correctly fixed.

Revision history for this message
Cris Dywan (kalikiana) wrote :

I confirm that a click on the [x] in the tab label only hides the view. It seems that DynamicNotebook.remove_tab doesn't destroy the widget as expected.

Changed in midori:
status: New → Invalid
Changed in granite:
status: New → Confirmed
importance: Undecided → Critical
summary: - Audio from HTML5 video keeps playing after tab is closed
+ DynamicNotebook.remove_tab - Audio keeps playing in closed tab
Cris Dywan (kalikiana)
Changed in midori:
assignee: nobody → Christian Dywan (kalikiana)
Cris Dywan (kalikiana)
Changed in granite:
assignee: nobody → Christian Dywan (kalikiana)
Changed in midori:
assignee: Christian Dywan (kalikiana) → nobody
Changed in granite:
status: Confirmed → In Progress
Revision history for this message
Cris Dywan (kalikiana) wrote :

It seems like all the notebook.remove_page calls in DynamicNotebook are useless, and it only looked half broken because Midori itself ended up doing it depending on the code path.

I'm fixing Midori to not destroy in either case. This means: Granite will consistently yield broken results. But with the attached patch, it consistently works properly on my system.

Changed in midori:
status: Invalid → In Progress
status: In Progress → Fix Committed
Changed in granite:
assignee: Christian Dywan (kalikiana) → nobody
Cody Garver (codygarver)
Changed in granite:
milestone: none → luna-beta2
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
David Gomes (davidgomes)
Changed in granite:
assignee: nobody → David Gomes (davidgomes)
RabbitBot (rabbitbot-a)
Changed in granite:
status: In Progress → Fix Released
assignee: David Gomes (davidgomes) → Christian Dywan (kalikiana)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.