Merge lp:~david4dev/dmedia/constants-from-mimetypes into lp:dmedia

[David Green]

This change generates the constants VIDEO, AUDIO and IMAGE using the mimetypes module to get the details.

[Jason Gerard DeRose (jderose)]

Thanks, David, much better than what I was doing.

Down the road we should probably move this out of constants.py as this something dynamically built when the module loads, will affect startup time slightly. I want importing client.py to have as few dependencies/resources as possible, and client.py imports constants.

review: Approve

=== modified file 'dmedialib/constants.py'
--- dmedialib/constants.py	2010-11-27 03:40:39 +0000
+++ dmedialib/constants.py	2010-11-27 15:36:09 +0000
@@ -1,5 +1,6 @@
 # Authors:
 #   Jason Gerard DeRose <[e-mail]>
+#   David Green <[e-mail]>
 #
 # dmedia: distributed media library
 # Copyright (C) 2010 Jason Gerard DeRose <[e-mail]>
@@ -23,25 +24,29 @@
 Various constants conveniently located in one place.
 """
 
+import mimetypes
+mimetypes.init()
+
+
 BUS = 'org.freedesktop.DMedia'
 INTERFACE = 'org.freedesktop.DMedia'
 
 TYPE_ERROR = '%s: need a %r; got a %r: %r'  # Standard TypeError message
 
-
-VIDEO = (
-    'ogv',  # video/ogg
-    'webm',  # video/webm
-    'mov', 'qt',  # video/quicktime
-    'mp4',  # video/mp4
-    'mpeg', 'mpg', 'mpe',  # video/mpeg
-    'avi',  # video/x-msvideo
-    'mpv', 'mkv',  # video/x-matroska
-)
-
-AUDIO = ('wav', 'oga', 'flac', 'spx', 'mp3')
-
-IMAGE = ('jpg', 'png', 'cr2', 'crw', 'nef')
+def get_extensions_for_type(general_type):
+    """
+    An iterator that yields the file extensions for files of a general type.
+    eg. 'image'
+    """
+    for ext in mimetypes.types_map:
+        if mimetypes.types_map[ext].split('/')[0] == general_type:
+            yield ext.strip('.')
+
+VIDEO = tuple(get_extensions_for_type('video'))
+
+AUDIO = tuple(get_extensions_for_type('audio'))
+
+IMAGE = tuple(get_extensions_for_type('image'))
 
 EXTENSIONS = VIDEO + AUDIO + IMAGE
 
@@ -51,3 +56,5 @@
     'image': IMAGE,
     'all': EXTENSIONS,
 }
+
+