Code review comment for lp:~david4dev/dmedia/constants-from-mimetypes

Revision history for this message
Jason Gerard DeRose (jderose) wrote :

Thanks, David, much better than what I was doing.

Down the road we should probably move this out of constants.py as this something dynamically built when the module loads, will affect startup time slightly. I want importing client.py to have as few dependencies/resources as possible, and client.py imports constants.

review: Approve

« Back to merge proposal