Merge lp:~david4dev/dmedia/constants-from-mimetypes into lp:dmedia
Proposed by
David Green
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 120 | ||||
Proposed branch: | lp:~david4dev/dmedia/constants-from-mimetypes | ||||
Merge into: | lp:dmedia | ||||
Diff against target: |
60 lines (+21/-14) 1 file modified
dmedialib/constants.py (+21/-14) |
||||
To merge this branch: | bzr merge lp:~david4dev/dmedia/constants-from-mimetypes | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jason Gerard DeRose | Approve | ||
Review via email: mp+42015@code.launchpad.net |
Description of the change
This change generates the constants VIDEO, AUDIO and IMAGE using the mimetypes module to get the details.
To post a comment you must log in.
Thanks, David, much better than what I was doing.
Down the road we should probably move this out of constants.py as this something dynamically built when the module loads, will affect startup time slightly. I want importing client.py to have as few dependencies/ resources as possible, and client.py imports constants.