Code review comment for lp:~dave-cheney/juju-core/153-fix-release-tools-script

The attempt to merge lp:~dave-cheney/juju-core/153-fix-release-tools-script into lp:juju-core failed. Below is the output from the failed tests.

ok launchpad.net/juju-core/agent 0.758s
ok launchpad.net/juju-core/agent/tools 0.248s
ok launchpad.net/juju-core/bzr 7.269s
ok launchpad.net/juju-core/cert 2.587s
ok launchpad.net/juju-core/charm 0.584s
? launchpad.net/juju-core/charm/hooks [no test files]
ok launchpad.net/juju-core/cloudinit 0.021s
ok launchpad.net/juju-core/cmd 0.286s
? launchpad.net/juju-core/cmd/builddb [no test files]
? launchpad.net/juju-core/cmd/charmd [no test files]
? launchpad.net/juju-core/cmd/charmload [no test files]
ok launchpad.net/juju-core/cmd/juju 136.618s
ok launchpad.net/juju-core/cmd/jujud 39.656s
ok launchpad.net/juju-core/cmd/plugins/juju-metadata 1.908s
ok launchpad.net/juju-core/constraints 0.026s
ok launchpad.net/juju-core/container/lxc 0.304s
? launchpad.net/juju-core/container/lxc/mock [no test files]
ok launchpad.net/juju-core/downloader 5.256s
ok launchpad.net/juju-core/environs 1.782s
ok launchpad.net/juju-core/environs/bootstrap 5.066s
ok launchpad.net/juju-core/environs/cloudinit 0.430s
ok launchpad.net/juju-core/environs/config 0.850s
ok launchpad.net/juju-core/environs/filestorage 0.062s
ok launchpad.net/juju-core/environs/imagemetadata 0.526s
ok launchpad.net/juju-core/environs/instances 0.264s
ok launchpad.net/juju-core/environs/jujutest 0.236s
ok launchpad.net/juju-core/environs/localstorage 0.251s
ok launchpad.net/juju-core/environs/manual 0.969s
ok launchpad.net/juju-core/environs/simplestreams 0.338s
? launchpad.net/juju-core/environs/simplestreams/testing [no test files]
ok launchpad.net/juju-core/environs/sync 0.286s
ok launchpad.net/juju-core/environs/testing 0.010s
ok launchpad.net/juju-core/environs/tools 34.243s
? launchpad.net/juju-core/environs/tools/testing [no test files]
? launchpad.net/juju-core/errors [no test files]
ok launchpad.net/juju-core/instance 0.025s
ok launchpad.net/juju-core/juju 17.291s
ok launchpad.net/juju-core/juju/osenv 0.205s
? launchpad.net/juju-core/juju/testing [no test files]
ok launchpad.net/juju-core/log 0.015s
ok launchpad.net/juju-core/log/syslog 0.020s
ok launchpad.net/juju-core/names 0.041s
ok launchpad.net/juju-core/provider 0.268s
? launchpad.net/juju-core/provider/all [no test files]
ok launchpad.net/juju-core/provider/azure 6.366s
ok launchpad.net/juju-core/provider/dummy 19.248s
ok launchpad.net/juju-core/provider/ec2 5.387s
ok launchpad.net/juju-core/provider/local 1.810s
? launchpad.net/juju-core/provider/local/storage [no test files]
ok launchpad.net/juju-core/provider/maas 3.670s
ok launchpad.net/juju-core/provider/openstack 4.807s
ok launchpad.net/juju-core/rpc 0.241s
ok launchpad.net/juju-core/rpc/jsoncodec 0.212s
ok launchpad.net/juju-core/schema 0.018s
ok launchpad.net/juju-core/state 70.308s
ok launchpad.net/juju-core/state/api 1.552s
ok launchpad.net/juju-core/state/api/agent 2.025s
? launchpad.net/juju-core/state/api/common [no test files]
ok launchpad.net/juju-core/state/api/deployer 5.853s
ok launchpad.net/juju-core/state/api/logger 2.490s
ok launchpad.net/juju-core/state/api/machiner 3.069s
ok launchpad.net/juju-core/state/api/params 0.031s
ok launchpad.net/juju-core/state/api/uniter 28.145s
ok launchpad.net/juju-core/state/api/upgrader 4.225s
ok launchpad.net/juju-core/state/api/watcher 3.514s
ok launchpad.net/juju-core/state/apiserver 3.863s
ok launchpad.net/juju-core/state/apiserver/agent 2.691s
ok launchpad.net/juju-core/state/apiserver/client 21.755s
ok launchpad.net/juju-core/state/apiserver/common 0.241s
ok launchpad.net/juju-core/state/apiserver/deployer 4.900s
ok launchpad.net/juju-core/state/apiserver/logger 3.821s
ok launchpad.net/juju-core/state/apiserver/machine 4.223s
? launchpad.net/juju-core/state/apiserver/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/uniter 17.952s
ok launchpad.net/juju-core/state/apiserver/upgrader 6.141s
ok launchpad.net/juju-core/state/multiwatcher 0.956s

----------------------------------------------------------------------
FAIL: presence_test.go:226: PresenceSuite.TestExpiry

[LOG] 28.87205 INFO juju state/presence: Faking presence to time slot 0
presence_test.go:238:
    assertChange(c, ch, presence.Change{"a", true})
presence_test.go:66:
    c.Fatalf("watch reported nothing, want %v", want)
... Error: watch reported nothing, want {a true}

[LOG] 38.91755 INFO juju state/presence: Not faking presence time. Real time slot in use.
OOPS: 11 passed, 1 FAILED
--- FAIL: TestPackage (16.14 seconds)
FAIL
FAIL launchpad.net/juju-core/state/presence 16.336s
ok launchpad.net/juju-core/state/statecmd 0.024s
? launchpad.net/juju-core/state/testing [no test files]
ok launchpad.net/juju-core/state/watcher 6.159s
ok launchpad.net/juju-core/store 19.283s
ok launchpad.net/juju-core/testing 1.456s
ok launchpad.net/juju-core/testing/checkers 0.018s
ok launchpad.net/juju-core/thirdparty/pbkdf2 0.140s
ok launchpad.net/juju-core/tools 0.019s
ok launchpad.net/juju-core/upstart 0.973s
ok launchpad.net/juju-core/utils 0.975s
ok launchpad.net/juju-core/utils/fslock 0.999s
ok launchpad.net/juju-core/utils/parallel 0.432s
ok launchpad.net/juju-core/utils/set 0.021s
ok launchpad.net/juju-core/version 0.086s
ok launchpad.net/juju-core/worker 1.737s
ok launchpad.net/juju-core/worker/apiuniter 134.495s
ok launchpad.net/juju-core/worker/apiuniter/charm 3.542s
ok launchpad.net/juju-core/worker/apiuniter/debug 0.063s
ok launchpad.net/juju-core/worker/apiuniter/hook 0.016s
ok launchpad.net/juju-core/worker/apiuniter/jujuc 0.462s
ok launchpad.net/juju-core/worker/apiuniter/relation 1.384s
ok launchpad.net/juju-core/worker/cleaner 1.271s
ok launchpad.net/juju-core/worker/deployer 4.078s
ok launchpad.net/juju-core/worker/firewaller 11.832s
ok launchpad.net/juju-core/worker/machiner 7.833s
ok launchpad.net/juju-core/worker/minunitsworker 1.402s
ok launchpad.net/juju-core/worker/provisioner 8.643s
ok launchpad.net/juju-core/worker/resumer 1.706s
ok launchpad.net/juju-core/worker/uniter 137.315s
ok launchpad.net/juju-core/worker/uniter/charm 3.148s
ok launchpad.net/juju-core/worker/uniter/debug 2.121s
ok launchpad.net/juju-core/worker/uniter/hook 0.023s
ok launchpad.net/juju-core/worker/uniter/jujuc 0.437s
ok launchpad.net/juju-core/worker/uniter/relation 1.340s
ok launchpad.net/juju-core/worker/upgrader 3.201s

warning: building out-of-date packages:
 launchpad.net/goamz/ec2/ec2test
 launchpad.net/goamz/s3/s3test
 launchpad.net/goose/testservices/hook
 launchpad.net/goose/testservices/identityservice
 launchpad.net/goose/testservices
 launchpad.net/goose/testservices/novaservice
 launchpad.net/goose/testservices/swiftservice
 launchpad.net/goose/testservices/openstackservice
 launchpad.net/lpad
installing these packages with 'go test -i ./...' will speed future tests.