lp:~dave-cheney/juju-core/153-fix-release-tools-script

Created by Dave Cheney and last modified
Get this branch:
bzr branch lp:~dave-cheney/juju-core/153-fix-release-tools-script
Only Dave Cheney can upload to this branch. If you are Dave Cheney please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Dave Cheney
Project:
juju-core
Status:
Development

Recent revisions

1750. By Dave Cheney

fix release tools script

1749. By Ian Booth

[r=wallyworld] simplestreams tools lookup on major.minor version

Juju's simplestreams support required exact matches on product id.
The tools lookup functionality however requires inexact matches on
major.minor version number. This branch enhances the simplestreams
support to allow such inexact matches. The tools validation plugin
is enhanced to use the new feature. This work is a pre-req for
replacing the legacy tools lookup with simplestreams.

https://codereview.appspot.com/13369043/

1748. By Tim Penhey

[r=thumper] Add the formatter concept to agent config.

In order to decouple the internal structure of the agent config from how it is
stored on disk, we introduce formatters. They are responsible for moving the
internal config to and from a serialization format.

The existing format is called "format 1.12", as that is the stable release
that the format was introduced.

Some of the methods are purposefully trivial at this stage, and they are
flushed out in the next branch.

https://codereview.appspot.com/13237050/

1747. By Dimiter Naydenov

[r=dimitern] api/uniter: Improve tests readability

Trivial change to rename suite's unit field
to stateUnit and the uniter.Unit proxy object
received through the API to apiUnit (in each
test case), as suggested online.

https://codereview.appspot.com/13472043/

R=themue

1746. By Dimiter Naydenov

[r=dimitern] api(server)/uniter: Fix (result, bool, error)

Change PublicAddress, PrivateAddress and CharmURL
to return (result, error) instead of (result, bool, error),
as discussed online, because since more than one
error can be returned the bool result is no longer
sufficient. Also, the first two calls where changed
at the server-side as well, while the last one
only at client-side for units, because for
services it has different semantics (the bool
means "forced" charm URL or not).

https://codereview.appspot.com/13383046/

R=fwereade

1745. By Dimiter Naydenov

[r=dimitern] api(server)/uniter: Return tags instead of names

UniterAPI.SubordinateNames() is renamed to
HasSubordinates() and returns (bool, error).
Added a TODO in uniter/modes.go to use it
instead of calling len(u.unit.SubordinateNames) > 0,
and since the other place SubordinateNames() was
called is now handled by DestroyAllSubordinates()
there's no need for it anymore.
Also GetPrincipal() now returns a unit tag, not
a name.

https://codereview.appspot.com/13348050/

R=fwereade

1744. By Dimiter Naydenov

[r=dimitern] api(server)/uniter: Added DestroyAllSubordinates

Because the uniter needs to remove both the
(principal) unit it's running with, and any
of its subordinates, this change was needed.
Added a new API call: DestroyAllSubordinates(),
as agreed online. We need to change the uniter
code to use it instead of Destroy() when dealing
with subordinates (uniter/modes.go:298), so added
a TODO for that.

https://codereview.appspot.com/13426045/

R=fwereade

1743. By Dimiter Naydenov

[r=dimitern] api/uniter: Remaining unit operations

Implemented what's left of the client-side uniter API
operations on units:
* ConfigSettings
* WatchConfigSettings
* OpenPort
* ClosePort
* IsPrincipal
* SubordinateNames
* Destroy
* Resolved
* ClearResolved
* CharmURL
* SetCharmURL
* PublicAddress
* SetPublicAddress
* PrivateAddress
* SetPrivateAddress

https://codereview.appspot.com/13272045/

R=fwereade

1742. By John A Meinel

[r=jameinel],[bug=1219661] cmd/jujud: Disable flaky test

TestManageStateServesAPI is failing about half the time on the bot. I'd love to
have a fix, but until we do I don't want to reject peoples patches incorrectly.

https://codereview.appspot.com/13253045/

1741. By Andrew Wilkins

[r=axwalk] juju-metadata: add generate-tools subcommand

This is a new subcommand for the juju-metadata plugin,
which can be used to generate simplestreams metadata
(index and products) for an existing set of tools.

The command will list the tools in the public bucket
or a local directory, and generate the index and
tools metadata in the same location.

https://codereview.appspot.com/13417043/

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:~go-bot/juju-core/trunk
This branch contains Public information 
Everyone can see this information.

Subscribers