Code review comment for ~dashmage/charm-logrotated:bug/2017798-update-cron-daily-location

Revision history for this message
Chi Wai CHAN (raychan96) wrote (last edit ):

Thanks for working on the fix.

After thinking this a bit, I am wondering why we are insist on using the default /etc/crontab and modify the cron.daily schedule, or copy the default /etc/crontab and modify the cron.daily schedule and put it under root's crontab. I think this is undesired because it will affect all cron jobs under /etc/cron.daily, not just the logrotate charm's cronjob.

One of the possible alternative is to just maintain our own cron job without using the default crontab.

For example, we can either 1. create a crontab for root user with only one entry, or 2. append an entry to default /etc/crontab without modifying original content

```
17 * * * * root path_to_charm_logrotate
```

This way, we can be sure that even if we add to root user's cronjob or /etc/crontab, it will not have big impacts. What do you think?

review: Needs Information

« Back to merge proposal