~dashmage/charm-logrotated:bug/2017798-update-cron-daily-location

Branch merges

Propose for merging

Merged into charm-logrotated:master at revision 10ab2f6b55b60798c08a40c4a86014c542a7bac1

JamesLin: Approve on 2023-05-19

🤖 prod-jenkaas-bootstack (community): Approve (continuous-integration) on 2023-05-19

Chi Wai CHAN: Needs Information on 2023-05-19

Eric Chen: Approve on 2023-05-19

BootStack Reviewers: Pending requested 2023-05-19

BootStack Reviewers: Pending requested 2023-05-19

Robert Gildein: Pending requested 2023-05-19

Tianqi Xiao: Pending requested 2023-05-19

Diff: 201 lines (+70/-25)

4 files modified

src/lib/lib_cron.py (+16/-14)
src/tests/functional/requirements.txt (+1/-0)
src/tests/functional/test_logrotate.py (+13/-5)
src/tests/unit/test_logrotate.py (+40/-6)

api

Superseded for merging into charm-logrotated:master

Eric Chen: Needs Fixing on 2023-05-13

Tianqi Xiao (community): Needs Information on 2023-05-12

🤖 prod-jenkaas-bootstack (community): Approve (continuous-integration) on 2023-05-12

Chi Wai CHAN: Approve on 2023-05-12

Robert Gildein: Approve on 2023-05-10

BootStack Reviewers: Pending requested 2023-05-12

JamesLin: Pending requested 2023-05-09

Diff: 201 lines (+62/-26)

4 files modified

src/lib/lib_cron.py (+19/-14)
src/tests/functional/requirements.txt (+1/-0)
src/tests/functional/test_logrotate.py (+13/-5)
src/tests/unit/test_logrotate.py (+29/-7)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

13acd7b... by Ashley James on 2023-05-09

Remove cron daily job from root user crontab.

Currently while modifying cron daily job execution time, it is
updated in the root user's crontab (/var/spool/cron/crontabs/root).
This leads to a duplicate execution along with the execution of
cron.daily scripts in /etc/crontab.

This commit aims to manage the execution of the charms' daily cron job
solely from the system crontab, /etc/crontab. It also fixes the existing
unit test `test_cron_daily_schedule` and mocks the crontab instead of
directly writing to it.

53248e0... by Ashley James on 2023-05-12

Fix flaky functional test

- Use tenacity.Retrying while checking for file in
`test_reconfigure_cronjob_frequency`

55f7ed6... by Mert Kirpici on 2023-05-05

LP #2017795

Reviewed-on: https://code.launchpad.net/~mertkirpici/charm-logrotated/+git/charm-logrotated/+merge/442359
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Erhan Sunar <email address hidden>
Reviewed-by: Chi Wai CHAN <email address hidden>

7316795... by Mert Kirpici on 2023-05-04

fix: cleanup old cronjobs upon config change

A change in cronjob frequency used to leave the old cronjobs behind,
causing unnecessary execution. This patch is mitigating that behavior
and also adds some tests.

Works-on: 2017795
Signed-off-by: Mert Kırpıcı <email address hidden>

017fd99... by Chi Wai CHAN on 2023-05-05

Add "size" directive for config option "override". This is mutually exclusive with "interval" directive, and if both "size" and "interval" are provided, "size" takes the precedence.

Reviewed-on: https://code.launchpad.net/~raychan96/charm-logrotated/+git/charm-logrotated/+merge/442228
Reviewed-by: Eric Chen <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Erhan Sunar <email address hidden>

e5f3e29... by Chi Wai CHAN on 2023-05-04

Add examples for "size" directive in config.yaml.

cf8e129... by Chi Wai CHAN on 2023-05-03

Add functional test for config option "override".

53663fd... by Chi Wai CHAN on 2023-05-03

Fix deprecated juju_tools.

7d0735f... by Chi Wai CHAN on 2023-04-28

Add "size" directive for config option "override".

4d9208b... by Chi Wai CHAN on 2023-05-02

Allow "override" option to override a single directive (rotate | interval), instead of having to specify both of them.

Reviewed-on: https://code.launchpad.net/~raychan96/charm-logrotated/+git/charm-logrotated/+merge/442076
Reviewed-by: Robert Gildein <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: JamesLin <email address hidden>
Reviewed-by: Erhan Sunar <email address hidden>