Merge lp:~darkxst/ubiquity/update_bg into lp:ubiquity

Proposed by Tim Lunn
Status: Merged
Merged at revision: 5992
Proposed branch: lp:~darkxst/ubiquity/update_bg
Merge into: lp:ubiquity
Diff against target: 64 lines (+22/-8)
2 files modified
bin/ubiquity-dm (+15/-7)
debian/changelog (+7/-1)
To merge this branch: bzr merge lp:~darkxst/ubiquity/update_bg
Reviewer Review Type Date Requested Status
Ubuntu Installer Team Pending
Review via email: mp+184889@code.launchpad.net
To post a comment you must log in.
lp:~darkxst/ubiquity/update_bg updated
5991. By Tim Lunn

* disable g-s-d background plugin for Ubuntu GNOME
* set gsettings keys before launch g-s-d, helps with clunky transitions

5992. By Tim Lunn

Don't set num-workspaces as this carries through the live session

5993. By Tim Lunn

fix version in changelog

5994. By Tim Lunn

clean up formatting a little

Revision history for this message
Tim Lunn (darkxst) wrote :

This adds some final tweaks for the ubiquity-dm settings under Ubuntu GNOME.

- Update background image to the new default image.
- Don't load the g-s-d background plugin, this was making a mess of the transitions between plymouth -> ubiquity-dm -> Live session. Gnome-shell does not use this plugin, but its still getting loaded since XDG_CURRENT_DESKTOP is not set here.
- don't set num-workspaces, we run a restrictive gnome-shell in ubiquity-dm so this setting does nothing here, all it does is carries over to the live session and disables workspaces in there.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/ubiquity-dm'
--- bin/ubiquity-dm 2013-08-29 00:23:26 +0000
+++ bin/ubiquity-dm 2013-09-10 23:46:43 +0000
@@ -310,7 +310,7 @@
310 'lubuntu-default-wallpaper.png',310 'lubuntu-default-wallpaper.png',
311 '/usr/share/backgrounds/ubuntukylin-default-settings.jpg',311 '/usr/share/backgrounds/ubuntukylin-default-settings.jpg',
312 '/usr/share/backgrounds/warty-final-ubuntu.png',312 '/usr/share/backgrounds/warty-final-ubuntu.png',
313 '/usr/share/themes/Adwaita/backgrounds/adwaita-timed.xml'):313 '/usr/share/backgrounds/gnome/FootFall.png'):
314 exists = os.access(background, os.R_OK)314 exists = os.access(background, os.R_OK)
315 if exists:315 if exists:
316 background_image = background316 background_image = background
@@ -356,6 +356,20 @@
356 '1'),356 '1'),
357 ]357 ]
358358
359 if osextras.find_on_path('gnome-shell'):
360 gsettings_keys.append(
361 ('org.gnome.settings-daemon.plugins.background',
362 'active', 'false'))
363 gsettings_keys.remove(
364 ('org.gnome.desktop.wm.preferences', 'num-workspaces',
365 '1'))
366
367 for gs_schema, gs_key, gs_value in gsettings_keys:
368 subprocess.call(
369 ['gsettings', 'set', gs_schema, gs_key, gs_value],
370 stdin=null, stdout=logfile, stderr=logfile,
371 preexec_fn=self.drop_privileges)
372
359 gsd = '/usr/lib/gnome-settings-daemon/gnome-settings-daemon'373 gsd = '/usr/lib/gnome-settings-daemon/gnome-settings-daemon'
360 if osextras.find_on_path(gsd):374 if osextras.find_on_path(gsd):
361 extras.append(subprocess.Popen(375 extras.append(subprocess.Popen(
@@ -368,12 +382,6 @@
368 stdin=null, stdout=logfile, stderr=logfile,382 stdin=null, stdout=logfile, stderr=logfile,
369 preexec_fn=self.drop_privileges)383 preexec_fn=self.drop_privileges)
370384
371 for gs_schema, gs_key, gs_value in gsettings_keys:
372 subprocess.call(
373 ['gsettings', 'set', gs_schema, gs_key, gs_value],
374 stdin=null, stdout=logfile, stderr=logfile,
375 preexec_fn=self.drop_privileges)
376
377 # Accessibility infrastructure385 # Accessibility infrastructure
378 with open('/proc/cmdline', 'r') as fp:386 with open('/proc/cmdline', 'r') as fp:
379 if (accessibility or 'maybe-ubiquity' in fp.readline() or387 if (accessibility or 'maybe-ubiquity' in fp.readline() or
380388
=== modified file 'debian/changelog'
--- debian/changelog 2013-09-03 18:54:41 +0000
+++ debian/changelog 2013-09-10 23:46:43 +0000
@@ -4,7 +4,13 @@
4 * Split ubuntuone page into a separate package and seed/unseed it as4 * Split ubuntuone page into a separate package and seed/unseed it as
5 appropriate. (LP: #1218175)5 appropriate. (LP: #1218175)
66
7 -- Dmitrijs Ledkovs <dmitrij.ledkov@ubuntu.com> Tue, 03 Sep 2013 19:29:14 +01007 [ Tim Lunn ]
8 * Update default Ubuntu GNOME Background
9 * disable g-s-d background plugin for Ubuntu GNOME
10 * set gsettings keys before launch g-s-d, helps with clunky transitions
11 * Don't set num-workspaces as this carries through the live session
12
13 -- Tim Lunn <tim@feathertop.org> Wed, 11 Sep 2013 09:34:43 +1000
814
9ubiquity (2.15.16) saucy; urgency=low15ubiquity (2.15.16) saucy; urgency=low
1016

Subscribers

People subscribed via source and target branches

to status/vote changes: