Merge lp:~darkxst/ubiquity/update_bg into lp:ubiquity

Proposed by Tim Lunn
Status: Merged
Merged at revision: 5992
Proposed branch: lp:~darkxst/ubiquity/update_bg
Merge into: lp:ubiquity
Diff against target: 64 lines (+22/-8)
2 files modified
bin/ubiquity-dm (+15/-7)
debian/changelog (+7/-1)
To merge this branch: bzr merge lp:~darkxst/ubiquity/update_bg
Reviewer Review Type Date Requested Status
Ubuntu Installer Team Pending
Review via email: mp+184889@code.launchpad.net
To post a comment you must log in.
lp:~darkxst/ubiquity/update_bg updated
5991. By Tim Lunn

* disable g-s-d background plugin for Ubuntu GNOME
* set gsettings keys before launch g-s-d, helps with clunky transitions

5992. By Tim Lunn

Don't set num-workspaces as this carries through the live session

5993. By Tim Lunn

fix version in changelog

5994. By Tim Lunn

clean up formatting a little

Revision history for this message
Tim Lunn (darkxst) wrote :

This adds some final tweaks for the ubiquity-dm settings under Ubuntu GNOME.

- Update background image to the new default image.
- Don't load the g-s-d background plugin, this was making a mess of the transitions between plymouth -> ubiquity-dm -> Live session. Gnome-shell does not use this plugin, but its still getting loaded since XDG_CURRENT_DESKTOP is not set here.
- don't set num-workspaces, we run a restrictive gnome-shell in ubiquity-dm so this setting does nothing here, all it does is carries over to the live session and disables workspaces in there.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/ubiquity-dm'
2--- bin/ubiquity-dm 2013-08-29 00:23:26 +0000
3+++ bin/ubiquity-dm 2013-09-10 23:46:43 +0000
4@@ -310,7 +310,7 @@
5 'lubuntu-default-wallpaper.png',
6 '/usr/share/backgrounds/ubuntukylin-default-settings.jpg',
7 '/usr/share/backgrounds/warty-final-ubuntu.png',
8- '/usr/share/themes/Adwaita/backgrounds/adwaita-timed.xml'):
9+ '/usr/share/backgrounds/gnome/FootFall.png'):
10 exists = os.access(background, os.R_OK)
11 if exists:
12 background_image = background
13@@ -356,6 +356,20 @@
14 '1'),
15 ]
16
17+ if osextras.find_on_path('gnome-shell'):
18+ gsettings_keys.append(
19+ ('org.gnome.settings-daemon.plugins.background',
20+ 'active', 'false'))
21+ gsettings_keys.remove(
22+ ('org.gnome.desktop.wm.preferences', 'num-workspaces',
23+ '1'))
24+
25+ for gs_schema, gs_key, gs_value in gsettings_keys:
26+ subprocess.call(
27+ ['gsettings', 'set', gs_schema, gs_key, gs_value],
28+ stdin=null, stdout=logfile, stderr=logfile,
29+ preexec_fn=self.drop_privileges)
30+
31 gsd = '/usr/lib/gnome-settings-daemon/gnome-settings-daemon'
32 if osextras.find_on_path(gsd):
33 extras.append(subprocess.Popen(
34@@ -368,12 +382,6 @@
35 stdin=null, stdout=logfile, stderr=logfile,
36 preexec_fn=self.drop_privileges)
37
38- for gs_schema, gs_key, gs_value in gsettings_keys:
39- subprocess.call(
40- ['gsettings', 'set', gs_schema, gs_key, gs_value],
41- stdin=null, stdout=logfile, stderr=logfile,
42- preexec_fn=self.drop_privileges)
43-
44 # Accessibility infrastructure
45 with open('/proc/cmdline', 'r') as fp:
46 if (accessibility or 'maybe-ubiquity' in fp.readline() or
47
48=== modified file 'debian/changelog'
49--- debian/changelog 2013-09-03 18:54:41 +0000
50+++ debian/changelog 2013-09-10 23:46:43 +0000
51@@ -4,7 +4,13 @@
52 * Split ubuntuone page into a separate package and seed/unseed it as
53 appropriate. (LP: #1218175)
54
55- -- Dmitrijs Ledkovs <dmitrij.ledkov@ubuntu.com> Tue, 03 Sep 2013 19:29:14 +0100
56+ [ Tim Lunn ]
57+ * Update default Ubuntu GNOME Background
58+ * disable g-s-d background plugin for Ubuntu GNOME
59+ * set gsettings keys before launch g-s-d, helps with clunky transitions
60+ * Don't set num-workspaces as this carries through the live session
61+
62+ -- Tim Lunn <tim@feathertop.org> Wed, 11 Sep 2013 09:34:43 +1000
63
64 ubiquity (2.15.16) saucy; urgency=low
65

Subscribers

People subscribed via source and target branches

to status/vote changes: