Merge lp:~darkxst/ubiquity/lp1204312 into lp:ubiquity

Proposed by Tim Lunn
Status: Merged
Merged at revision: 5979
Proposed branch: lp:~darkxst/ubiquity/lp1204312
Merge into: lp:ubiquity
Diff against target: 111 lines (+32/-5)
5 files modified
bin/ubiquity-dm (+10/-4)
data/Makefile.am (+4/-1)
data/ubiquity.json (+9/-0)
debian/changelog (+8/-0)
debian/ubiquity-frontend-gtk.install (+1/-0)
To merge this branch: bzr merge lp:~darkxst/ubiquity/lp1204312
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Pending
Review via email: mp+182274@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Tim Lunn (darkxst) wrote :

hardcoding XDG_SESSION_ID allows network indicator and gnome-shell to work. wireless panel works under gnome-shell, but not metacity/nm-applet where it still gets the same permission crash.

Revision history for this message
Tim Lunn (darkxst) wrote :

actually wireless panel works on first boot, can connect to wifi when using metacity/nm-applet. However on second boot where wifi is configured (using a persistant USB) ubiquity crashes with the permission denied dbus error.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/ubiquity-dm'
--- bin/ubiquity-dm 2013-08-01 19:56:12 +0000
+++ bin/ubiquity-dm 2013-08-27 06:38:24 +0000
@@ -258,6 +258,7 @@
258258
259 os.environ['DISPLAY'] = self.display259 os.environ['DISPLAY'] = self.display
260 os.environ['HOME'] = self.homedir260 os.environ['HOME'] = self.homedir
261 os.environ['XDG_SESSION_ID'] = 'c1'
261 # Give ubiquity a UID and GID that it can drop privileges to.262 # Give ubiquity a UID and GID that it can drop privileges to.
262 os.environ['PKEXEC_UID'] = str(self.uid)263 os.environ['PKEXEC_UID'] = str(self.uid)
263 os.environ['GVFS_DISABLE_FUSE'] = '1'264 os.environ['GVFS_DISABLE_FUSE'] = '1'
@@ -308,7 +309,8 @@
308 '/usr/share/lubuntu/wallpapers/'309 '/usr/share/lubuntu/wallpapers/'
309 'lubuntu-default-wallpaper.png',310 'lubuntu-default-wallpaper.png',
310 '/usr/share/backgrounds/ubuntukylin-default-settings.jpg',311 '/usr/share/backgrounds/ubuntukylin-default-settings.jpg',
311 '/usr/share/backgrounds/warty-final-ubuntu.png'):312 '/usr/share/backgrounds/warty-final-ubuntu.png',
313 '/usr/share/themes/Adwaita/backgrounds/adwaita-timed.xml'):
312 exists = os.access(background, os.R_OK)314 exists = os.access(background, os.R_OK)
313 if exists:315 if exists:
314 background_image = background316 background_image = background
@@ -385,7 +387,9 @@
385 preexec_fn=self.drop_privileges))387 preexec_fn=self.drop_privileges))
386 os.environ['GTK_MODULES'] += os.pathsep + 'gail'388 os.environ['GTK_MODULES'] += os.pathsep + 'gail'
387389
388 if osextras.find_on_path('metacity'):390 if osextras.find_on_path('gnome-shell'):
391 wm_cmd = ['gnome-shell', '--sm-disable', '--mode=ubiquity']
392 elif osextras.find_on_path('metacity'):
389 wm_cmd = ['metacity', '--sm-disable']393 wm_cmd = ['metacity', '--sm-disable']
390 elif osextras.find_on_path('xfwm4'):394 elif osextras.find_on_path('xfwm4'):
391 wm_cmd = ['xfwm4', '--compositor=off']395 wm_cmd = ['xfwm4', '--compositor=off']
@@ -426,13 +430,15 @@
426430
427 if (os.path.exists('/usr/lib/ubiquity/panel') and431 if (os.path.exists('/usr/lib/ubiquity/panel') and
428 "xfwm4" not in wm_cmd):432 "xfwm4" not in wm_cmd):
429 if "openbox-lubuntu" not in wm_cmd and "openbox" not in wm_cmd:433 if ("openbox-lubuntu" not in wm_cmd and
434 "openbox" not in wm_cmd and
435 "gnome-shell" not in wm_cmd):
430 extras.append(subprocess.Popen(436 extras.append(subprocess.Popen(
431 ['/usr/lib/ubiquity/panel'],437 ['/usr/lib/ubiquity/panel'],
432 stdin=null, stdout=logfile, stderr=logfile,438 stdin=null, stdout=logfile, stderr=logfile,
433 preexec_fn=self.drop_privileges))439 preexec_fn=self.drop_privileges))
434440
435 if osextras.find_on_path('nm-applet'):441 if osextras.find_on_path('nm-applet') and "gnome-shell" not in wm_cmd:
436 extras.append(subprocess.Popen(442 extras.append(subprocess.Popen(
437 ['nm-applet'],443 ['nm-applet'],
438 stdin=null, stdout=logfile, stderr=logfile,444 stdin=null, stdout=logfile, stderr=logfile,
439445
=== modified file 'data/Makefile.am'
--- data/Makefile.am 2013-08-01 19:03:23 +0000
+++ data/Makefile.am 2013-08-27 06:38:24 +0000
@@ -2,6 +2,9 @@
22
3@INTLTOOL_DESKTOP_RULE@3@INTLTOOL_DESKTOP_RULE@
44
5modedir = $(datadir)/gnome-shell/modes
6mode_DATA = ubiquity.json
7
5desktopdir = $(datadir)/applications8desktopdir = $(datadir)/applications
6desktop_DATA = $(desktop_in_files:.desktop.in=.desktop)9desktop_DATA = $(desktop_in_files:.desktop.in=.desktop)
7desktop_in_files = \10desktop_in_files = \
@@ -16,6 +19,6 @@
16polkit_policy_in_files = com.ubuntu.ubiquity.policy.in19polkit_policy_in_files = com.ubuntu.ubiquity.policy.in
17polkit_policy_DATA = $(polkit_policy_in_files:.policy.in=.policy)20polkit_policy_DATA = $(polkit_policy_in_files:.policy.in=.policy)
1821
19EXTRA_DIST = $(desktop_in_files) $(polkit_policy_in_files)22EXTRA_DIST = $(desktop_in_files) $(polkit_policy_in_files) ubiquity.json
2023
21CLEANFILES = $(desktop_DATA)24CLEANFILES = $(desktop_DATA)
2225
=== added file 'data/ubiquity.json'
--- data/ubiquity.json 1970-01-01 00:00:00 +0000
+++ data/ubiquity.json 2013-08-27 06:38:24 +0000
@@ -0,0 +1,9 @@
1{
2 "hasWindows": true,
3 "components": ["polkitAgent", "networkAgent"],
4 "panel": { "left": [],
5 "center": [],
6 "right": ["a11yGreeter", "keyboard", "volume", "network","battery", "powerMenu"]
7 }
8}
9
010
=== modified file 'debian/changelog'
--- debian/changelog 2013-08-21 17:54:52 +0000
+++ debian/changelog 2013-08-27 06:38:24 +0000
@@ -1,3 +1,11 @@
1ubiquity (2.15.15) UNRELEASED; urgency=low
2
3 * Add Ubuntu GNOME background to ubiquity-dm (LP: #1204312)
4 * Use gnome-shell as wm in ubiquity-dm on Ubuntu GNOME (LP: #1214732)
5 * export XDG_SESSION_ID to provide access to hijacked logind session
6
7 -- Tim Lunn <tim@feathertop.org> Tue, 27 Aug 2013 10:24:37 +1000
8
1ubiquity (2.15.14) saucy; urgency=low9ubiquity (2.15.14) saucy; urgency=low
210
3 * Port autopilot tests to updated API for retrieving application proxy11 * Port autopilot tests to updated API for retrieving application proxy
412
=== modified file 'debian/ubiquity-frontend-gtk.install'
--- debian/ubiquity-frontend-gtk.install 2013-08-01 19:03:23 +0000
+++ debian/ubiquity-frontend-gtk.install 2013-08-27 06:38:24 +0000
@@ -16,3 +16,4 @@
16usr/lib/ubiquity16usr/lib/ubiquity
17usr/share/gir-1.0/*.gir17usr/share/gir-1.0/*.gir
18usr/share/icons/hicolor/*/apps/ubiquity.svg18usr/share/icons/hicolor/*/apps/ubiquity.svg
19usr/share/gnome-shell

Subscribers

People subscribed via source and target branches

to status/vote changes: