Merge lp:~darkxst/ubiquity/lp1204312 into lp:ubiquity

Proposed by Tim Lunn
Status: Merged
Merged at revision: 5979
Proposed branch: lp:~darkxst/ubiquity/lp1204312
Merge into: lp:ubiquity
Diff against target: 111 lines (+32/-5)
5 files modified
bin/ubiquity-dm (+10/-4)
data/Makefile.am (+4/-1)
data/ubiquity.json (+9/-0)
debian/changelog (+8/-0)
debian/ubiquity-frontend-gtk.install (+1/-0)
To merge this branch: bzr merge lp:~darkxst/ubiquity/lp1204312
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Pending
Review via email: mp+182274@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Tim Lunn (darkxst) wrote :

hardcoding XDG_SESSION_ID allows network indicator and gnome-shell to work. wireless panel works under gnome-shell, but not metacity/nm-applet where it still gets the same permission crash.

Revision history for this message
Tim Lunn (darkxst) wrote :

actually wireless panel works on first boot, can connect to wifi when using metacity/nm-applet. However on second boot where wifi is configured (using a persistant USB) ubiquity crashes with the permission denied dbus error.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/ubiquity-dm'
2--- bin/ubiquity-dm 2013-08-01 19:56:12 +0000
3+++ bin/ubiquity-dm 2013-08-27 06:38:24 +0000
4@@ -258,6 +258,7 @@
5
6 os.environ['DISPLAY'] = self.display
7 os.environ['HOME'] = self.homedir
8+ os.environ['XDG_SESSION_ID'] = 'c1'
9 # Give ubiquity a UID and GID that it can drop privileges to.
10 os.environ['PKEXEC_UID'] = str(self.uid)
11 os.environ['GVFS_DISABLE_FUSE'] = '1'
12@@ -308,7 +309,8 @@
13 '/usr/share/lubuntu/wallpapers/'
14 'lubuntu-default-wallpaper.png',
15 '/usr/share/backgrounds/ubuntukylin-default-settings.jpg',
16- '/usr/share/backgrounds/warty-final-ubuntu.png'):
17+ '/usr/share/backgrounds/warty-final-ubuntu.png',
18+ '/usr/share/themes/Adwaita/backgrounds/adwaita-timed.xml'):
19 exists = os.access(background, os.R_OK)
20 if exists:
21 background_image = background
22@@ -385,7 +387,9 @@
23 preexec_fn=self.drop_privileges))
24 os.environ['GTK_MODULES'] += os.pathsep + 'gail'
25
26- if osextras.find_on_path('metacity'):
27+ if osextras.find_on_path('gnome-shell'):
28+ wm_cmd = ['gnome-shell', '--sm-disable', '--mode=ubiquity']
29+ elif osextras.find_on_path('metacity'):
30 wm_cmd = ['metacity', '--sm-disable']
31 elif osextras.find_on_path('xfwm4'):
32 wm_cmd = ['xfwm4', '--compositor=off']
33@@ -426,13 +430,15 @@
34
35 if (os.path.exists('/usr/lib/ubiquity/panel') and
36 "xfwm4" not in wm_cmd):
37- if "openbox-lubuntu" not in wm_cmd and "openbox" not in wm_cmd:
38+ if ("openbox-lubuntu" not in wm_cmd and
39+ "openbox" not in wm_cmd and
40+ "gnome-shell" not in wm_cmd):
41 extras.append(subprocess.Popen(
42 ['/usr/lib/ubiquity/panel'],
43 stdin=null, stdout=logfile, stderr=logfile,
44 preexec_fn=self.drop_privileges))
45
46- if osextras.find_on_path('nm-applet'):
47+ if osextras.find_on_path('nm-applet') and "gnome-shell" not in wm_cmd:
48 extras.append(subprocess.Popen(
49 ['nm-applet'],
50 stdin=null, stdout=logfile, stderr=logfile,
51
52=== modified file 'data/Makefile.am'
53--- data/Makefile.am 2013-08-01 19:03:23 +0000
54+++ data/Makefile.am 2013-08-27 06:38:24 +0000
55@@ -2,6 +2,9 @@
56
57 @INTLTOOL_DESKTOP_RULE@
58
59+modedir = $(datadir)/gnome-shell/modes
60+mode_DATA = ubiquity.json
61+
62 desktopdir = $(datadir)/applications
63 desktop_DATA = $(desktop_in_files:.desktop.in=.desktop)
64 desktop_in_files = \
65@@ -16,6 +19,6 @@
66 polkit_policy_in_files = com.ubuntu.ubiquity.policy.in
67 polkit_policy_DATA = $(polkit_policy_in_files:.policy.in=.policy)
68
69-EXTRA_DIST = $(desktop_in_files) $(polkit_policy_in_files)
70+EXTRA_DIST = $(desktop_in_files) $(polkit_policy_in_files) ubiquity.json
71
72 CLEANFILES = $(desktop_DATA)
73
74=== added file 'data/ubiquity.json'
75--- data/ubiquity.json 1970-01-01 00:00:00 +0000
76+++ data/ubiquity.json 2013-08-27 06:38:24 +0000
77@@ -0,0 +1,9 @@
78+{
79+ "hasWindows": true,
80+ "components": ["polkitAgent", "networkAgent"],
81+ "panel": { "left": [],
82+ "center": [],
83+ "right": ["a11yGreeter", "keyboard", "volume", "network","battery", "powerMenu"]
84+ }
85+}
86+
87
88=== modified file 'debian/changelog'
89--- debian/changelog 2013-08-21 17:54:52 +0000
90+++ debian/changelog 2013-08-27 06:38:24 +0000
91@@ -1,3 +1,11 @@
92+ubiquity (2.15.15) UNRELEASED; urgency=low
93+
94+ * Add Ubuntu GNOME background to ubiquity-dm (LP: #1204312)
95+ * Use gnome-shell as wm in ubiquity-dm on Ubuntu GNOME (LP: #1214732)
96+ * export XDG_SESSION_ID to provide access to hijacked logind session
97+
98+ -- Tim Lunn <tim@feathertop.org> Tue, 27 Aug 2013 10:24:37 +1000
99+
100 ubiquity (2.15.14) saucy; urgency=low
101
102 * Port autopilot tests to updated API for retrieving application proxy
103
104=== modified file 'debian/ubiquity-frontend-gtk.install'
105--- debian/ubiquity-frontend-gtk.install 2013-08-01 19:03:23 +0000
106+++ debian/ubiquity-frontend-gtk.install 2013-08-27 06:38:24 +0000
107@@ -16,3 +16,4 @@
108 usr/lib/ubiquity
109 usr/share/gir-1.0/*.gir
110 usr/share/icons/hicolor/*/apps/ubiquity.svg
111+usr/share/gnome-shell

Subscribers

People subscribed via source and target branches

to status/vote changes: