Merge lp:~darkxst/compiz/lp1481541 into lp:compiz/0.9.12

Proposed by Tim Lunn
Status: Superseded
Proposed branch: lp:~darkxst/compiz/lp1481541
Merge into: lp:compiz/0.9.12
Prerequisite: lp:~azzar1/compiz/gcc5
Diff against target: 33 lines (+0/-12)
2 files modified
debian/control (+0/-1)
gtk/CMakeLists.txt (+0/-11)
To merge this branch: bzr merge lp:~darkxst/compiz/lp1481541
Reviewer Review Type Date Requested Status
Stephen M. Webb Needs Fixing
Marco Trevisan (Treviño) Approve
Review via email: mp+266986@code.launchpad.net

This proposal supersedes a proposal from 2015-08-05.

This proposal has been superseded by a proposal from 2015-08-13.

Commit message

Remove unused code that causes a build-dep on gnome-control-center-dev (LP: #1481541)

Description of the change

This branch is based off lp:~azzar1/compiz/gcc5/

To post a comment you must log in.
lp:~darkxst/compiz/lp1481541 updated
3959. By Alberts Muktupāvels

Change icon size back to 48px in application switcher plugin. Fixes: #1237057
Approved by: Stephen M. Webb, Dmitry Shachnev

3960. By Stephen M. Webb

Fixed the Compiz manpage and --help message to agree with the actual command-line options supported. Fixes: #1475508
Approved by: PS Jenkins bot, Marco Trevisan (Treviño)

3961. By Stephen M. Webb

Fix a FTBFS when -std=c++11 is used. Fixes: #1477654
Approved by: PS Jenkins bot, Christopher Townsend

3962. By Stephen M. Webb

force Compiz to build using C++-11 (required by build dependency libgtkmm-3.0-1). Fixes: #1477978
Approved by: Christopher Townsend

3963. By Martin Wimpress 

align MATE profile more closely with Marco
Approved by: Stephen M. Webb

3964. By Eleni Maria Stea

It fixes the 3d windows plugin.
Problem:
The 3d clipping is performed in viewing space (modelview transformation) and should be done inside the shader when we use shaders otherwise the viewing space pipeline operations will be ignored. Compiz used to perform the clipping inside the td plugin using pipeline functions, then it was loading a generic shader program (no clipping operations) to render the windows and then it rendered the 3d quads around the windows using the pipeline (so these were clipped correctly).

Fix:
Added a variable that indicates when to load the shaders and when render using the fixed functions pipeline and use the fixed functions pipeline to render between glEnableOutputClipping and glDisableOutputClipping.

+small fix in the legacyRendering (pipeline) Fixes: #1395697
Approved by: PS Jenkins bot, Stephen M. Webb

3965. By Eleni Maria Stea

Sometimes the MultipleCubes, Automatic or OneBigCube option might be set although we are not in multimonitor. Modified the 3d windows plugin to check the number of monitors as well.
Approved by: PS Jenkins bot, Stephen M. Webb

3966. By Marco Trevisan (Treviño)

Window: compute the correct output using the absolute window position

Window geometry has absolute coordinates that include viewports, but we
need to use viewport relative coordinates when figuring out the window output
or the window will be considered offscreen and thus it will fallback to first monitor.
This is generally applied, but was not done well in addWindowSizeChanges which
was causing Fullscreen and (horizontally) maximized windows to be moved to the
primary monitor when activated. Fixes: #1475721
Approved by: Stephen M. Webb, PS Jenkins bot

3967. By Marco Trevisan (Treviño)

Window: add clientFrame(), to get the client-side decoration extents

This only supports GTK at the moment, but it might be adapted to other toolkits. Fixes: #1422768, #1436553
Approved by: MC Return, Christopher Townsend

3968. By Dmitry Shachnev

Move window switcher plugins to compiz-plugins-default. Fixes: #971051, #1465647
Approved by: Stephen M. Webb, Dmitry Shachnev

3969. By Dmitry Shachnev

debian/compiz-gnome.gsettings-override: Remove unityshell from active plugins, and add switcher. Fixes: #1469086
Approved by: Alberts Muktupāvels, Stephen M. Webb

3970. By CI Train Bot Account

Releasing 1:0.9.12.1+15.10.20150805-0ubuntu1

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

+1

review: Approve
Revision history for this message
Stephen M. Webb (bregma) wrote :

I'd just like to point out that this MP has a prerequisite of another MP that has not been approved will probably not merge successfully.

Revision history for this message
Stephen M. Webb (bregma) wrote :

Indeed, there are merge conflicts.

You need to resubmit this MP based on the current Compiz trunk instead.

review: Needs Fixing
lp:~darkxst/compiz/lp1481541 updated
3971. By Tim Lunn

Remove unused code, that causes a build-dep on gnome-control-center-dev

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2015-08-05 11:26:37 +0000
3+++ debian/control 2015-08-13 22:52:32 +0000
4@@ -53,7 +53,6 @@
5 protobuf-compiler,
6 python-all-dev,
7 python-pyrex,
8- gnome-control-center-dev,
9 gsettings-desktop-schemas-dev,
10 xserver-xorg-dev (>= 0.7.0),
11 Standards-Version: 3.9.6
12
13=== modified file 'gtk/CMakeLists.txt'
14--- gtk/CMakeLists.txt 2015-06-12 18:43:05 +0000
15+++ gtk/CMakeLists.txt 2015-08-13 22:52:32 +0000
16@@ -52,17 +52,6 @@
17 endif (GNOME_WINDOW_SETTINGS_FOUND)
18 endif (USE_GNOME)
19
20- if (USE_GNOME_KEYBINDINGS)
21- compiz_pkg_check_modules (GNOME_KEY_BINDINGS gnome-keybindings)
22- if (GNOME_KEY_BINDINGS_FOUND)
23- exec_program (${PKG_CONFIG_EXECUTABLE}
24- ARGS "--variable=keysdir gnome-keybindings"
25- OUTPUT_VARIABLE keybindingsdir
26- )
27- else (GNOME_KEY_BINDINGS_FOUND)
28- compiz_set (USE_GNOME_KEYBINDINGS 0)
29- endif (GNOME_KEY_BINDINGS_FOUND)
30- endif (USE_GNOME_KEYBINDINGS)
31 else (GTK_WINDOW_DECORATOR_FOUND)
32 compiz_set (USE_GTK 0)
33 endif (GTK_WINDOW_DECORATOR_FOUND)

Subscribers

People subscribed via source and target branches