Merge lp:~darkxst/compiz/lp1481541 into lp:compiz/0.9.12

Proposed by Tim Lunn
Status: Merged
Approved by: Stephen M. Webb
Approved revision: 3971
Merged at revision: 3974
Proposed branch: lp:~darkxst/compiz/lp1481541
Merge into: lp:compiz/0.9.12
Diff against target: 33 lines (+0/-12)
2 files modified
debian/control (+0/-1)
gtk/CMakeLists.txt (+0/-11)
To merge this branch: bzr merge lp:~darkxst/compiz/lp1481541
Reviewer Review Type Date Requested Status
Stephen M. Webb Approve
Marco Trevisan (Treviño) Pending
Review via email: mp+268015@code.launchpad.net

This proposal supersedes a proposal from 2015-08-05.

Commit message

Remove unused code that causes a build-dep on gnome-control-center-dev (LP: #1481541)

Description of the change

This branch is based off lp:~azzar1/compiz/gcc5/

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote : Posted in a previous version of this proposal

+1

review: Approve
Revision history for this message
Stephen M. Webb (bregma) wrote : Posted in a previous version of this proposal

I'd just like to point out that this MP has a prerequisite of another MP that has not been approved will probably not merge successfully.

Revision history for this message
Stephen M. Webb (bregma) wrote : Posted in a previous version of this proposal

Indeed, there are merge conflicts.

You need to resubmit this MP based on the current Compiz trunk instead.

review: Needs Fixing
Revision history for this message
Tim Lunn (darkxst) wrote :

trunk was FTBFS with gcc5 when I prepared the patched, have rebased now on trunk

Revision history for this message
Stephen M. Webb (bregma) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2015-08-05 11:26:37 +0000
3+++ debian/control 2015-08-13 22:53:48 +0000
4@@ -53,7 +53,6 @@
5 protobuf-compiler,
6 python-all-dev,
7 python-pyrex,
8- gnome-control-center-dev,
9 gsettings-desktop-schemas-dev,
10 xserver-xorg-dev (>= 0.7.0),
11 Standards-Version: 3.9.6
12
13=== modified file 'gtk/CMakeLists.txt'
14--- gtk/CMakeLists.txt 2015-06-12 18:43:05 +0000
15+++ gtk/CMakeLists.txt 2015-08-13 22:53:48 +0000
16@@ -52,17 +52,6 @@
17 endif (GNOME_WINDOW_SETTINGS_FOUND)
18 endif (USE_GNOME)
19
20- if (USE_GNOME_KEYBINDINGS)
21- compiz_pkg_check_modules (GNOME_KEY_BINDINGS gnome-keybindings)
22- if (GNOME_KEY_BINDINGS_FOUND)
23- exec_program (${PKG_CONFIG_EXECUTABLE}
24- ARGS "--variable=keysdir gnome-keybindings"
25- OUTPUT_VARIABLE keybindingsdir
26- )
27- else (GNOME_KEY_BINDINGS_FOUND)
28- compiz_set (USE_GNOME_KEYBINDINGS 0)
29- endif (GNOME_KEY_BINDINGS_FOUND)
30- endif (USE_GNOME_KEYBINDINGS)
31 else (GTK_WINDOW_DECORATOR_FOUND)
32 compiz_set (USE_GTK 0)
33 endif (GTK_WINDOW_DECORATOR_FOUND)

Subscribers

People subscribed via source and target branches