Merge lp:~darkxst/compiz/lp1481541 into lp:compiz/0.9.12

Proposed by Tim Lunn
Status: Superseded
Proposed branch: lp:~darkxst/compiz/lp1481541
Merge into: lp:compiz/0.9.12
Diff against target: 227 lines (+14/-32)
15 files modified
cmake/CompizCommon.cmake (+3/-7)
compizconfig/CMakeLists.txt (+0/-2)
compizconfig/gsettings/mocks/CMakeLists.txt (+1/-1)
compizconfig/gsettings/tests/CMakeLists.txt (+1/-1)
compizconfig/integration/gnome/gsettings/tests/CMakeLists.txt (+1/-1)
compizconfig/integration/gnome/tests/CMakeLists.txt (+1/-1)
compizconfig/integration/mate/gsettings/tests/CMakeLists.txt (+1/-1)
compizconfig/integration/mate/tests/CMakeLists.txt (+1/-1)
compizconfig/libcompizconfig/tests/CMakeLists.txt (+1/-1)
debian/control (+0/-1)
gtk/CMakeLists.txt (+0/-11)
plugins/decor/src/decor.cpp (+1/-1)
plugins/opengl/src/programcache.cpp (+1/-1)
plugins/splash/src/splash.cpp (+1/-1)
src/privatescreen/tests/test-privatescreen.cpp (+1/-1)
To merge this branch: bzr merge lp:~darkxst/compiz/lp1481541
Reviewer Review Type Date Requested Status
Compiz Maintainers Pending
Review via email: mp+266985@code.launchpad.net

This proposal has been superseded by a proposal from 2015-08-05.

Commit message

Remove unused code that causes a build-dep on gnome-control-center-dev (LP: #1481541)

Description of the change

This branch is based off lp:~azzar1/compiz/gcc5/

To post a comment you must log in.
lp:~darkxst/compiz/lp1481541 updated
3959. By Alberts Muktupāvels

Change icon size back to 48px in application switcher plugin. Fixes: #1237057
Approved by: Stephen M. Webb, Dmitry Shachnev

3960. By Stephen M. Webb

Fixed the Compiz manpage and --help message to agree with the actual command-line options supported. Fixes: #1475508
Approved by: PS Jenkins bot, Marco Trevisan (Treviño)

3961. By Stephen M. Webb

Fix a FTBFS when -std=c++11 is used. Fixes: #1477654
Approved by: PS Jenkins bot, Christopher Townsend

3962. By Stephen M. Webb

force Compiz to build using C++-11 (required by build dependency libgtkmm-3.0-1). Fixes: #1477978
Approved by: Christopher Townsend

3963. By Martin Wimpress 

align MATE profile more closely with Marco
Approved by: Stephen M. Webb

3964. By Eleni Maria Stea

It fixes the 3d windows plugin.
Problem:
The 3d clipping is performed in viewing space (modelview transformation) and should be done inside the shader when we use shaders otherwise the viewing space pipeline operations will be ignored. Compiz used to perform the clipping inside the td plugin using pipeline functions, then it was loading a generic shader program (no clipping operations) to render the windows and then it rendered the 3d quads around the windows using the pipeline (so these were clipped correctly).

Fix:
Added a variable that indicates when to load the shaders and when render using the fixed functions pipeline and use the fixed functions pipeline to render between glEnableOutputClipping and glDisableOutputClipping.

+small fix in the legacyRendering (pipeline) Fixes: #1395697
Approved by: PS Jenkins bot, Stephen M. Webb

3965. By Eleni Maria Stea

Sometimes the MultipleCubes, Automatic or OneBigCube option might be set although we are not in multimonitor. Modified the 3d windows plugin to check the number of monitors as well.
Approved by: PS Jenkins bot, Stephen M. Webb

3966. By Marco Trevisan (Treviño)

Window: compute the correct output using the absolute window position

Window geometry has absolute coordinates that include viewports, but we
need to use viewport relative coordinates when figuring out the window output
or the window will be considered offscreen and thus it will fallback to first monitor.
This is generally applied, but was not done well in addWindowSizeChanges which
was causing Fullscreen and (horizontally) maximized windows to be moved to the
primary monitor when activated. Fixes: #1475721
Approved by: Stephen M. Webb, PS Jenkins bot

3967. By Marco Trevisan (Treviño)

Window: add clientFrame(), to get the client-side decoration extents

This only supports GTK at the moment, but it might be adapted to other toolkits. Fixes: #1422768, #1436553
Approved by: MC Return, Christopher Townsend

3968. By Dmitry Shachnev

Move window switcher plugins to compiz-plugins-default. Fixes: #971051, #1465647
Approved by: Stephen M. Webb, Dmitry Shachnev

3969. By Dmitry Shachnev

debian/compiz-gnome.gsettings-override: Remove unityshell from active plugins, and add switcher. Fixes: #1469086
Approved by: Alberts Muktupāvels, Stephen M. Webb

3970. By CI Train Bot Account

Releasing 1:0.9.12.1+15.10.20150805-0ubuntu1

3971. By Tim Lunn

Remove unused code, that causes a build-dep on gnome-control-center-dev

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmake/CompizCommon.cmake'
2--- cmake/CompizCommon.cmake 2014-11-04 15:54:44 +0000
3+++ cmake/CompizCommon.cmake 2015-08-05 01:35:01 +0000
4@@ -17,6 +17,8 @@
5 cmake_policy (SET CMP0003 NEW)
6 cmake_policy (SET CMP0005 OLD)
7 cmake_policy (SET CMP0011 OLD)
8+cmake_policy (SET CMP0022 OLD)
9+
10
11 set (CMAKE_SKIP_RPATH FALSE)
12
13@@ -51,11 +53,6 @@
14 # Almost everything is a shared library now, so almost everything needs -fPIC
15 set (COMMON_FLAGS "-fPIC -Wall")
16
17-option (COMPIZ_UNUSED_PRIVATE_FIELD_WARNINGS "Warn unused private fields" OFF)
18-if (NOT COMPIZ_UNUSED_PRIVATE_FIELD_WARNINGS)
19- set (COMMON_FLAGS "${COMMON_FLAGS} -Wno-unused-private-field")
20-endif ()
21-
22 option (COMPIZ_UNUSED_LOCAL_TYPEDEFS_WARNINGS "Warn about unused local typedefs" OFF)
23 if (NOT COMPIZ_UNUSED_LOCAL_TYPEDEFS_WARNINGS)
24 set (COMMON_FLAGS "${COMMON_FLAGS} -Wno-unused-local-typedefs")
25@@ -82,7 +79,7 @@
26 endif ()
27
28 set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${COMMON_FLAGS}")
29-set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${COMMON_FLAGS}")
30+set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${COMMON_FLAGS} -std=c++11")
31
32 set (COMMON_LINKER_FLAGS "-Wl,-zdefs")
33 set (CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} ${COMMON_LINKER_FLAGS}")
34@@ -381,7 +378,6 @@
35 add_custom_target (release-upload-component)
36 add_custom_target (release-upload)
37
38- add_dependencies (release-upload-component release-upload-version)
39 add_dependencies (release-upload release-upload-component)
40
41 endmacro ()
42
43=== modified file 'compizconfig/CMakeLists.txt'
44--- compizconfig/CMakeLists.txt 2014-11-25 13:15:56 +0000
45+++ compizconfig/CMakeLists.txt 2015-08-05 01:35:01 +0000
46@@ -37,5 +37,3 @@
47 endif (COMPIZ_BUILD_TESTING)
48
49 add_custom_target (pyclean)
50-
51-add_dependencies (pyclean pyclean_ccsm pyclean_compizconfig)
52
53=== modified file 'compizconfig/gsettings/mocks/CMakeLists.txt'
54--- compizconfig/gsettings/mocks/CMakeLists.txt 2012-10-08 13:50:56 +0000
55+++ compizconfig/gsettings/mocks/CMakeLists.txt 2015-08-05 01:35:01 +0000
56@@ -8,7 +8,7 @@
57 ${CMAKE_CURRENT_SOURCE_DIR}/../gsettings_backend_shared
58 ${GLIB_INCLUDE_DIRS})
59
60- set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x")
61+ set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
62
63 add_library (compizconfig_ccs_gsettings_wrapper_mock STATIC
64 ${CMAKE_CURRENT_SOURCE_DIR}/ccs_gsettings_wrapper_mock.cpp
65
66=== modified file 'compizconfig/gsettings/tests/CMakeLists.txt'
67--- compizconfig/gsettings/tests/CMakeLists.txt 2013-07-17 06:06:08 +0000
68+++ compizconfig/gsettings/tests/CMakeLists.txt 2015-08-05 01:35:01 +0000
69@@ -17,7 +17,7 @@
70
71 if (COMPIZCONFIG_TEST_GSETTINGS_FOUND)
72
73- set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x")
74+ set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
75
76 link_directories (${CMAKE_CURRENT_BINARY_DIR}/../../libcompizconfig/tests)
77 link_directories (${CMAKE_CURRENT_BINARY_DIR}/../testenvironments)
78
79=== modified file 'compizconfig/integration/gnome/gsettings/tests/CMakeLists.txt'
80--- compizconfig/integration/gnome/gsettings/tests/CMakeLists.txt 2013-05-13 13:41:19 +0000
81+++ compizconfig/integration/gnome/gsettings/tests/CMakeLists.txt 2015-08-05 01:35:01 +0000
82@@ -11,7 +11,7 @@
83 link_directories (${CMAKE_CURRENT_BINARY_DIR}/../../tests/)
84 link_directories (${CMAKE_CURRENT_BINARY_DIR}/../src/)
85
86-set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x")
87+set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
88
89 add_executable (compizconfig_test_ccs_gnome_gsettings_integrated_setting
90 ${CMAKE_CURRENT_SOURCE_DIR}/compizconfig_test_ccs_gnome_gsettings_integrated_setting.cpp)
91
92=== modified file 'compizconfig/integration/gnome/tests/CMakeLists.txt'
93--- compizconfig/integration/gnome/tests/CMakeLists.txt 2013-05-13 13:42:28 +0000
94+++ compizconfig/integration/gnome/tests/CMakeLists.txt 2015-08-05 01:35:01 +0000
95@@ -8,7 +8,7 @@
96 include_directories (${CMAKE_SOURCE_DIR}/compizconfig/tests)
97 link_directories (${CMAKE_INSTALL_PREFIX}/lib)
98
99-set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x")
100+set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
101
102 add_library (compizconfig_ccs_mock_gnome_integrated_setting_composition
103 ${CMAKE_CURRENT_SOURCE_DIR}/compizconfig_ccs_mock_gnome_integrated_setting_composition.c)
104
105=== modified file 'compizconfig/integration/mate/gsettings/tests/CMakeLists.txt'
106--- compizconfig/integration/mate/gsettings/tests/CMakeLists.txt 2015-02-04 22:20:18 +0000
107+++ compizconfig/integration/mate/gsettings/tests/CMakeLists.txt 2015-08-05 01:35:01 +0000
108@@ -11,7 +11,7 @@
109 link_directories (${CMAKE_CURRENT_BINARY_DIR}/../../tests/)
110 link_directories (${CMAKE_CURRENT_BINARY_DIR}/../src/)
111
112-set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x")
113+set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
114
115 add_executable (compizconfig_test_ccs_mate_gsettings_integrated_setting
116 ${CMAKE_CURRENT_SOURCE_DIR}/compizconfig_test_ccs_mate_gsettings_integrated_setting.cpp)
117
118=== modified file 'compizconfig/integration/mate/tests/CMakeLists.txt'
119--- compizconfig/integration/mate/tests/CMakeLists.txt 2015-02-04 22:20:18 +0000
120+++ compizconfig/integration/mate/tests/CMakeLists.txt 2015-08-05 01:35:01 +0000
121@@ -8,7 +8,7 @@
122 include_directories (${CMAKE_SOURCE_DIR}/compizconfig/tests)
123 link_directories (${CMAKE_INSTALL_PREFIX}/lib)
124
125-set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x")
126+set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
127
128 add_library (compizconfig_ccs_mock_mate_integrated_setting_composition
129 ${CMAKE_CURRENT_SOURCE_DIR}/compizconfig_ccs_mock_mate_integrated_setting_composition.c)
130
131=== modified file 'compizconfig/libcompizconfig/tests/CMakeLists.txt'
132--- compizconfig/libcompizconfig/tests/CMakeLists.txt 2013-07-17 06:06:08 +0000
133+++ compizconfig/libcompizconfig/tests/CMakeLists.txt 2015-08-05 01:35:01 +0000
134@@ -9,7 +9,7 @@
135 link_directories (${CMAKE_CURRENT_BINARY_DIR}/../../tests/)
136 link_directories (${CMAKE_CURRENT_BINARY_DIR}/../src/)
137
138-set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x")
139+set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
140
141 add_definitions (-DSYSCONFDIR=\\\"${COMPIZ_SYSCONFDIR}\\\")
142
143
144=== modified file 'debian/control'
145--- debian/control 2015-06-27 04:41:46 +0000
146+++ debian/control 2015-08-05 01:35:01 +0000
147@@ -53,7 +53,6 @@
148 protobuf-compiler,
149 python-all-dev,
150 python-pyrex,
151- gnome-control-center-dev,
152 gsettings-desktop-schemas-dev,
153 xserver-xorg-dev (>= 0.7.0),
154 Standards-Version: 3.9.6
155
156=== modified file 'gtk/CMakeLists.txt'
157--- gtk/CMakeLists.txt 2015-06-12 18:43:05 +0000
158+++ gtk/CMakeLists.txt 2015-08-05 01:35:01 +0000
159@@ -52,17 +52,6 @@
160 endif (GNOME_WINDOW_SETTINGS_FOUND)
161 endif (USE_GNOME)
162
163- if (USE_GNOME_KEYBINDINGS)
164- compiz_pkg_check_modules (GNOME_KEY_BINDINGS gnome-keybindings)
165- if (GNOME_KEY_BINDINGS_FOUND)
166- exec_program (${PKG_CONFIG_EXECUTABLE}
167- ARGS "--variable=keysdir gnome-keybindings"
168- OUTPUT_VARIABLE keybindingsdir
169- )
170- else (GNOME_KEY_BINDINGS_FOUND)
171- compiz_set (USE_GNOME_KEYBINDINGS 0)
172- endif (GNOME_KEY_BINDINGS_FOUND)
173- endif (USE_GNOME_KEYBINDINGS)
174 else (GTK_WINDOW_DECORATOR_FOUND)
175 compiz_set (USE_GTK 0)
176 endif (GTK_WINDOW_DECORATOR_FOUND)
177
178=== modified file 'plugins/decor/src/decor.cpp'
179--- plugins/decor/src/decor.cpp 2013-10-30 18:02:12 +0000
180+++ plugins/decor/src/decor.cpp 2015-08-05 01:35:01 +0000
181@@ -2537,7 +2537,7 @@
182 {
183 DECOR_WINDOW (w);
184
185- if (dw->isSwitcher && !event->xproperty.state == PropertyDelete)
186+ if (dw->isSwitcher && event->xproperty.state != PropertyDelete)
187 dw->updateSwitcher ();
188 }
189 }
190
191=== modified file 'plugins/opengl/src/programcache.cpp'
192--- plugins/opengl/src/programcache.cpp 2013-01-10 08:19:56 +0000
193+++ plugins/opengl/src/programcache.cpp 2015-08-05 01:35:01 +0000
194@@ -159,7 +159,7 @@
195 // update most recently used GLProgram
196 access_history_t::iterator it = access_history.insert (access_history.end (), name);
197
198- cache.insert (std::make_pair (name, std::make_pair (program, it)));
199+ cache.insert (std::make_pair (name, std::make_pair (boost::shared_ptr<GLProgram>(program), it)));
200 }
201
202 void PrivateProgramCache::evict ()
203
204=== modified file 'plugins/splash/src/splash.cpp'
205--- plugins/splash/src/splash.cpp 2013-05-09 13:43:07 +0000
206+++ plugins/splash/src/splash.cpp 2015-08-05 01:35:01 +0000
207@@ -233,7 +233,7 @@
208 {
209 tex->enable (GLTexture::Good);
210
211- if (!screen->outputDevs ().size () > 1)
212+ if (screen->outputDevs ().size () <= 1)
213 {
214 CompRect headOutputRect =
215 splashGetCurrentOutputRect ();
216
217=== modified file 'src/privatescreen/tests/test-privatescreen.cpp'
218--- src/privatescreen/tests/test-privatescreen.cpp 2014-12-02 18:08:41 +0000
219+++ src/privatescreen/tests/test-privatescreen.cpp 2015-08-05 01:35:01 +0000
220@@ -352,7 +352,7 @@
221 // tell GLib not to use the slice-allocator implementation
222 // and avoid spurious valgrind reporting
223 void glib_nice_for_valgrind() { setenv("G_SLICE", "always-malloc", true); }
224-int const init = (glib_nice_for_valgrind(), 0);
225+__attribute__ ((unused)) int const init = (glib_nice_for_valgrind(), 0);
226
227 PluginFilesystem const* PluginFilesystem::instance = 0;
228

Subscribers

People subscribed via source and target branches